Differential D31752

pf: ensure states passed to pf_free_state() are always unlinked
ClosedPublic
Actions

Authored by kp on Aug 31 2021, 3:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 8, 10:06 AM

	Unknown Object (File)
	Wed, May 8, 4:27 AM

	Unknown Object (File)
	Wed, May 1, 6:18 PM

	Unknown Object (File)
	Sat, Apr 27, 10:16 AM

	Unknown Object (File)
	Tue, Apr 16, 2:46 PM

	Unknown Object (File)
	Apr 13 2024, 12:28 AM

	Unknown Object (File)
	Apr 7 2024, 1:43 AM

	Unknown Object (File)
	Jan 13 2024, 9:44 AM

View All 24 Files

Subscribers

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rGa37c697b8da9: pf: ensure states passed to pf_free_state() are always unlinked
rGa91573da22d2: pf: ensure states passed to pf_free_state() are always unlinked
rGa0c64a443e4c: pf: ensure states passed to pf_free_state() are always unlinked

Summary

In pf_create_state() we can end up deleting the state immediately. This
can happen if we fail to map the relevant addresses or fail
normalization or fail to insert it into the state table.
If that happens we delete the state again with pf_free_state(). However,
this asserts that the state must be unlinked.

It's correct to simply set the state to PFTM_UNLINKED because we've not
yet linked it.

Submitted by: Mateusz Guzik <mjg@FreeBSD.org>
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Aug 31 2021, 3:04 PM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptAug 31 2021, 3:04 PM

kp requested review of this revision.Aug 31 2021, 3:04 PM

Harbormaster completed remote builds in B41292: Diff 94433.Aug 31 2021, 3:04 PM

scottl accepted this revision.Sep 2 2021, 5:33 PM

This revision is now accepted and ready to land.Sep 2 2021, 5:33 PM

Closed by commit rGa0c64a443e4c: pf: ensure states passed to pf_free_state() are always unlinked (authored by kp). · Explain WhySep 3 2021, 8:24 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGa0c64a443e4c: pf: ensure states passed to pf_free_state() are always unlinked.

kp added a commit: rGa91573da22d2: pf: ensure states passed to pf_free_state() are always unlinked.Sep 10 2021, 12:47 PM

kp added a commit: rGa37c697b8da9: pf: ensure states passed to pf_free_state() are always unlinked.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

4 lines

Diff 94608

sys/netpfil/pf/pf.c

Loading...