Differential D59627

nvme: honor FLBAS Format Index Upper when selecting the LBA format
ClosedPublic
Actions

Authored by seuros on Sun, Sep 13, 8:52 AM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Oct 3, 6:48 PM

	Unknown Object (File)
	Sat, Oct 3, 5:36 AM

	Unknown Object (File)
	Fri, Oct 2, 9:22 PM

	Unknown Object (File)
	Fri, Oct 2, 6:38 PM

	Unknown Object (File)
	Fri, Oct 2, 6:00 PM

	Unknown Object (File)
	Thu, Oct 1, 8:55 PM

	Unknown Object (File)
	Thu, Oct 1, 4:35 PM

	Unknown Object (File)
	Thu, Oct 1, 1:14 PM

View All 60 Files

Subscribers

None

Details

Reviewers

imp
dab
adrian
ngie

Group Reviewers

Commits

rG2c41f7d8a034: nvme: honor FLBAS Format Index Upper when selecting the LBA format

Summary

Added nvme_ns_data_format_index() in the nvme, nda, and nvmf
host paths as well as nvmecontrol and camdd.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

seuros created this revision.Sun, Sep 13, 8:52 AM

Herald added a reviewer: cam. · View Herald TranscriptSun, Sep 13, 8:52 AM

seuros requested review of this revision.Sun, Sep 13, 8:52 AM

Harbormaster completed remote builds in B76817: Diff 186562.Sun, Sep 13, 8:52 AM

seuros added a parent revision: D59626: nvme: bound the AER error log byte-swap by the fetched length.Sun, Sep 13, 10:04 AM

seuros added a project: drivers.

seuros added a child revision: D59628: nvme: derive CC.CSS from CAP.CSS instead of hardcoding the NVM set.

This change is fairly straightforward once I understand where the LBA requirement is in the NVMe spec.

sys/dev/nvme/nvme.h
2097–2099	Spec reference? Can these be made into constants for clarity?

refactor

Harbormaster completed remote builds in B77153: Diff 187369.Tue, Sep 22, 3:25 AM

imp accepted this revision.Tue, Sep 22, 4:59 AM

This revision is now accepted and ready to land.Tue, Sep 22, 4:59 AM

Soft approval based on approval from @imp.

seuros marked an inline comment as done.Tue, Sep 22, 10:34 AM

seuros added inline comments.

sys/dev/nvme/nvme.h
2097–2099	Sorry, i was not logged in pharb before. A new spec was released in august 2026 : https://nvmexpress.org/specifications/ I will comment in followup commits with the page where such information is picked up if there is no objection.

adrian accepted this revision.Wed, Sep 23, 12:44 AM

Closed by commit rG2c41f7d8a034: nvme: honor FLBAS Format Index Upper when selecting the LBA format (authored by seuros). · Explain WhyThu, Sep 24, 2:20 PM

This revision was automatically updated to reflect the committed changes.

seuros marked an inline comment as done.

seuros added a commit: rG2c41f7d8a034: nvme: honor FLBAS Format Index Upper when selecting the LBA format.

ken mentioned this in D59530: nvmecontrol: Factor out namespace Identify printing.Tue, Sep 29, 9:11 PM

ken mentioned this in D59531: nvme: Add reservation, format and features command building support.

ken mentioned this in D59535: camcontrol: Support NVMe namespace formatting via the format subcommand.

Revision Contents
Changeset List

Path

Size

sbin/

nvmecontrol/

2 lines

2 lines

2 lines

sys/

cam/

nvme/

2 lines

dev/

nvme/

18 lines

4 lines

nvmf/

host/

4 lines

usr.sbin/

camdd/

2 lines

Diff 187606

sbin/nvmecontrol/devlist.c

Loading...

sbin/nvmecontrol/format.c

Loading...

sbin/nvmecontrol/identify.c

Loading...

sys/cam/nvme/nvme_da.c

Loading...

sys/dev/nvme/nvme.h

Loading...

sys/dev/nvme/nvme_ns.c

Loading...

sys/dev/nvmf/host/nvmf_ns.c

Loading...

usr.sbin/camdd/camdd.c

Loading...