Page MenuHomeFreeBSD
Differential D59625

nvme: reject namespaces formatted with metadata
ClosedPublic
Actions

Authored by seuros on Sun, Sep 13, 8:39 AM.
Tags
Referenced Files
F175402764: D59625.diff
Sat, Oct 10, 2:56 PM
F175394944: D59625.diff
Sat, Oct 10, 1:21 PM
Unknown Object (File)
Wed, Oct 7, 5:30 AM
Unknown Object (File)
Tue, Oct 6, 3:52 AM
Unknown Object (File)
Fri, Oct 2, 3:17 PM
Unknown Object (File)
Fri, Oct 2, 5:25 AM
Unknown Object (File)
Thu, Oct 1, 7:21 PM
Unknown Object (File)
Thu, Oct 1, 5:04 PM
View All 61 Files
Subscribers
dab

Details

Reviewers
imp
adrian
Group Reviewers
cam
Commits
rG416611f05cc4: nvme: reject namespaces formatted with metadata
Summary

The active LBA format's MS field was never examined. I/O to a
metadata-formatted namespace carries neither interleaved metadata
nor MPTR, so every command is malformed, yet the namespace attaches
as a disk with the wrong sector size.

Test Plan

Every change in the stack was test against real hardware , the spec is https://nvmexpress.org/specifications/

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

seuros created this revision.Sun, Sep 13, 8:39 AM
Herald added a reviewer: cam. · View Herald TranscriptSun, Sep 13, 8:39 AM
Herald added a subscriber: dab. · View Herald Transcript
Harbormaster completed remote builds in B76815: Diff 186559.Sun, Sep 13, 8:39 AM
seuros requested review of this revision.Sun, Sep 13, 8:39 AM
seuros edited the test plan for this revision. (Show Details)Sun, Sep 13, 10:02 AM
seuros added a project: drivers.
seuros added a child revision: D59626: nvme: bound the AER error log byte-swap by the fetched length.
seuros added a child revision: D59637: nvme: do not touch INTMS/INTMC when configured for MSI-X.Sun, Sep 13, 10:48 AM
imp accepted this revision.Sun, Sep 13, 6:00 PM

We "should" support this. However, we do not, so this is the right thing to do.

This revision is now accepted and ready to land.Sun, Sep 13, 6:00 PM
adrian accepted this revision.Sun, Sep 13, 6:15 PM
Closed by commit rG416611f05cc4: nvme: reject namespaces formatted with metadata (authored by seuros). · Explain WhySun, Sep 13, 7:54 PM
This revision was automatically updated to reflect the committed changes.
seuros added a commit: rG416611f05cc4: nvme: reject namespaces formatted with metadata.
seuros removed a child revision: D59637: nvme: do not touch INTMS/INTMC when configured for MSI-X.Thu, Sep 24, 5:20 PM

Revision Contents
Changeset List

PathSize
sys/
cam/
nvme/
9 lines
dev/
nvme/
9 lines

Diff 186625

View Options

sys/cam/nvme/nvme_da.c

Loading...
View Options

sys/dev/nvme/nvme_ns.c

Loading...