nvmecontrol: Factor out namespace Identify printing
Needs ReviewPublic
Actions

Authored by ken on Wed, Sep 9, 3:29 PM.

Details

Reviewers

Group Reviewers

Summary

Move print_namespace() from identify.c to identify_ext.c and rename
it to nvme_print_namespace(), to match nvme_print_controller().
This allows other consumers (notably camcontrol(8)) to print NVMe
namespace Identify data.

No functional changes intended.

sbin/nvmecontrol/identify.c:
Remove print_namespace(), and call nvme_print_namespace()
instead.

sbin/nvmecontrol/identify_ext.c:
Add nvme_print_namespace(), moved here from identify.c.

sbin/nvmecontrol/nvmecontrol.h:
Remove the print_namespace() prototype.

sbin/nvmecontrol/nvmecontrol_ext.h:
Add the nvme_print_namespace() prototype.

sbin/nvmecontrol/ns.c:
Include nvmecontrol_ext.h, and rename print_namespace() calls
to nvme_print_namespace().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 77505
Build 74388: arc lint + arc unit

Event Timeline

ken created this revision.Wed, Sep 9, 3:29 PM

Herald added subscribers: dab, imp. · View Herald TranscriptWed, Sep 9, 3:29 PM

ken requested review of this revision.Wed, Sep 9, 3:29 PM

Harbormaster completed remote builds in B76695: Diff 186273.Wed, Sep 9, 3:29 PM

ken added a reviewer: cam.Wed, Sep 9, 3:33 PM

ken added a child revision: D59533: camcontrol: Add support for NVMe namespace Identify.

ken edited the summary of this revision. (Show Details)Wed, Sep 9, 3:40 PM

imp accepted this revision.Wed, Sep 9, 7:30 PM

This revision is now accepted and ready to land.Wed, Sep 9, 7:30 PM

Rebase on current head. The moved nvme_print_namespace() now carries the FLBAS Format Index Upper fix from D59627 (2c41f7d8), which landed inside print_namespace() after this review was created.

This revision now requires review to proceed.Tue, Sep 29, 9:11 PM

Harbormaster completed remote builds in B77505: Diff 188140.Tue, Sep 29, 9:11 PM