asmc: register the fan id sysctl with a string format
AcceptedPublic
Actions

Authored by seuros on Thu, Nov 12, 9:28 PM.

Project Tags

None

Referenced Files

	F177526368: D61484.1794630583.diff
	Fri, Nov 13, 4:29 AM

	F177526351: D61484.1794630547.diff
	Fri, Nov 13, 4:29 AM

	F177525830: D61484.1794629431.diff
	Fri, Nov 13, 4:10 AM

	F177519229: D61484.1794612662.diff
	Thu, Nov 12, 11:31 PM

	F177519206: D61484.1794612613.diff
	Thu, Nov 12, 11:30 PM

Subscribers

imp

Details

Reviewers

adrian
ngie

Group Reviewers

drivers
apple (x86)

Summary

Every fan sysctl was registered with a hardcoded "I" format, but id
is CTLTYPE_STRING. Carry the format in the table instead.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 79048
Build 75931: arc lint + arc unit

Event Timeline

seuros created this revision.Thu, Nov 12, 9:28 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Nov 12, 9:28 PM

seuros requested review of this revision.Thu, Nov 12, 9:28 PM

Harbormaster completed remote builds in B79048: Diff 192365.Thu, Nov 12, 9:28 PM

seuros added a parent revision: D61483: asmc: clear the sensor counts in detach.Thu, Nov 12, 9:29 PM

seuros added a child revision: D61485: asmc: propagate sysctl read and write errors.Thu, Nov 12, 9:36 PM

ngie accepted this revision.Fri, Nov 13, 1:45 AM

This revision is now accepted and ready to land.Fri, Nov 13, 1:45 AM

I don't remember the exact details, but there's a check kicking around somewhere (maybe left behind at my old job) that would check the sysctl format vs the type.

Revision Contents
Changeset List

Path

Size

sys/

dev/

asmc/

asmc_sysctl.c

20 lines

Diff 192365

View Options

sys/dev/asmc/asmc_sysctl.c

asmc: register the fan id sysctl with a string formatAcceptedPublicActions