asmc: Use c99 initializers with for-loop counters to improve scoping
Needs ReviewPublic
Actions

Authored by seuros on Sat, Nov 7, 5:04 PM.

Project Tags

None

Referenced Files

	F177359326: D61301.1794193588.diff
	Sun, Nov 8, 3:06 AM

	F177358675: D61301.1794192053.diff
	Sun, Nov 8, 2:40 AM

	F177354052: D61301.1794180370.diff
	Sat, Nov 7, 11:26 PM

	F177348197: D61301.1794166195.diff
	Sat, Nov 7, 7:29 PM

	F177347334: D61301.1794164404.diff
	Sat, Nov 7, 7:00 PM

	F177346998: D61301.1794163920.diff
	Sat, Nov 7, 6:52 PM

	F177346677: D61301.1794163440.diff
	Sat, Nov 7, 6:44 PM

Subscribers

imp

Details

Reviewers

ngie
imp

Summary

declared loop indices in the for statement
Index types are unchanged.

No functional change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 78854
Build 75737: arc lint + arc unit

Event Timeline

seuros created this revision.Sat, Nov 7, 5:04 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Nov 7, 5:04 PM

seuros requested review of this revision.Sat, Nov 7, 5:04 PM

Harbormaster completed remote builds in B78825: Diff 191835.Sat, Nov 7, 5:04 PM

seuros added a parent revision: D61300: asmc: split the sysctl layer into asmcsysctl.c.Sat, Nov 7, 5:34 PM

seuros added a child revision: D61302: asmc: Fix style(9) issues.

“Use c99 initializers with for-loop counters to improve scoping”?

seuros retitled this revision from asmc: declare loop indices in the for statement to asmc: Use c99 initializers with for-loop counters to improve scoping.Sun, Nov 8, 6:38 AM

seuros edited the summary of this revision. (Show Details)

imp accepted this revision.Sun, Nov 8, 6:42 AM

This revision is now accepted and ready to land.Sun, Nov 8, 6:42 AM

rename

This revision now requires review to proceed.Sun, Nov 8, 9:40 AM

Harbormaster completed remote builds in B78854: Diff 191895.Sun, Nov 8, 9:40 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

asmc/

11 lines

3 lines

10 lines

8 lines

3 lines

Diff 191895

View Options

sys/dev/asmc/asmc.c

View Options

sys/dev/asmc/asmc_debug.c

View Options

sys/dev/asmc/asmc_pio.c

View Options

sys/dev/asmc/asmc_sysctl.c

View Options

asmc: Use c99 initializers with for-loop counters to improve scopingNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 191895

sys/dev/asmc/asmc.c

sys/dev/asmc/asmc_debug.c

sys/dev/asmc/asmc_pio.c

sys/dev/asmc/asmc_sysctl.c

sys/dev/asmc/asmcmmio.c

asmc: Use c99 initializers with for-loop counters to improve scoping
Needs ReviewPublic
Actions

Revision Contents
Changeset List