Page MenuHomeFreeBSD
Differential D56638

Vendor import of smart at 1.0.2
ClosedPublic
Actions

Authored by chuck on Apr 25 2026, 8:50 PM.
Tags
None
Referenced Files
F173914632: D56638.id176662.diff
Tue, Sep 29, 8:01 AM
F173897923: D56638.diff
Tue, Sep 29, 5:01 AM
F173887048: D56638.id176512.diff
Tue, Sep 29, 3:18 AM
F173886892: D56638.id176513.diff
Tue, Sep 29, 3:16 AM
F173886645: D56638.id176662.diff
Tue, Sep 29, 3:14 AM
F173885860: D56638.id176742.diff
Tue, Sep 29, 3:07 AM
F173884732: D56638.id176656.diff
Tue, Sep 29, 2:59 AM
F173883359: D56638.id176661.diff
Tue, Sep 29, 2:43 AM
View All Files
Subscribers
imp

Details

Reviewers
fuz
ziaee
jrm
Commits
rG25942dddc8a8: smart: Connect contrib/smart to build
rG68e5b71517e9: Vendor import of smart at 1.0.2
Summary

smart/diskhealth is a command line application to monitor disk health
from a storage device via SMART.

Relnotes: yes

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chuck created this revision.Apr 25 2026, 8:50 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 25 2026, 8:50 PM
chuck requested review of this revision.Apr 25 2026, 8:50 PM
Harbormaster completed remote builds in B72548: Diff 176512.Apr 25 2026, 8:50 PM
chuck updated this revision to Diff 176513.Apr 25 2026, 8:59 PM

Fix trailing whitespace

Harbormaster completed remote builds in B72549: Diff 176513.Apr 25 2026, 8:59 PM
jrm added inline comments.Apr 27 2026, 3:17 PM
contrib/smart/LICENSE
2–13

You might consider updating the date and using an SPDX identifier.

contrib/smart/libsmart_desc.c
77
contrib/smart/smart.8
181

Are the .Pps macros valid mdoc(7)?

contrib/smart/smart.c
30
jrm added inline comments.Apr 27 2026, 4:08 PM
contrib/smart/smart.8
125
chuck updated this revision to Diff 176656.Apr 27 2026, 6:14 PM
chuck marked an inline comment as done.

Update with jrm@ review feedback

Harbormaster completed remote builds in B72579: Diff 176656.Apr 27 2026, 6:14 PM
fuz accepted this revision.Apr 27 2026, 6:19 PM

LGTM, though adding a man page link for diskhealth would be helpful.

contrib/smart/Makefile
21
This revision is now accepted and ready to land.Apr 27 2026, 6:19 PM
chuck marked an inline comment as done.Apr 27 2026, 6:27 PM
chuck added inline comments.
contrib/smart/smart.8
125

Good catch!

181

It's possible I misunderstood the comments in the other review, but I think .Pps is what @ziaee wanted here

jrm added inline comments.Apr 27 2026, 6:32 PM
contrib/smart/smart.8
181

I'm guessing @ziaee meant .Pps, as in the plural of .Pp.

jrm accepted this revision.Apr 27 2026, 6:33 PM
chuck updated this revision to Diff 176661.Apr 27 2026, 6:51 PM

Add link to man page for diskhealth

This revision now requires review to proceed.Apr 27 2026, 6:51 PM
Harbormaster completed remote builds in B72583: Diff 176661.Apr 27 2026, 6:51 PM
chuck updated this revision to Diff 176662.Apr 27 2026, 6:55 PM

Remove invalid mdoc macro

Harbormaster completed remote builds in B72584: Diff 176662.Apr 27 2026, 6:55 PM
jrm accepted this revision.Apr 27 2026, 7:01 PM
This revision is now accepted and ready to land.Apr 27 2026, 7:01 PM
Closed by commit rG68e5b71517e9: Vendor import of smart at 1.0.2 (authored by chuck). · Explain WhyApr 28 2026, 5:10 PM
This revision was automatically updated to reflect the committed changes.
chuck added a commit: rG68e5b71517e9: Vendor import of smart at 1.0.2.
chuck added a reverting change: rGe139a49b5d8e: Revert "Vendor import of smart at 1.0.2".Apr 28 2026, 7:04 PM
chuck added a commit: rG25942dddc8a8: smart: Connect contrib/smart to build.May 11 2026, 10:21 PM

Revision Contents
Changeset List

PathSize
contrib/
smart/
37 lines
13 lines
26 lines
828 lines
174 lines
1359 lines
158 lines
60 lines
83 lines
245 lines
334 lines
packages/
1 line
smart/
4 lines
30 lines
usr.sbin/
1 line
smart/
8 lines

Diff 176742

View Options

contrib/smart/Changelog

Loading...
View Options

contrib/smart/LICENSE

Loading...
View Options

contrib/smart/Makefile

Loading...
View Options

contrib/smart/freebsd_dev.c

Loading...
View Options

contrib/smart/libsmart.h

Loading...
View Options

contrib/smart/libsmart.c

Loading...
View Options

contrib/smart/libsmart_desc.c

Loading...
View Options

contrib/smart/libsmart_dev.h

Loading...
View Options

contrib/smart/libsmart_priv.h

Loading...
View Options

contrib/smart/smart.8

Loading...
View Options

contrib/smart/smart.c

Loading...
View Options

packages/Makefile

Loading...
View Options

packages/smart/Makefile

Loading...
View Options

packages/smart/smart.ucl

Loading...
View Options

usr.sbin/Makefile

Loading...
View Options

usr.sbin/smart/Makefile

Loading...