Page MenuHomeFreeBSD
Differential D56638

Vendor import of smart at 1.0.2
ClosedPublic
Actions

Authored by chuck on Sat, Apr 25, 8:50 PM.
Tags
None
Referenced Files
F154442161: D56638.diff
Tue, Apr 28, 2:21 PM
F154412761: D56638.id176512.diff
Tue, Apr 28, 9:55 AM
F154407558: D56638.id176513.diff
Tue, Apr 28, 9:27 AM
Unknown Object (File)
Mon, Apr 27, 7:13 AM
Subscribers
imp

Details

Reviewers
fuz
ziaee
jrm
Commits
rG68e5b71517e9: Vendor import of smart at 1.0.2
Summary

smart/diskhealth is a command line application to monitor disk health
from a storage device via SMART.

Relnotes: yes

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72549
Build 69432: arc lint + arc unit

Event Timeline

chuck created this revision.Sat, Apr 25, 8:50 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Apr 25, 8:50 PM
chuck requested review of this revision.Sat, Apr 25, 8:50 PM
Harbormaster completed remote builds in B72548: Diff 176512.Sat, Apr 25, 8:50 PM
chuck updated this revision to Diff 176513.Sat, Apr 25, 8:59 PM

Fix trailing whitespace

Harbormaster completed remote builds in B72549: Diff 176513.Sat, Apr 25, 8:59 PM
jrm added inline comments.Mon, Apr 27, 3:17 PM
contrib/smart/LICENSE
1–12

You might consider updating the date and using an SPDX identifier.

contrib/smart/libsmart_desc.c
76
contrib/smart/smart.8
180

Are the .Pps macros valid mdoc(7)?

contrib/smart/smart.c
29
jrm added inline comments.Mon, Apr 27, 4:08 PM
contrib/smart/smart.8
124
chuck updated this revision to Diff 176656.Mon, Apr 27, 6:14 PM
chuck marked an inline comment as done.

Update with jrm@ review feedback

Harbormaster completed remote builds in B72579: Diff 176656.Mon, Apr 27, 6:14 PM
fuz accepted this revision.Mon, Apr 27, 6:19 PM

LGTM, though adding a man page link for diskhealth would be helpful.

contrib/smart/Makefile
21
This revision is now accepted and ready to land.Mon, Apr 27, 6:19 PM
chuck marked an inline comment as done.Mon, Apr 27, 6:27 PM
chuck added inline comments.
contrib/smart/smart.8
124

Good catch!

180

It's possible I misunderstood the comments in the other review, but I think .Pps is what @ziaee wanted here

jrm added inline comments.Mon, Apr 27, 6:32 PM
contrib/smart/smart.8
180

I'm guessing @ziaee meant .Pps, as in the plural of .Pp.

jrm accepted this revision.Mon, Apr 27, 6:33 PM
chuck updated this revision to Diff 176661.Mon, Apr 27, 6:51 PM

Add link to man page for diskhealth

This revision now requires review to proceed.Mon, Apr 27, 6:51 PM
Harbormaster completed remote builds in B72583: Diff 176661.Mon, Apr 27, 6:51 PM
chuck updated this revision to Diff 176662.Mon, Apr 27, 6:55 PM

Remove invalid mdoc macro

Harbormaster completed remote builds in B72584: Diff 176662.Mon, Apr 27, 6:55 PM
jrm accepted this revision.Mon, Apr 27, 7:01 PM
This revision is now accepted and ready to land.Mon, Apr 27, 7:01 PM
Closed by commit rG68e5b71517e9: Vendor import of smart at 1.0.2 (authored by chuck). · Explain WhyTue, Apr 28, 5:10 PM
This revision was automatically updated to reflect the committed changes.
chuck added a commit: rG68e5b71517e9: Vendor import of smart at 1.0.2.
chuck added a reverting change: rGe139a49b5d8e: Revert "Vendor import of smart at 1.0.2".Tue, Apr 28, 7:04 PM

Revision Contents
Changeset List

PathSize
contrib/
smart/
37 lines
13 lines
25 lines
828 lines
174 lines
1359 lines
158 lines
60 lines
83 lines
250 lines
334 lines
packages/
1 line
smart/
4 lines
30 lines
usr.sbin/
1 line
smart/
8 lines

Diff 176513

View Options

contrib/smart/Changelog

Loading...
View Options

contrib/smart/LICENSE

Loading...
View Options

contrib/smart/Makefile

Loading...
View Options

contrib/smart/freebsd_dev.c

Loading...
View Options

contrib/smart/libsmart.h

Loading...
View Options

contrib/smart/libsmart.c

Loading...
View Options

contrib/smart/libsmart_desc.c

Loading...
View Options

contrib/smart/libsmart_dev.h

Loading...
View Options

contrib/smart/libsmart_priv.h

Loading...
View Options

contrib/smart/smart.8

Loading...
View Options

contrib/smart/smart.c

Loading...
View Options

packages/Makefile

Loading...
View Options

packages/smart/Makefile

Loading...
View Options

packages/smart/smart.ucl

Loading...
View Options

usr.sbin/Makefile

Loading...
View Options

usr.sbin/smart/Makefile

Loading...