Page MenuHomeFreeBSD
Differential D44121

nvme: Firmware revisions in the firmware slot information log are ASCII strings
ClosedPublic
Actions

Authored by jhb on Feb 27 2024, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 2:00 AM
Unknown Object (File)
Thu, Sep 25, 2:06 AM
Unknown Object (File)
Sep 20 2025, 5:18 PM
Unknown Object (File)
Sep 10 2025, 12:44 PM
Unknown Object (File)
Aug 26 2025, 7:10 AM
Unknown Object (File)
Aug 26 2025, 6:28 AM
Unknown Object (File)
Aug 11 2025, 10:52 AM
Unknown Object (File)
Jul 30 2025, 10:04 PM
View All 79 Files
Subscribers
dab

Details

Reviewers
imp
chuck
Commits
rG4329e6ccfa4a: nvme: Firmware revisions in the firmware slot info logpage are ASCII strings
rG16089905240f: nvme: Firmware revisions in the firmware slot info logpage are ASCII strings
rG7485926e09a0: nvme: Firmware revisions in the firmware slot info logpage are ASCII strings
Summary

In particular, don't try to byteswap the values as 64-bit integers and
always print a non-empty version as a string.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Feb 27 2024, 7:34 PM
Herald added a subscriber: dab. · View Herald TranscriptFeb 27 2024, 7:34 PM
jhb requested review of this revision.Feb 27 2024, 7:34 PM
Harbormaster completed remote builds in B56291: Diff 135102.Feb 27 2024, 7:34 PM
jhb added inline comments.Feb 27 2024, 7:34 PM
sys/dev/nvme/nvme.h
2009–2010

Not sure if you'd rather me just remove this now-empty function outright?

imp accepted this revision.Feb 27 2024, 11:18 PM

Delete it or not, I'm agnostic, so long as it compiles :)

sys/dev/nvme/nvme.h
2009–2010

I'd delete it. This is a string, not a uint64_t...

This revision is now accepted and ready to land.Feb 27 2024, 11:18 PM
chuck accepted this revision.Feb 28 2024, 3:18 PM

LGTM

jhb marked an inline comment as done.Mar 1 2024, 10:11 PM
Closed by commit rG7485926e09a0: nvme: Firmware revisions in the firmware slot info logpage are ASCII strings (authored by jhb). · Explain WhyMar 1 2024, 10:20 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG7485926e09a0: nvme: Firmware revisions in the firmware slot info logpage are ASCII strings.
jhb added a commit: rG16089905240f: nvme: Firmware revisions in the firmware slot info logpage are ASCII strings.Apr 8 2024, 7:06 PM
jhb added a commit: rG4329e6ccfa4a: nvme: Firmware revisions in the firmware slot info logpage are ASCII strings.Apr 8 2024, 8:26 PM

Revision Contents
Changeset List

PathSize
sbin/
nvmecontrol/
13 lines
sys/
dev/
nvme/
14 lines
4 lines

Diff 135295

View Options

sbin/nvmecontrol/logpage.c

Loading...
View Options

sys/dev/nvme/nvme.h

Loading...
View Options

sys/dev/nvme/nvme_ctrlr.c

Loading...