Differential D59828

nvme: support per-request timeouts
AcceptedPublic
Actions

Authored by imp on Sat, Sep 19, 3:47 AM.

Tags

Referenced Files

	F175315888: D59828.diff
	Fri, Oct 9, 9:54 PM

	Unknown Object (File)
	Wed, Oct 7, 7:07 AM

	Unknown Object (File)
	Sun, Oct 4, 3:18 PM

	Unknown Object (File)
	Sun, Oct 4, 11:16 AM

	Unknown Object (File)
	Fri, Oct 2, 11:47 PM

	Unknown Object (File)
	Fri, Oct 2, 4:41 PM

	Unknown Object (File)
	Fri, Oct 2, 1:46 PM

	Unknown Object (File)
	Fri, Oct 2, 9:52 AM

View All 40 Files

Subscribers

markmi_dsl-only.net

Details

Reviewers

seuros
chs
mav
chuck

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77075
Build 73958: arc lint + arc unit

Event Timeline

imp created this revision.Sat, Sep 19, 3:47 AM

Herald added a subscriber: dab. · View Herald TranscriptSat, Sep 19, 3:47 AM

imp requested review of this revision.Sat, Sep 19, 3:47 AM

Harbormaster completed remote builds in B77075: Diff 187192.Sat, Sep 19, 3:47 AM

imp added a parent revision: D59827: nvme: add a timeout for Format NVM commands.Sat, Sep 19, 3:47 AM

imp added a child revision: D59829: nvme: honor Linux passthrough command timeouts.

I tested this (also with D59827) in a personal kernel build to format a DC P4800 Optane ("INTEL SSDPE21K015TA E2010650") to be 4096 based (no meta data) with "sysctl dev.nvme.0.format_timeout_period=1800" (so: 30 min) and it finished fine in a little under 23 minutes, waiting as it should.

seuros accepted this revision.Sun, Sep 20, 12:08 PM

This revision is now accepted and ready to land.Sun, Sep 20, 12:08 PM

seuros added a project: drivers.Thu, Sep 24, 5:04 PM

imp mentioned this in D59535: camcontrol: Support NVMe namespace formatting via the format subcommand.Fri, Sep 25, 5:36 PM

chuck accepted this revision.Mon, Oct 5, 5:05 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

2 lines

8 lines

17 lines

Diff 187192

sys/dev/nvme/nvme_ctrlr.c

Loading...

sys/dev/nvme/nvme_private.h

Loading...

sys/dev/nvme/nvme_qpair.c

Loading...