Differential D59828

nvme: support per-request timeouts
ClosedPublic
Actions

Authored by imp on Sep 19 2026, 3:47 AM.

Project Tags

Referenced Files

None

Subscribers

markmi_dsl-only.net

Details

Reviewers

seuros
chs
mav
chuck

Commits

rG1c31ef40e185: nvme: support per-request timeouts

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Sep 19 2026, 3:47 AM

Herald added a subscriber: dab. · View Herald TranscriptSep 19 2026, 3:47 AM

imp requested review of this revision.Sep 19 2026, 3:47 AM

Harbormaster completed remote builds in B77075: Diff 187192.Sep 19 2026, 3:47 AM

imp added a parent revision: D59827: nvme: add a timeout for Format NVM commands.Sep 19 2026, 3:47 AM

imp added a child revision: D59829: nvme: honor Linux passthrough command timeouts.

I tested this (also with D59827) in a personal kernel build to format a DC P4800 Optane ("INTEL SSDPE21K015TA E2010650") to be 4096 based (no meta data) with "sysctl dev.nvme.0.format_timeout_period=1800" (so: 30 min) and it finished fine in a little under 23 minutes, waiting as it should.

seuros accepted this revision.Sep 20 2026, 12:08 PM

This revision is now accepted and ready to land.Sep 20 2026, 12:08 PM

seuros added a project: drivers.Sep 24 2026, 5:04 PM

imp mentioned this in D59535: camcontrol: Support NVMe namespace formatting via the format subcommand.Sep 25 2026, 5:36 PM

chuck accepted this revision.Mon, Oct 5, 5:05 PM

Closed by commit rG1c31ef40e185: nvme: support per-request timeouts. · Explain WhyMon, Oct 19, 6:24 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG1c31ef40e185: nvme: support per-request timeouts.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

2 lines

8 lines

17 lines

Diff 190247

sys/dev/nvme/nvme_ctrlr.c

Loading...

sys/dev/nvme/nvme_private.h

Loading...

sys/dev/nvme/nvme_qpair.c

Loading...