nvmecontrol: support controller-wide sector sizes
AcceptedPublic
Actions

Authored by imp on Sat, Sep 19, 3:47 AM.

Details

Reviewers

seuros
chs
mav
chuck

Summary

Extend sector-size selection to controller-wide formats when every
namespace has one compatible format index and matching effective
metadata and protection settings. Reject ambiguous or inconsistent
layouts so heterogeneous fleets can request a sector size without
risking an unintended controller-wide format.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77081
Build 73964: arc lint + arc unit

Event Timeline

imp created this revision.Sat, Sep 19, 3:47 AM

Herald added subscribers: ziaee, dab. · View Herald TranscriptSat, Sep 19, 3:47 AM

imp requested review of this revision.Sat, Sep 19, 3:47 AM

Harbormaster completed remote builds in B77081: Diff 187198.Sat, Sep 19, 3:47 AM

imp added a parent revision: D59833: nvmecontrol: select format by sector size.Sat, Sep 19, 3:47 AM

imp added a child revision: D59835: nvmecontrol: add format dry-run support.

seuros accepted this revision.Fri, Oct 2, 8:02 AM

This revision is now accepted and ready to land.Fri, Oct 2, 8:02 AM

chuck added inline comments.Mon, Oct 5, 4:50 PM

sbin/nvmecontrol/format.c
260	When the user specifies both `sector_size` and `lbaf`, is the intent to override `lbaf` with the sector size derived value? If so, maybe add a warning in the man pages as this might be hard to guess?