When we're doing admin-passhtru, we need to use the admin device, not
the namespace device. So when we're passed in ndaX or nvdX, we need to
translate that to nvmeY for this command for the admin-passthru command,
but not the io-passthru command. Note namespace nuance in man page.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Sep 21 2026, 4:57 PM

Herald added subscribers: ziaee, dab. · View Herald TranscriptSep 21 2026, 4:57 PM

imp requested review of this revision.Sep 21 2026, 4:57 PM

Harbormaster completed remote builds in B77141: Diff 187348.Sep 21 2026, 4:57 PM

imp added a parent revision: D59835: nvmecontrol: add format dry-run support.Sep 21 2026, 4:58 PM

imp added reviewers: seuros, mav, chuck, chs, ken.

ziaee added a reviewer: manpages.Sep 21 2026, 5:10 PM

ziaee added inline comments.

sbin/nvmecontrol/nvmecontrol.8
769	This line was 85 characters and will whine the linter.

rpokala subscribed.Sep 21 2026, 5:25 PM

rpokala added inline comments.

sbin/nvmecontrol/nvmecontrol.8
769	Will the `.Pq` capture the terminal `.`, or will that remain outside the parens?

ziaee added inline comments.Sep 21 2026, 6:46 PM

sbin/nvmecontrol/nvmecontrol.8
769	It will go outside. Also, it should never be inside. Parens is like a subshell inside a sentence.

chuck added inline comments.Sep 21 2026, 11:18 PM

sbin/nvmecontrol/nvmecontrol.8
769	Looking at Figure 141: Opcodes for Admin Commands in the 1.4 spec, there are quite a few Admin commands which list "Yes" under the "Namespace Identifier Used" column. Perhaps I'm misunderstanding something, but is "ignored for admin" what we want?

imp added inline comments.Sep 21 2026, 11:33 PM

sbin/nvmecontrol/nvmecontrol.8
769	It means that the kernel will fill in a value. This may be bogus, but it's what the kernel will do. It won't use the value we pass in. For the I/O endpoint, the kernel doesn't have this behavior. Not sure why.