nvmecontrol: add format dry-run support
AcceptedPublic
Actions

Authored by imp on Sat, Sep 19, 3:48 AM.

Details

Reviewers

seuros
chs
mav
chuck

Summary

Add -n/--dry-run to resolve and print the Format NVM command without
submitting it. This lets users verify namespace selection and format
parameters before making destructive media changes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77082
Build 73965: arc lint + arc unit

Event Timeline

imp created this revision.Sat, Sep 19, 3:48 AM

Herald added subscribers: ziaee, dab. · View Herald TranscriptSat, Sep 19, 3:48 AM

imp requested review of this revision.Sat, Sep 19, 3:48 AM

Harbormaster completed remote builds in B77082: Diff 187199.Sat, Sep 19, 3:48 AM

imp added a parent revision: D59834: nvmecontrol: support controller-wide sector sizes.Sat, Sep 19, 3:48 AM

imp added a child revision: D59878: nvmecontrol: Use admin device for admin-passthru.Mon, Sep 21, 4:58 PM

seuros accepted this revision.Fri, Oct 2, 8:03 AM

This revision is now accepted and ready to land.Fri, Oct 2, 8:03 AM

chuck accepted this revision.Mon, Oct 5, 3:58 PM

chuck added inline comments.

sbin/nvmecontrol/format.c
325	Super, extreme nit. There's a bit of inconsistency in the driver around whether logging prints `NSID` as a decimal or hexadecimal value. From a quick `grep`, it appears more (2 of 3) use the decimal format. Given that most values are single digit anyway, this ends mostly fine.