nvmecontrol: add format dry-run support
ClosedPublic
Actions

Authored by imp on Sep 19 2026, 3:48 AM.

Project Tags

None

Referenced Files

None

Subscribers

dab

ziaee

Details

Reviewers

seuros
chs
mav
chuck

Commits

rG3b66efc6e9b8: nvmecontrol: add format dry-run support

Summary

Add -n/--dry-run to resolve and print the Format NVM command without
submitting it. This lets users verify namespace selection and format
parameters before making destructive media changes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Sep 19 2026, 3:48 AM

Herald added subscribers: ziaee, dab. · View Herald TranscriptSep 19 2026, 3:48 AM

imp requested review of this revision.Sep 19 2026, 3:48 AM

Harbormaster completed remote builds in B77082: Diff 187199.Sep 19 2026, 3:48 AM

imp added a parent revision: D59834: nvmecontrol: support controller-wide sector sizes.Sep 19 2026, 3:48 AM

imp added a child revision: D59878: nvmecontrol: Use admin device for admin-passthru.Sep 21 2026, 4:58 PM

seuros accepted this revision.Fri, Oct 2, 8:03 AM

This revision is now accepted and ready to land.Fri, Oct 2, 8:03 AM

chuck accepted this revision.Mon, Oct 5, 3:58 PM

chuck added inline comments.

sbin/nvmecontrol/format.c
325	Super, extreme nit. There's a bit of inconsistency in the driver around whether logging prints `NSID` as a decimal or hexadecimal value. From a quick `grep`, it appears more (2 of 3) use the decimal format. Given that most values are single digit anyway, this ends mostly fine.