nvme: Always print the opcode hex and sct/sc hex values
ClosedPublic
Actions

Authored by imp on Sep 3 2025, 5:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 15, 8:23 AM

	Unknown Object (File)
	Tue, Oct 14, 2:13 AM

	Unknown Object (File)
	Sun, Oct 12, 4:35 PM

	Unknown Object (File)
	Sat, Oct 11, 10:56 PM

	Unknown Object (File)
	Sat, Oct 11, 10:56 PM

	Unknown Object (File)
	Sat, Oct 11, 10:56 PM

	Unknown Object (File)
	Sat, Oct 11, 1:36 PM

	Unknown Object (File)
	Thu, Oct 9, 9:14 PM

View All 32 Files

Subscribers

dab

Details

Reviewers

jhb
chs
chuck
mav

Commits

rGe26521574ecc: nvme: Always print the opcode hex and sct/sc hex values

Summary

While we can lookup the opcode and know exactly what we meant, sharing
error messages with vendors can lead to some ambiguity. Go ahead and
include the hex values for the error messages to aid in debugging.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Sep 3 2025, 5:26 AM

Herald added a subscriber: dab. · View Herald TranscriptSep 3 2025, 5:26 AM

imp requested review of this revision.Sep 3 2025, 5:26 AM

Harbormaster completed remote builds in B66774: Diff 161407.Sep 3 2025, 5:26 AM

imp added reviewers: jhb, chs, chuck, mav.Sep 3 2025, 5:27 AM

chuck accepted this revision.Sep 3 2025, 2:01 PM

This revision is now accepted and ready to land.Sep 3 2025, 2:01 PM

Closed by commit rGe26521574ecc: nvme: Always print the opcode hex and sct/sc hex values (authored by imp). · Explain WhySep 3 2025, 3:56 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGe26521574ecc: nvme: Always print the opcode hex and sct/sc hex values.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme_util.c

23 lines

Diff 161434

View Options

nvme: Always print the opcode hex and sct/sc hex valuesClosedPublicActions