Tags

None

Referenced Files

	F166733387: D44650.id.diff
	Sat, Aug 15, 10:35 PM

	F166729078: D44650.id136613.diff
	Sat, Aug 15, 9:44 PM

	F166712529: D44650.id137215.diff
	Sat, Aug 15, 8:12 PM

	Unknown Object (File)
	Fri, Aug 14, 7:28 PM

	Unknown Object (File)
	Thu, Aug 13, 9:11 PM

	Unknown Object (File)
	Thu, Aug 13, 3:09 PM

	Unknown Object (File)
	Wed, Aug 12, 2:56 PM

	Unknown Object (File)
	Sun, Aug 9, 9:28 AM

View All Files

Subscribers

dab

Details

Reviewers

jhb
chuck
mav

Commits

rG78e2c1882b2f: nvmecontrol: Have to truncate on all 32-bit architectures
rGe098d24b5290: nvmecontrol: Have to truncate on all 32-bit architectures

Summary

armv7, powerpc, powerpcspe and i386 all lack 128-bit integer
types. Adjust the comment and #ifdef. I don't think we support nvme on
any of these other architectures at the moment, but it won't hurt to be
more precise.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Apr 6 2024, 6:55 PM

Herald added a subscriber: dab. · View Herald TranscriptApr 6 2024, 6:55 PM

imp requested review of this revision.Apr 6 2024, 6:55 PM

Harbormaster completed remote builds in B56934: Diff 136613.Apr 6 2024, 6:55 PM

imp added a child revision: D44651: nvmecontrol: Fix to128 for big endian targets.Apr 6 2024, 6:56 PM

chuck accepted this revision.Apr 8 2024, 1:59 PM

This revision is now accepted and ready to land.Apr 8 2024, 1:59 PM

imp mentioned this in D44690: sys: Enable NVMe drivers on all architectures.Apr 8 2024, 11:00 PM

I used SIZEOF_LONG == 4 locally.

sbin/nvmecontrol/nvmecontrol.h
94	I fixed the i386 in this part of the comment as well.

Closed by commit rGe098d24b5290: nvmecontrol: Have to truncate on all 32-bit architectures (authored by imp). · Explain WhyApr 17 2024, 3:34 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGe098d24b5290: nvmecontrol: Have to truncate on all 32-bit architectures.

jhb added a commit: rG78e2c1882b2f: nvmecontrol: Have to truncate on all 32-bit architectures.Aug 27 2024, 1:07 AM

nvmecontrol: Have to truncate on all 32-bit architectures
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 137215

sbin/nvmecontrol/nvmecontrol.h

nvmecontrol: Have to truncate on all 32-bit architecturesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 137215

sbin/nvmecontrol/nvmecontrol.h

nvmecontrol: Have to truncate on all 32-bit architectures
ClosedPublic
Actions

Revision Contents
Changeset List