Paths

Table of Contentst

Differential D44654

nvmecontrol: Move self test status page printing to little endian orderinng
ClosedPublic
Actions

Authored by imp on Sat, Apr 6, 6:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 30, 12:58 PM

	Unknown Object (File)
	Sat, Apr 27, 1:35 PM

	Unknown Object (File)
	Fri, Apr 26, 4:49 AM

	Unknown Object (File)
	Wed, Apr 17, 9:36 AM

	Unknown Object (File)
	Wed, Apr 10, 3:46 AM

	Unknown Object (File)
	Wed, Apr 10, 3:46 AM

	Unknown Object (File)
	Tue, Apr 9, 9:37 PM

	Unknown Object (File)
	Mon, Apr 8, 11:48 AM

Subscribers

Details

Reviewers

jhb
chuck
mav

Commits

rG98f841efd8ce: nvmecontrol: Move self test status page printing to little endian orderinng

Summary

Also, add printing vnedor_specific field, which doesn't have a valid
bit, so is always valid.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Sat, Apr 6, 6:56 PM

Herald added a subscriber: dab. · View Herald TranscriptSat, Apr 6, 6:56 PM

imp requested review of this revision.Sat, Apr 6, 6:56 PM

Harbormaster completed remote builds in B56938: Diff 136617.Sat, Apr 6, 6:56 PM

imp added a parent revision: D44653: nvmecontrol: Move namespace change page printing to little endian orderinng.Sat, Apr 6, 6:56 PM

imp added a child revision: D44655: nvmecontrol: Move command effeccts page printing to little endian orderinng.

chuck accepted this revision.Mon, Apr 8, 3:10 PM

chuck added inline comments.

sbin/nvmecontrol/logpage.c
593	Probably wrap this with `LE2H()` for consistency
634–635	Shouldn't the if expressions wrap `valid_diag_info` to be consistent? Here and below.

This revision is now accepted and ready to land.Mon, Apr 8, 3:10 PM

Fix based on review feedback

This revision now requires review to proceed.Mon, Apr 8, 4:57 PM

Harbormaster completed remote builds in B56961: Diff 136686.Mon, Apr 8, 4:57 PM

chuck accepted this revision.Mon, Apr 8, 5:06 PM

This revision is now accepted and ready to land.Mon, Apr 8, 5:06 PM

Closed by commit rG98f841efd8ce: nvmecontrol: Move self test status page printing to little endian orderinng (authored by imp). · Explain WhyWed, Apr 17, 3:34 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG98f841efd8ce: nvmecontrol: Move self test status page printing to little endian orderinng.

Revision Contents
Changeset List

Path

Size

sbin/

nvmecontrol/

41 lines

Diff 137219

sbin/nvmecontrol/logpage.c

Loading...