nvmecontrol: Refactor devlist implementation
ClosedPublic
Actions

Authored by jhb on Oct 31 2024, 2:52 PM.

Details

Reviewers

imp
chuck

Commits

rG326e20fc1252: nvmecontrol: Refactor devlist implementation

Summary

Split out helper functions for scan_namespace and scan_controller.
While here, replace sprintf() calls with snprintf() and avoid
leaking the contoller fd if read_controller_data() fails.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 31 2024, 2:52 PM

Herald added a subscriber: dab. · View Herald TranscriptOct 31 2024, 2:52 PM

jhb requested review of this revision.Oct 31 2024, 2:52 PM

Harbormaster completed remote builds in B60278: Diff 145735.Oct 31 2024, 2:52 PM

jhb added a child revision: D47355: nvmecontrol: Use active nslist to enumerate namespaces.Oct 31 2024, 2:52 PM

This makes things a lot better. But I can't help but think scanning sequential unit numbers couldn't be better maybe.

sbin/nvmecontrol/devlist.c
95	Is there a better #define that we can use? 64 is fine, but I can't say why

This revision is now accepted and ready to land.Oct 31 2024, 10:14 PM

jhb added inline comments.Nov 1 2024, 2:24 PM

sbin/nvmecontrol/devlist.c
95	That is in the old code and I just kept it. 64 is arbitrary, but as long as it's only in one place and everything else uses sizeof(name) I'm fine with that. If we had a constant for the largest possible filename in a component, maybe that could be used instead? (So not PATH_MAX, but NAME_MAX I guess?)