share/man/man4/squashfs.4
2–27
29
35–46	See vt, iwx, and some others. Would we need to load this in early boot instead of rc.conf? This has no kernel tunable options or sysctls?
51	Since this is a freebsd driver, freebsd is redundant here. Roff needs one sentence per line. Can it just mount and access them? Is creating possible?
55–60	+ .Pa lets people use `apropos Pa=sqfs` + putting the root prompt breaks copy paste and is implied for mount, you typically only want to use them for a complex multi line example where only some parts should be ran as root.
75	No blank lines in Roff

chuck marked 6 inline comments as done.Jun 14 2025, 5:28 PM

chuck added inline comments.

share/man/man4/squashfs.4
29	Du-oh!!
35–46	I could imagine both needing this driver at early boot as well as later in `rc.conf` And correct, no tunables or system controls at the moment.
51	Does this work better: The squashfs driver provides support for mounting and accessing SquashFS compressed file system images. SquashFS is a compressed read-only file system designed for general read-only file system use in constrained block device/memory systems. Use a program like mksquashfs or gensquashfs to create a suitable image. Should the man page annotate `mksquashfs` and `gensquashfs` in any particular manner?

ziaee added inline comments.Jun 14 2025, 9:32 PM

share/man/man4/squashfs.4
51	Yes, I really like that! I have no preference on order, but please use `.Sy utility` Or if possible `.Xr utility 8`.

Address doc feedback

Harbormaster completed remote builds in B64888: Diff 157064.Jun 15 2025, 1:34 PM

imp added inline comments.Jun 15 2025, 3:32 PM

share/man/man4/squashfs.4
40	Are either of the generators ports?

Oh, and I /think/ you need a man4/Makefile addition

share/man/man4/squashfs.4
33

chuck added inline comments.Jun 16 2025, 4:09 PM

share/man/man4/squashfs.4
40	Yes, both are in ports. It didn't sound like there was a standardized way to link to those, but perhaps I misunderstood.

Usually what doc does is

.Xr thing 1
.Pq Pa ports/category/thing

But ports doesn't like that because iiuc the category can change, but I think the utility of this notation is high enough that I'd rather just change it when it changes.

des added a subscriber: des.Apr 17 2026, 10:10 PM