nvme: Nvme controller generated events
ClosedPublic
Actions

Authored by imp on Jul 17 2025, 7:51 PM.

Details

Reviewers

jhb
mav
chs
chuck
ken
dab

Commits

rGe5c770dc7ff3: nvme: Nvme controller generated events

Summary

Interface for the nvme driver notifying its children of different
events: async notifications, namespace events and device failure. These
aren't yet connected.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 17 2025, 7:51 PM

Herald added a subscriber: dab. · View Herald TranscriptJul 17 2025, 7:51 PM

imp requested review of this revision.Jul 17 2025, 7:51 PM

imp added a parent revision: D51385: nvd: Attach as a child of nvme.

imp added a child revision: D51387: nvme_sim: Connect to events broadcast with nvme_if.

Harbormaster completed remote builds in B65532: Diff 158693.Jul 17 2025, 7:52 PM

jhb added inline comments.Jul 23 2025, 6:57 PM

sys/dev/nvme/nvmec_if.m
9 ↗	(On Diff #158693)	Just "nvme"?
18 ↗	(On Diff #158693)	I would perhaps name these as `ns_added`, `ns_removed`, `ns_changed` similar to BUS_CHILD_DELETED.
26 ↗	(On Diff #158693)	We can afford to spell out "remove" I think.
42 ↗	(On Diff #158693)	`controller_failed`?
49 ↗	(On Diff #158693)	`handle_aen`?

imp added inline comments.Jul 23 2025, 7:57 PM

sys/dev/nvme/nvmec_if.m
9 ↗	(On Diff #158693)	I chose nvmec to mirror the pcib vs pci separation. But I've never known quite how to differentiate the interfaces that children need to implement that this driver will call from the interfaces I implement for my children to call. Usually it's just one or the other, but I was anticipating needing to have upcalls as well as downcalls (though I couldn't tell you which is which in newbus speak).
18 ↗	(On Diff #158693)	That's not a bad idea. I hacked through these interfaces in a hurry.
42 ↗	(On Diff #158693)	Likely better. This name is the same as we had before with the 'consumer' thing.
49 ↗	(On Diff #158693)	Same.