Page MenuHomeFreeBSD
Differential D51385

nvd: Attach as a child of nvme
ClosedPublic
Actions

Authored by imp on Jul 17 2025, 7:51 PM.
Tags
None
Referenced Files
F141806961: D51385.id.diff
Sat, Jan 10, 4:46 PM
F141804664: D51385.id158692.diff
Sat, Jan 10, 4:06 PM
Unknown Object (File)
Sat, Jan 10, 4:28 AM
Unknown Object (File)
Fri, Jan 9, 2:50 PM
Unknown Object (File)
Wed, Jan 7, 1:13 PM
Unknown Object (File)
Wed, Jan 7, 11:43 AM
Unknown Object (File)
Wed, Jan 7, 4:24 AM
Unknown Object (File)
Wed, Jan 7, 3:27 AM
View All 45 Files
Subscribers
dab

Details

Reviewers
jhb
mav
chs
chuck
ken
Commits
rGb32470bc6621: nvd: Attach as a child of nvme
Summary

Rather than registering as a consumer of the nvme controller, hook into
the child device and use that.

This is a small regression at the moment: we don't fail the device when
that happens at runtime.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Jul 17 2025, 7:51 PM
Herald added a subscriber: dab. · View Herald TranscriptJul 17 2025, 7:51 PM
imp requested review of this revision.Jul 17 2025, 7:51 PM
imp added a parent revision: D51384: nvme_sim: Attach as a child of nvme.
imp added a child revision: D51386: nvme: Nvme controller generated events.
Harbormaster completed remote builds in B65531: Diff 158692.Jul 17 2025, 7:52 PM
jhb added inline comments.Jul 23 2025, 6:51 PM
sys/dev/nvd/nvd.c
560

Wrong description here?

imp added inline comments.Jul 23 2025, 7:33 PM
sys/dev/nvd/nvd.c
560

Yes. It's wrong. Stupid cut and paste.

imp updated this revision to Diff 166391.Nov 13 2025, 10:04 PM

update description. Stupid cut and paste

Harbormaster completed remote builds in B68622: Diff 166391.Nov 13 2025, 10:04 PM
imp updated this revision to Diff 166473.Nov 14 2025, 7:55 PM

Update per review, add missing change

Harbormaster completed remote builds in B68652: Diff 166473.Nov 14 2025, 7:55 PM
imp updated this revision to Diff 167618.Dec 5 2025, 11:28 PM

Update per review and rebase over resize changes... woof.

Harbormaster completed remote builds in B69088: Diff 167618.Dec 5 2025, 11:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2025, 10:54 PM
Closed by commit rGb32470bc6621: nvd: Attach as a child of nvme (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGb32470bc6621: nvd: Attach as a child of nvme.

Revision Contents
Changeset List

PathSize
sys/
dev/
nvd/
110 lines

Diff 167839

View Options

sys/dev/nvd/nvd.c

Loading...