nvd: Attach as a child of nvme
Needs ReviewPublic
Actions

Authored by imp on Jul 17 2025, 7:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 14, 7:09 AM

	Unknown Object (File)
	Fri, Nov 14, 6:15 AM

	Unknown Object (File)
	Sun, Nov 2, 11:39 PM

	Unknown Object (File)
	Sun, Nov 2, 2:48 AM

	Unknown Object (File)
	Sat, Nov 1, 4:25 AM

	Unknown Object (File)
	Thu, Oct 23, 7:13 AM

	Unknown Object (File)
	Thu, Oct 23, 7:13 AM

	Unknown Object (File)
	Thu, Oct 23, 7:13 AM

View All 29 Files

Subscribers

dab

Details

Reviewers

jhb
mav
chs
chuck
ken

Summary

Rather than registering as a consumer of the nvme controller, hook into
the child device and use that.

This is a small regression at the moment: we don't fail the device when
that happens at runtime.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 68652
Build 65535: arc lint + arc unit

Event Timeline

imp created this revision.Jul 17 2025, 7:51 PM

Herald added a subscriber: dab. · View Herald TranscriptJul 17 2025, 7:51 PM

imp requested review of this revision.Jul 17 2025, 7:51 PM

imp added a parent revision: D51384: nvme_sim: Attach as a child of nvme.

imp added a child revision: D51386: nvme: Nvme controller generated events.

Harbormaster completed remote builds in B65531: Diff 158692.Jul 17 2025, 7:52 PM

jhb added inline comments.Jul 23 2025, 6:51 PM

sys/dev/nvd/nvd.c
508	Wrong description here?

imp added inline comments.Jul 23 2025, 7:33 PM

sys/dev/nvd/nvd.c
508	Yes. It's wrong. Stupid cut and paste.

update description. Stupid cut and paste

Harbormaster completed remote builds in B68622: Diff 166391.Thu, Nov 13, 10:04 PM

Update per review, add missing change

Harbormaster completed remote builds in B68652: Diff 166473.Fri, Nov 14, 7:55 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvd/

nvd.c

100 lines

Diff 166473

View Options

nvd: Attach as a child of nvmeNeeds ReviewPublicActions