Page MenuHomeFreeBSD
Differential D51385

nvd: Attach as a child of nvme
ClosedPublic
Actions

Authored by imp on Jul 17 2025, 7:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 30, 8:56 AM
Unknown Object (File)
Fri, Nov 28, 5:20 AM
Unknown Object (File)
Thu, Nov 27, 9:23 PM
Unknown Object (File)
Fri, Nov 14, 7:09 AM
Unknown Object (File)
Fri, Nov 14, 6:15 AM
Unknown Object (File)
Nov 2 2025, 11:39 PM
Unknown Object (File)
Nov 2 2025, 2:48 AM
Unknown Object (File)
Nov 1 2025, 4:25 AM
View All 32 Files
Subscribers
dab

Details

Reviewers
jhb
mav
chs
chuck
ken
Commits
rGb32470bc6621: nvd: Attach as a child of nvme
Summary

Rather than registering as a consumer of the nvme controller, hook into
the child device and use that.

This is a small regression at the moment: we don't fail the device when
that happens at runtime.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65531
Build 62414: arc lint + arc unit

Event Timeline

imp created this revision.Jul 17 2025, 7:51 PM
Herald added a subscriber: dab. · View Herald TranscriptJul 17 2025, 7:51 PM
imp requested review of this revision.Jul 17 2025, 7:51 PM
imp added a parent revision: D51384: nvme_sim: Attach as a child of nvme.
imp added a child revision: D51386: nvme: Nvme controller generated events.
Harbormaster completed remote builds in B65531: Diff 158692.Jul 17 2025, 7:52 PM
jhb added inline comments.Jul 23 2025, 6:51 PM
sys/dev/nvd/nvd.c
508

Wrong description here?

imp added inline comments.Jul 23 2025, 7:33 PM
sys/dev/nvd/nvd.c
508

Yes. It's wrong. Stupid cut and paste.

imp updated this revision to Diff 166391.Thu, Nov 13, 10:04 PM

update description. Stupid cut and paste

Harbormaster completed remote builds in B68622: Diff 166391.Thu, Nov 13, 10:04 PM
imp updated this revision to Diff 166473.Fri, Nov 14, 7:55 PM

Update per review, add missing change

Harbormaster completed remote builds in B68652: Diff 166473.Fri, Nov 14, 7:55 PM
imp updated this revision to Diff 167618.Fri, Dec 5, 11:28 PM

Update per review and rebase over resize changes... woof.

Harbormaster completed remote builds in B69088: Diff 167618.Fri, Dec 5, 11:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Dec 10, 10:54 PM
Closed by commit rGb32470bc6621: nvd: Attach as a child of nvme (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGb32470bc6621: nvd: Attach as a child of nvme.

Revision Contents
Changeset List

PathSize
sys/
dev/
nvd/
100 lines

Diff 158692

View Options

sys/dev/nvd/nvd.c

Loading...