nvme: Improve error message for invalid format value
ClosedPublic
Actions

Authored by imp on Jul 17 2025, 7:52 PM.

Tags

None

Referenced Files

	F141767890: D51393.id167613.diff
	Sat, Jan 10, 3:28 AM

	F141749703: D51393.id166482.diff
	Fri, Jan 9, 9:02 PM

	F141745468: D51393.id167613.diff
	Fri, Jan 9, 7:40 PM

	Unknown Object (File)
	Sat, Dec 13, 2:46 AM

	Unknown Object (File)
	Dec 8 2025, 6:33 AM

	Unknown Object (File)
	Dec 4 2025, 5:44 AM

	Unknown Object (File)
	Dec 4 2025, 5:43 AM

	Unknown Object (File)
	Dec 2 2025, 1:36 AM

View All 45 Files

Subscribers

dab

Details

Reviewers

jhb
mav
chs
chuck
ken

Commits

rGf5b812331db5: nvme: Improve error message for invalid format value

Summary

Improve the wording of the invalid namespace value. Reword the comment
and move a line of code to the block it logically belongs to.

No functional changes intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 17 2025, 7:52 PM

Herald added a subscriber: dab. · View Herald TranscriptJul 17 2025, 7:52 PM

imp requested review of this revision.Jul 17 2025, 7:52 PM

imp added a parent revision: D51392: nvme: Remove consumer functionality.

imp added a child revision: D51394: nvme: Split the namespace init into resetting / !reestting case.

Harbormaster completed remote builds in B65539: Diff 158700.Jul 17 2025, 7:52 PM

Update per review, add missing change

Harbormaster completed remote builds in B68661: Diff 166482.Nov 14 2025, 7:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 5 2025, 11:18 PM

Closed by commit rGf5b812331db5: nvme: Improve error message for invalid format value (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGf5b812331db5: nvme: Improve error message for invalid format value.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme_ns.c

12 lines

Diff 167613

View Options

nvme: Improve error message for invalid format valueClosedPublicActions