Differential D51393

nvme: Improve error message for invalid format value
ClosedPublic
Actions

Authored by imp on Jul 17 2025, 7:52 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 6, 6:42 PM

	Unknown Object (File)
	Sun, Sep 6, 9:36 AM

	Unknown Object (File)
	Sun, Sep 6, 8:57 AM

	Unknown Object (File)
	Sun, Sep 6, 5:27 AM

	Unknown Object (File)
	Sat, Sep 5, 8:00 PM

	Unknown Object (File)
	Mon, Aug 24, 6:48 PM

	Unknown Object (File)
	Mon, Aug 24, 3:26 PM

	Unknown Object (File)
	Sat, Aug 15, 4:27 PM

Subscribers

Details

Reviewers

jhb
mav
chs
chuck
ken

Commits

rGf5b812331db5: nvme: Improve error message for invalid format value

Summary

Improve the wording of the invalid namespace value. Reword the comment
and move a line of code to the block it logically belongs to.

No functional changes intended.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 17 2025, 7:52 PM

Herald added a subscriber: dab. · View Herald TranscriptJul 17 2025, 7:52 PM

imp requested review of this revision.Jul 17 2025, 7:52 PM

imp added a parent revision: D51392: nvme: Remove consumer functionality.

imp added a child revision: D51394: nvme: Split the namespace init into resetting / !reestting case.

Harbormaster completed remote builds in B65539: Diff 158700.Jul 17 2025, 7:52 PM

Update per review, add missing change

Harbormaster completed remote builds in B68661: Diff 166482.Nov 14 2025, 7:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 5 2025, 11:18 PM

Closed by commit rGf5b812331db5: nvme: Improve error message for invalid format value (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGf5b812331db5: nvme: Improve error message for invalid format value.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

12 lines

Diff 167613

sys/dev/nvme/nvme_ns.c

Loading...