Page MenuHomeFreeBSD
Differential D54475

nvme: Be more correct in busdma usage
Needs ReviewPublic
Actions

Authored by imp on Jan 3 2026, 6:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 17, 12:54 AM
Unknown Object (File)
Tue, Apr 14, 12:27 PM
Unknown Object (File)
Sat, Apr 11, 8:42 PM
Unknown Object (File)
Sat, Apr 11, 8:40 PM
Unknown Object (File)
Tue, Apr 7, 3:33 PM
Unknown Object (File)
Tue, Apr 7, 3:07 PM
Unknown Object (File)
Sun, Apr 5, 6:41 AM
Unknown Object (File)
Wed, Apr 1, 5:14 AM
View All 38 Files
Subscribers
dab
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Only do a PRE/POST sync for READ or WRITE, but not both. Only do a PRE
sync for requests with payloads.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69594
Build 66477: arc lint + arc unit

Event Timeline

imp created this revision.Jan 3 2026, 6:13 PM
Herald added a subscriber: dab. · View Herald TranscriptJan 3 2026, 6:13 PM
imp requested review of this revision.Jan 3 2026, 6:13 PM
Harbormaster completed remote builds in B69590: Diff 168965.Jan 3 2026, 6:13 PM
mmel added a subscriber: mmel.Jan 3 2026, 6:30 PM
mmel removed a subscriber: mmel.Jan 3 2026, 7:28 PM
mmel added inline comments.
sys/dev/nvme/nvme_qpair.c
1071

This fragment looks wrong.

imp added inline comments.Jan 3 2026, 8:24 PM
sys/dev/nvme/nvme_qpair.c
1071

This fragment looks wrong.

What looks wrong?

imp updated this revision to Diff 168976.Jan 3 2026, 10:54 PM

fix the little oops that mmel found

Harbormaster completed remote builds in B69594: Diff 168976.Jan 3 2026, 10:54 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
nvme/
10 lines
4 lines
7 lines
2 lines
12 lines
3 lines

Diff 168976

View Options

sys/dev/nvme/nvme_ctrlr.c

Loading...
View Options

sys/dev/nvme/nvme_ctrlr_cmd.c

Loading...
View Options

sys/dev/nvme/nvme_ns_cmd.c

Loading...
View Options

sys/dev/nvme/nvme_private.h

Loading...
View Options

sys/dev/nvme/nvme_qpair.c

Loading...
View Options

sys/dev/nvme/nvme_sim.c

Loading...