Page MenuHomeFreeBSD

nvmf: Fix an off by one error when scanning active namespace IDs
ClosedPublic

Authored by jhb on Nov 1 2024, 3:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 26, 11:23 AM
Unknown Object (File)
Sat, Apr 12, 12:49 AM
Unknown Object (File)
Fri, Apr 11, 8:40 AM
Unknown Object (File)
Sat, Apr 5, 2:27 AM
Unknown Object (File)
Mon, Mar 31, 8:06 AM
Unknown Object (File)
Mon, Mar 31, 8:06 AM
Unknown Object (File)
Mar 28 2025, 1:47 PM
Unknown Object (File)
Feb 14 2025, 1:50 AM
Subscribers
None

Details

Summary

The active namespace list query fetches namespaces greater than the
passed in namespace ID, not greater than or equal to the passed in
namespace ID. Thus, a multi-page request should start with the last
namespace ID from the previous page, not that ID plus 1.

While here, make use of NVME_GLOBAL_NAMESPACE_TAG instead of a magic
number to handle the edge case that the last namespace ID in a page is
the largest valid namespace ID.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 1 2024, 3:26 PM
jhb created this revision.
This revision is now accepted and ready to land.Nov 2 2024, 4:55 AM
jhb retitled this revision from nvmf: Fix an off by one error in the upper bound on active namespace IDs to nvmf: Fix an off by one error when scanning active namespace IDs.Nov 2 2024, 12:33 PM
jhb edited the summary of this revision. (Show Details)
This revision now requires review to proceed.Nov 2 2024, 12:34 PM
This revision is now accepted and ready to land.Nov 4 2024, 6:21 PM