nvmf: Fix an off by one error when scanning active namespace IDs
ClosedPublic
Actions

Authored by jhb on Fri, Nov 1, 3:26 PM.

Details

Reviewers

imp
chuck

Commits

rG8922c5b8211e: nvmf: Fix an off by one error when scanning active namespace IDs

Summary

The active namespace list query fetches namespaces greater than the
passed in namespace ID, not greater than or equal to the passed in
namespace ID. Thus, a multi-page request should start with the last
namespace ID from the previous page, not that ID plus 1.

While here, make use of NVME_GLOBAL_NAMESPACE_TAG instead of a magic
number to handle the edge case that the last namespace ID in a page is
the largest valid namespace ID.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Fri, Nov 1, 3:26 PM

jhb created this revision.

Harbormaster completed remote builds in B60337: Diff 145861.Fri, Nov 1, 3:26 PM

imp accepted this revision.Sat, Nov 2, 4:55 AM

This revision is now accepted and ready to land.Sat, Nov 2, 4:55 AM

jhb retitled this revision from nvmf: Fix an off by one error in the upper bound on active namespace IDs to nvmf: Fix an off by one error when scanning active namespace IDs.Sat, Nov 2, 12:33 PM

jhb edited the summary of this revision. (Show Details)

Remove spurious nsid++

This revision now requires review to proceed.Sat, Nov 2, 12:34 PM

Harbormaster completed remote builds in B60342: Diff 145878.Sat, Nov 2, 12:34 PM

chuck accepted this revision.Mon, Nov 4, 6:21 PM

This revision is now accepted and ready to land.Mon, Nov 4, 6:21 PM

Closed by commit rG8922c5b8211e: nvmf: Fix an off by one error when scanning active namespace IDs (authored by jhb). · Explain WhyTue, Nov 5, 1:31 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8922c5b8211e: nvmf: Fix an off by one error when scanning active namespace IDs.