nvme: Fix namespace destruct
AbandonedPublic
Actions

Authored by chuck on Mon, Jun 10, 4:57 PM.

Details

Reviewers

imp
jhb

Summary

The driver calls nvme_ns_destruct for each possible namespace, not only
those which exist. The device alias code did not account for this and
will segfault.

Fix is to move destroying the alias device inside the cdev check.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58129
Build 55017: arc lint + arc unit

Event Timeline

chuck created this revision.Mon, Jun 10, 4:57 PM

Herald added a subscriber: dab. · View Herald TranscriptMon, Jun 10, 4:57 PM

chuck requested review of this revision.Mon, Jun 10, 4:57 PM

Harbormaster completed remote builds in B58129: Diff 139693.Mon, Jun 10, 4:57 PM

imp accepted this revision.Mon, Jun 10, 4:58 PM

This revision is now accepted and ready to land.Mon, Jun 10, 4:58 PM

@mav beat me to the fix.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme_ns.c

7 lines

Diff 139693

View Options

nvme: Fix namespace destructAbandonedPublicActions