nvmecontrol: Create letoh generically convert to host order
ClosedPublic
Actions

Authored by imp on Sat, Apr 6, 6:55 PM.

Details

Reviewers

jhb
chuck
mav

Commits

rG67163bc485a5: nvmecontrol: Create letoh to generically convert to host order

Summary

Using _Generic, create LE2H which will generically convert uintXX_t
types from little endian to host, regardless of the size.

USE jhb's suggested name

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Sat, Apr 6, 6:55 PM

Herald added a subscriber: dab. · View Herald TranscriptSat, Apr 6, 6:55 PM

imp requested review of this revision.Sat, Apr 6, 6:55 PM

Harbormaster completed remote builds in B56933: Diff 136612.Sat, Apr 6, 6:55 PM

amazeballs!

This revision is now accepted and ready to land.Mon, Apr 8, 1:56 PM

imp mentioned this in D44680: nvmecontrol: Make the error log page work on native format.Tue, Apr 9, 3:10 AM

I kind of wonder if we'd like to just have this in <sys/endian.h> as letoh, but then you'd want the full complement of betoh, htobe, etc.

sbin/nvmecontrol/nvmecontrol.h
64

In D44649#1019208, @jhb wrote:

I kind of wonder if we'd like to just have this in <sys/endian.h> as letoh, but then you'd want the full complement of betoh, htobe, etc.

I'll convert to letoh, but leave the others for now because the be ones aren't needed and htole is harder as a macro and I'm not quite ready for it.

imp retitled this revision from nvmecontrol: Create LE2H to generically convert to host order to nvmecontrol: Create letoh generically convert to host order.Tue, Apr 16, 10:46 PM

imp edited the summary of this revision. (Show Details)

Closed by commit rG67163bc485a5: nvmecontrol: Create letoh to generically convert to host order (authored by imp). · Explain WhyWed, Apr 17, 3:34 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG67163bc485a5: nvmecontrol: Create letoh to generically convert to host order.