Paths

Table of Contentst

Differential D48456

nvmecontrol: Only do name resolution once for Fabrics connections
ClosedPublic
Actions

Authored by jhb on Jan 14 2025, 5:33 PM.

Tags

None

Referenced Files

	F163594314: D48456.id.diff
	Fri, Jul 24, 7:45 PM

	F163563819: D48456.id149245.diff
	Fri, Jul 24, 1:08 PM

	F163548474: D48456.id149246.diff
	Fri, Jul 24, 8:55 AM

	Unknown Object (File)
	Tue, Jul 21, 7:26 PM

	Unknown Object (File)
	Mon, Jul 20, 11:36 AM

	Unknown Object (File)
	Thu, Jul 16, 7:11 AM

	Unknown Object (File)
	Sun, Jul 12, 12:27 AM

	Unknown Object (File)
	Jun 18 2026, 12:43 AM

Subscribers

Details

Reviewers

chuck
imp
dab

Commits

rGec282601f720: nvmecontrol: Only do name resolution once for Fabrics connections

Summary

Reuse the addrinfo structure from the admin queue to establish
connections to I/O queues for the TCP transport.

Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 14 2025, 5:33 PM

Herald added a subscriber: dab. · View Herald TranscriptJan 14 2025, 5:33 PM

jhb requested review of this revision.Jan 14 2025, 5:33 PM

Harbormaster completed remote builds in B61717: Diff 149245.Jan 14 2025, 5:33 PM

jhb added a parent revision: D48214: nvmf: Refactor reconnection support.Jan 14 2025, 5:34 PM

Rebase

Harbormaster completed remote builds in B61718: Diff 149246.Jan 14 2025, 5:39 PM

imp accepted this revision.Jan 14 2025, 10:08 PM

This revision is now accepted and ready to land.Jan 14 2025, 10:08 PM

dab requested changes to this revision.Jan 18 2025, 1:46 AM

dab added inline comments.

sbin/nvmecontrol/fabrics.c
500–501	Isn't a `freeaddrinfo(list);` needed here before the `return`? Perhaps a new error-out goto label to consolidate the error cases where just that is needed.

This revision now requires changes to proceed.Jan 18 2025, 1:46 AM

imp added inline comments.Jan 18 2025, 2:08 AM

sbin/nvmecontrol/fabrics.c
500–501	oh my! I missed this, but I think you're right.

jhb added inline comments.Jan 23 2025, 10:35 PM

sbin/nvmecontrol/fabrics.c
500–501	Isn't a `freeaddrinfo(list);` needed here before the `return`? Perhaps a new error-out goto label to consolidate the error cases where just that is needed. Hmmm, if I clear the io[] array earlier, then the existing `out` label can work for most of these.

Add missing free

Harbormaster completed remote builds in B61950: Diff 149839.Jan 23 2025, 11:29 PM

dab accepted this revision.Jan 24 2025, 1:12 AM

This revision is now accepted and ready to land.Jan 24 2025, 1:12 AM

jhb added a parent revision: D48654: nvmecontrol: Consolidate error paths in connect_nvm_queues().Jan 24 2025, 2:42 PM

Closed by commit rGec282601f720: nvmecontrol: Only do name resolution once for Fabrics connections (authored by jhb). · Explain WhyJan 30 2025, 3:52 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGec282601f720: nvmecontrol: Only do name resolution once for Fabrics connections.

Revision Contents
Changeset List

Path

Size

sbin/

nvmecontrol/

39 lines

Diff 150200

sbin/nvmecontrol/fabrics.c

Loading...