Page MenuHomeFreeBSD
Differential D42527

kern linker: Do not try to unload module if it has dependants
ClosedPublic
Actions

Authored by zlei on Nov 9 2023, 10:06 AM.
Tags
None
Referenced Files
F154694116: D42527.diff
Wed, Apr 29, 6:11 AM
Unknown Object (File)
Mon, Apr 27, 4:12 PM
Unknown Object (File)
Mon, Apr 27, 10:35 AM
Unknown Object (File)
Sat, Apr 25, 7:52 AM
Unknown Object (File)
Fri, Apr 24, 6:29 AM
Unknown Object (File)
Thu, Apr 23, 8:05 AM
Unknown Object (File)
Sun, Apr 19, 9:32 PM
Unknown Object (File)
Sat, Apr 18, 11:06 PM
View All Files
Subscribers
guest-patmaddox
imp
jhb
olce

Details

Reviewers
dfr
kib
dab
jhb
Commits
rGa2f57656620d: kern linker: Do not unload a module if it has dependants
rGf1994d1eb215: kern linker: Do not unload a module if it has dependants
rGf43ff3e15c8b: kern linker: Do not unload a module if it has dependants
Summary

linker_file_unload() will just drop a reference in case the module have more than one
references. For user requested unload, we are going to unload but not just to drop a
reference.

PR: 274986
MFC after: 2 weeks

Test Plan
# kldload bridgestp
# kldload if_bridge
# kldunload bridgestp
kldunload: can't unload file: Device busy

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Nov 9 2023, 10:06 AM
Herald added a subscriber: imp. · View Herald TranscriptNov 9 2023, 10:06 AM
zlei requested review of this revision.Nov 9 2023, 10:06 AM
dfr accepted this revision.Nov 9 2023, 3:46 PM
This revision is now accepted and ready to land.Nov 9 2023, 3:46 PM
dab accepted this revision.Nov 10 2023, 2:04 AM
jhb accepted this revision.Nov 15 2023, 4:08 PM
jhb added a subscriber: jhb.
jhb added inline comments.
sys/kern/kern_linker.c
1285–1286

I think this is more readable.

guest-patmaddox added a subscriber: guest-patmaddox.Dec 13 2023, 9:58 PM
Closed by commit rGf43ff3e15c8b: kern linker: Do not unload a module if it has dependants (authored by zlei). · Explain WhyMar 26 2024, 3:57 AM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rGf43ff3e15c8b: kern linker: Do not unload a module if it has dependants.
Herald added a subscriber: olce. · View Herald TranscriptMar 26 2024, 3:57 AM
zlei marked an inline comment as done.Apr 9 2024, 4:11 AM
zlei added a commit: rGf1994d1eb215: kern linker: Do not unload a module if it has dependants.
zlei added a commit: rGa2f57656620d: kern linker: Do not unload a module if it has dependants.Apr 9 2024, 4:14 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 136214

View Options

sys/kern/kern_linker.c

Loading...