Page MenuHomeFreeBSD

hyperv: Fix Coverity issues in the Hyper-V driver
ClosedPublic

Authored by dab on Feb 12 2023, 11:21 PM.
Tags
None
Referenced Files
F159963625: D38551.id117065.diff
Sat, Jun 20, 12:04 AM
Unknown Object (File)
Thu, Jun 18, 1:59 PM
Unknown Object (File)
Mon, Jun 8, 3:22 AM
Unknown Object (File)
Thu, Jun 4, 1:21 PM
Unknown Object (File)
Thu, May 28, 11:40 AM
Unknown Object (File)
Thu, May 28, 8:46 AM
Unknown Object (File)
Sun, May 24, 3:44 PM
Unknown Object (File)
Sun, May 24, 7:37 AM
Subscribers

Details

Summary

Coverity reports the use of two uninitialized variables in the hyperv
driver. Examination shows the variables can be accessed while
uninitialized in error cases. Fix both.

CID: 1365235
CID: 1365236
Obtained from: Robert Herndon <Robert.Herndon@Dell.com>
Sponsored by: Dell Technologies
MFC after: 1w

Test Plan

Changes in use at $WORK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dab requested review of this revision.Feb 12 2023, 11:21 PM

Common practice for attributing the submitter with git is:

git commit --amend --author='Robert Herndon <Robert.Herndon@Dell.com>'

This revision is now accepted and ready to land.Feb 14 2023, 2:55 PM

Common practice for attributing the submitter with git is:

git commit --amend --author='Robert Herndon <Robert.Herndon@Dell.com>'

Ah, good to know. I actually used git am to apply the patch and it annotated the commit that way. I "fixed" it to list me. I'll change it back and remember this for the future.

Does that then take the place of "Obtained from" and/or "Submitted by"?

Re-trying to approve this change. (Please ignore if redundant.)

Correct author in commit log.

This revision now requires review to proceed.Feb 14 2023, 4:51 PM
This revision is now accepted and ready to land.Feb 14 2023, 4:55 PM