Page MenuHomeFreeBSD

hyperv: Fix Coverity issues in the Hyper-V driver
ClosedPublic

Authored by dab on Feb 12 2023, 11:21 PM.
Tags
None
Referenced Files
F132496527: D38551.id117356.diff
Fri, Oct 17, 9:50 AM
Unknown Object (File)
Thu, Oct 16, 11:16 AM
Unknown Object (File)
Wed, Oct 15, 1:19 PM
Unknown Object (File)
Wed, Oct 15, 6:59 AM
Unknown Object (File)
Thu, Oct 2, 4:09 PM
Unknown Object (File)
Wed, Oct 1, 3:50 PM
Unknown Object (File)
Wed, Oct 1, 2:08 PM
Unknown Object (File)
Wed, Oct 1, 12:31 PM
Subscribers

Details

Summary

Coverity reports the use of two uninitialized variables in the hyperv
driver. Examination shows the variables can be accessed while
uninitialized in error cases. Fix both.

CID: 1365235
CID: 1365236
Obtained from: Robert Herndon <Robert.Herndon@Dell.com>
Sponsored by: Dell Technologies
MFC after: 1w

Test Plan

Changes in use at $WORK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dab requested review of this revision.Feb 12 2023, 11:21 PM

Common practice for attributing the submitter with git is:

git commit --amend --author='Robert Herndon <Robert.Herndon@Dell.com>'

This revision is now accepted and ready to land.Feb 14 2023, 2:55 PM

Common practice for attributing the submitter with git is:

git commit --amend --author='Robert Herndon <Robert.Herndon@Dell.com>'

Ah, good to know. I actually used git am to apply the patch and it annotated the commit that way. I "fixed" it to list me. I'll change it back and remember this for the future.

Does that then take the place of "Obtained from" and/or "Submitted by"?

Re-trying to approve this change. (Please ignore if redundant.)

Correct author in commit log.

This revision now requires review to proceed.Feb 14 2023, 4:51 PM
This revision is now accepted and ready to land.Feb 14 2023, 4:55 PM