Page MenuHomeFreeBSD
Differential D39348

mlxfw: fix potential NULL pointer dereference
ClosedPublic
Actions

Authored by vangyzen on Mar 30 2023, 10:28 PM.
Tags
None
Referenced Files
F160535494: D39348.diff
Thu, Jun 25, 10:46 AM
Unknown Object (File)
Wed, Jun 24, 2:48 AM
Unknown Object (File)
Sun, Jun 21, 1:08 AM
Unknown Object (File)
Sun, Jun 14, 2:28 AM
Unknown Object (File)
Fri, Jun 5, 12:19 AM
Unknown Object (File)
Fri, May 29, 6:05 PM
Unknown Object (File)
Thu, May 28, 9:04 PM
Unknown Object (File)
Wed, May 27, 6:00 PM
View All Files
Subscribers
badger
dab
imp

Details

Reviewers
slavash
• hselasky
kib
Commits
rGecaeac805b04: mlxfw: fix potential NULL pointer dereference
Summary

Reported by: Coverity
MFC after: 1 week
Sponsored by: Dell EMC Isilon

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vangyzen created this revision.Mar 30 2023, 10:28 PM
Herald added subscribers: dab, badger, imp. · View Herald TranscriptMar 30 2023, 10:28 PM
vangyzen requested review of this revision.Mar 30 2023, 10:28 PM
Harbormaster completed remote builds in B50685: Diff 119683.Mar 30 2023, 10:28 PM
vangyzen added a comment.Mar 30 2023, 10:30 PM

It's not clear to me whether this is actually possible or just theoretical.

patmaddox added a subscriber: patmaddox.Mar 31 2023, 5:55 AM
• hselasky added a reviewer: kib.Mar 31 2023, 9:41 AM

Adding Konstantin.

--HPS

kib accepted this revision.Mar 31 2023, 11:30 PM

I do not object. OTOH in-kernel parser definitely not prepared to malformed mfa packages anyway.

This revision is now accepted and ready to land.Mar 31 2023, 11:30 PM
Closed by commit rGecaeac805b04: mlxfw: fix potential NULL pointer dereference (authored by vangyzen). · Explain WhyApr 4 2023, 7:29 PM
This revision was automatically updated to reflect the committed changes.
vangyzen added a commit: rGecaeac805b04: mlxfw: fix potential NULL pointer dereference.
patmaddox removed a subscriber: patmaddox.Jul 29 2023, 5:38 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
mlxfw/
2 lines

Diff 119851

View Options

sys/dev/mlxfw/mlxfw_mfa2_tlv_multi.c

Loading...