Page MenuHomeFreeBSD

Commit message template: PR field now accepts bugs.freebsd.org URL.
AcceptedPublic

Authored by lwhsu on Dec 23 2022, 6:18 PM.
Tags
None
Referenced Files
F166284999: D37863.diff
Wed, Aug 12, 4:51 PM
Unknown Object (File)
Sat, Aug 8, 7:15 PM
Unknown Object (File)
Sat, Aug 8, 9:34 AM
Unknown Object (File)
Wed, Aug 5, 11:06 PM
Unknown Object (File)
Sun, Aug 2, 1:50 AM
Unknown Object (File)
Sat, Aug 1, 6:24 AM
Unknown Object (File)
Wed, Jul 29, 8:35 AM
Unknown Object (File)
Sat, Jul 25, 8:16 PM

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48874
Build 45763: arc lint + arc unit

Event Timeline

lwhsu requested review of this revision.Dec 23 2022, 6:18 PM
zlei added a subscriber: zlei.

Looks good to me.

This revision is now accepted and ready to land.Dec 25 2022, 10:14 AM
grahamperrin added inline comments.
tools/tools/git/hooks/prepare-commit-msg
45

Is it clear enough that there should be no more than one URL per line?

A committer might type something like this (not exceeding 72 characters):

PR: https://bugs.freebsd.org/###### https://bugs.freebsd.org/######

tools/tools/git/hooks/prepare-commit-msg
45

… sorry, I could not find the related report at the time of my previous comment.

I visualise any string of two or more white space-separated URLs, on a single line, resulting in a single, invalid link in cgit.

From FreeBSD bug 266473 – cgit.freebsd.org breaks some links – seems to not recognise some types of URI delimiter (RFC 3986):

{F53896353}