vm_page_unswappable: remove wrong assertion
ClosedPublic
Actions

Authored by vangyzen on Nov 9 2022, 8:19 PM.

Details

Reviewers

markj
rang_acm.org

Commits

rGcfbf1da0deed: vm_page_unswappable: remove wrong assertion

Summary

markj says:

...the assertion is incorrect and should simply be removed.
It has been racy since we removed the use of the page hash
lock to synchronize wiring of pages.

PR: 267621

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vangyzen created this revision.Nov 9 2022, 8:19 PM

Herald added subscribers: dab, badger, imp. · View Herald TranscriptNov 9 2022, 8:19 PM

vangyzen requested review of this revision.Nov 9 2022, 8:19 PM

Harbormaster completed remote builds in B48248: Diff 112817.Nov 9 2022, 8:19 PM

vangyzen added a reviewer: rang_acm.org.Nov 9 2022, 8:19 PM

markj accepted this revision.Nov 9 2022, 8:21 PM

markj added inline comments.

sys/vm/vm_page.c
4203–4204	ASSERT_LOCKED is sufficient. The intent is that nothing should be concurrently freeing the page; a read lock on the object suffices for that.

This revision is now accepted and ready to land.Nov 9 2022, 8:21 PM

rang_acm.org accepted this revision.Nov 9 2022, 8:24 PM

Closed by commit rGcfbf1da0deed: vm_page_unswappable: remove wrong assertion (authored by rang_acm.org, committed by vangyzen). · Explain WhyNov 9 2022, 8:31 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rGcfbf1da0deed: vm_page_unswappable: remove wrong assertion.