rc.conf(5) documents the gifconfig_<interface> keyword, which is
no longer implemented. Document the replacement, which works with
cloned_interfaces as well.
Details
- Reviewers
hrs dab - Group Reviewers
manpages - Commits
- rS326928: MFC r326734:
rS326734: gifconfig_gif0 no longer works, document replacement
tested with FreeBSD 11.1
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
share/man/man5/rc.conf.5 | ||
---|---|---|
1821 ↗ | (On Diff #35369) | Not yours, I know, but "is assumed to exist" is terrible. Assumed by who? This kind of says "the code makes assumptions that will probably break and we are just letting you know." Is there any reason this can't be changed to just variable exists for each value of |
share/man/man5/rc.conf.5 | ||
---|---|---|
1821 ↗ | (On Diff #35369) | Good point. How about "variable should exist for each value"? |
share/man/man5/rc.conf.5 | ||
---|---|---|
1821 ↗ | (On Diff #35369) | Or maybe " variable should be defined for each value of"? The variable needs to be defined in /etc/rc.conf. |
share/man/man5/rc.conf.5 | ||
---|---|---|
1821 ↗ | (On Diff #35369) | Hm, I did not take the wording to mean that the user is supposed to define those variables, but that the system did it. An example of the importance of wording, I guess. Anyway, let's just say that in an imperative way (roughly paraphrasing): For each tunnel interface, set a variable named .Va ifconfig_ Ns Aq Ar interface to the values desired to configure the link layer of the tunnel with the A complete example would be good here. The one given does not show an actual example of actual naming of the variable. |
1827 ↗ | (On Diff #35369) | End this sentence here: .Xr ifconfig 8 . |
1828 ↗ | (On Diff #35369) | And use this for the full example: For example: .Bd -literal -offset indent ifconfig_gif0="blah blah" .Ed With real values for the variable name and contents of the quotes. Actually, looking at that, it makes me more confused, and I'm not sure if the name of the variable on line 1820 is correct. All the more reason for a literal example. |
share/man/man5/rc.conf.5 | ||
---|---|---|
1828 ↗ | (On Diff #35369) | Sorry, I hadn't noticed this comment before uploading a new version. I can touch up the macro usage, but will wait for comments on the content. |
share/man/man5/rc.conf.5 | ||
---|---|---|
1828 ↗ | (On Diff #35369) | I tried the suggested macros, and they put a blank line before the display but not after, which looks odd. Suggestions for fixing this welcome; i don't think this is a whole line of space in the typeset version. |
share/man/man5/rc.conf.5 | ||
---|---|---|
1828 ↗ | (On Diff #35369) | Warren (or anyone), suggestions on how to do this display with reasonable spacing (same before and after)? Any comments on the text? |
share/man/man5/rc.conf.5 | ||
---|---|---|
1828 ↗ | (On Diff #35369) | I've seen some other places that put a '.Pp' after the '.Ed' (on its own line), which seems to add the desired spacing. |
Update date.
I forgot to update the date in the last update. I'll optimistically
set it to Nov 30 so I might not have to update if the review is approved.