Page MenuHomeFreeBSD

bjk (Benjamin Kaduk)
User

Projects

User Details

User Since
Jul 17 2014, 9:55 PM (218 w, 1 d)

Recent Activity

Mon, Sep 10

bjk added a comment to D17113: Add new rc keywords: enable, disable, delete.

The man page should get a bunch more markup; off the top of my head,
.Xr for man page references,
.Pa for filesystem paths,
Li for literal variables and values...

Mon, Sep 10, 8:15 PM

Sun, Sep 2

bjk added a comment to D16988: Link update proposal for en_US.ISO8859-1/articles/contributing.

These look like fine content changes, but double-check the indentation in line 1182 (i.e., tabs vs. spaces).

Sun, Sep 2, 1:38 AM
bjk added a reviewer for D16988: Link update proposal for en_US.ISO8859-1/articles/contributing: linimon.
Sun, Sep 2, 1:36 AM

Aug 16 2018

bjk added a comment to D15350: Tidy up ports.7 manual.
In D15350#350715, @0mp wrote:
In D15350#348437, @bjk wrote:

Can you remind me why the .Dq Li is supposed to be better for inline commands?

As fair as I know we tend to use Dq Li instead of Nm make Cm build-like for inline commands. This is the style we follow in make.conf.5, src.conf.5, mqueufs.5. The Nm-based formatting is used in rc.conf.5 and find.1 on the other hand.

AFAICT, Dq Li is a more popular way to format commands.

The argument which is in favor of Dq Li is that we tend to make commands in Examples sections literal. We very rarely add Nm-like formatting to examples. Hence for the sake of consistency I'm proposing this change from Nm ... to Dq Li. 😄

What do you think about it, @bjk?

Aug 16 2018, 2:55 PM · Ports Committers, Doc Committers, manpages

Aug 15 2018

bjk added inline comments to D16696: Add efidev(4)/efirt(9).
Aug 15 2018, 2:56 AM

Aug 13 2018

bjk added a comment to D16702: Add pthread_get_name_np(3)..

Just a couple of grammar nits on the manpage.

Aug 13 2018, 3:08 PM

Aug 4 2018

bjk added a comment to D16576: System trust configuration and local root keygen.

Trying to limit myself to reviewing as manpages and not getting into the design itself...

Aug 4 2018, 1:31 AM

Aug 1 2018

bjk accepted D16520: Add a missing "Ar" macro to the description of the -R flag in the daemon(8) manpage.

Feel free to use Approved-by: bjk (doc committer)

Aug 1 2018, 11:45 AM

Jul 24 2018

bjk added a comment to D15350: Tidy up ports.7 manual.

Can you remind me why the .Dq Li is supposed to be better for inline commands?

Jul 24 2018, 12:46 AM · Ports Committers, Doc Committers, manpages

Jul 20 2018

bjk added a comment to D16281: Make it possible to run ntpd as a non-root user, add ntpd uid and gid..

Sorry to have missed this when it first came in; the mdoc could use some changes.

Jul 20 2018, 12:21 AM

Jul 9 2018

bjk added inline comments to D16149: Tweak ports(7).
Jul 9 2018, 3:12 AM

Jun 20 2018

bjk added a comment to D15927: Update ixl(4) man page.

Some drive-by nits inline.

Jun 20 2018, 4:31 PM

Jun 11 2018

bjk committed rD51820: Fix build..
Fix build.
Jun 11 2018, 1:15 PM

Jun 2 2018

bjk accepted D15652: pty.3: Add a HISTORY section.

Just one nit, otherwise this looks good.

Jun 2 2018, 10:31 PM

May 11 2018

bjk accepted D15392: Remove Perforce from the documentation tree..

Looks good other than the potential build issue (which I did not test).

May 11 2018, 5:20 PM

May 6 2018

bjk committed rS333306: Fix spelling of --output long option in fetch.1.
Fix spelling of --output long option in fetch.1
May 6 2018, 3:59 PM

May 3 2018

bjk added inline comments to D15204: recv.2: Fix a typo and remove an unneeded Tn macro.
May 3 2018, 3:47 PM · manpages

Apr 2 2018

bjk committed rS331892: Fix formatting in snd_hda.4.
Fix formatting in snd_hda.4
Apr 2 2018, 10:59 PM
bjk closed D14922: Fix formatting in snd_hda.4.
Apr 2 2018, 10:59 PM · Doc Committers
bjk accepted D14922: Fix formatting in snd_hda.4.
Apr 2 2018, 3:38 AM · Doc Committers

Mar 31 2018

bjk added a comment to D14911: Heimdal: Patch to permit gss-with-mic to function if ~/.k5login is unreadable.

As discussed in https://github.com/heimdal/heimdal/issues/368, the k5login file can be used to restrict access, so
I do not think that ignoring EACCESS and EPERM is a change to be taken lightly.

Mar 31 2018, 8:18 PM

Mar 9 2018

bjk committed rD51474: Update kgdb instructions.
Update kgdb instructions
Mar 9 2018, 2:07 AM

Feb 19 2018

bjk committed rD51432: Add 2017Q4 core@ entry from matthew.
Add 2017Q4 core@ entry from matthew
Feb 19 2018, 6:15 PM
bjk committed rD51431: Add 2017Q4 PowerNV entry from Wojciech Macek.
Add 2017Q4 PowerNV entry from Wojciech Macek
Feb 19 2018, 5:01 PM
bjk committed rD51430: Add 2017Q4 portmgr entry from rene.
Add 2017Q4 portmgr entry from rene
Feb 19 2018, 5:32 AM

Feb 18 2018

bjk committed rD51429: Add 2017Q4 RDAM stack entry from Meny Yossefi.
Add 2017Q4 RDAM stack entry from Meny Yossefi
Feb 18 2018, 12:58 AM
bjk committed rD51427: Add 2017Q4 LibreNMS ZFS reporting entry from Zane Bowers-Hadley.
Add 2017Q4 LibreNMS ZFS reporting entry from Zane Bowers-Hadley
Feb 18 2018, 12:31 AM

Feb 17 2018

bjk added a comment to D13335: clean man lint warnings in sbin/.

Who's going to commit those?

Feb 17 2018, 5:24 AM

Feb 13 2018

bjk committed rD51420: Fix markup for Synergy SKY press entry.
Fix markup for Synergy SKY press entry
Feb 13 2018, 4:11 AM

Feb 7 2018

bjk added inline comments to D14224: More details in ld.lld manpage.
Feb 7 2018, 10:47 PM
bjk added a comment to D14224: More details in ld.lld manpage.

Sorry for the terse comments; this is something of a drive-by :(

Feb 7 2018, 12:27 AM

Feb 4 2018

bjk added inline comments to D13867: dtc(1) manpage review.
Feb 4 2018, 2:29 PM

Jan 31 2018

bjk added inline comments to D14140: tail(1): Add some long options.
Jan 31 2018, 12:36 PM

Jan 17 2018

bjk requested changes to D13682: Add memset_s(3) doc to memset(3) man page..
Jan 17 2018, 5:05 AM

Jan 13 2018

bjk committed rD51383: Remove sample contents from the status report README.
Remove sample contents from the status report README
Jan 13 2018, 3:57 AM
bjk committed rD51382: Copy report-template.xml for the 2017Q4 report.
Copy report-template.xml for the 2017Q4 report
Jan 13 2018, 3:51 AM
bjk committed rD51381: Belatedly publish the 2017Q3 status report.
Belatedly publish the 2017Q3 status report
Jan 13 2018, 3:41 AM

Jan 10 2018

bjk added a comment to D13813: introduce basic lld man page.

Probably a lot of these need not be addressed before commit (especially "what are the valid values?").

Jan 10 2018, 4:03 AM

Jan 9 2018

bjk committed rD51377: Remove duplicate author entity for araujo@.
Remove duplicate author entity for araujo@
Jan 9 2018, 2:29 AM

Jan 2 2018

bjk accepted D13713: make SW_WATCHDOG dynamic.

Thanks, looks good for manpages. (I don't know if you're going to wait for further list discussion before committing.)

Jan 2 2018, 5:35 AM
bjk added a comment to D13713: make SW_WATCHDOG dynamic.

Thank you for putting in the list of ioctls; it is nice to see!

Jan 2 2018, 5:04 AM

Jan 1 2018

bjk accepted D13720: aw_sid: Add man page for this driver.

Thanks for fixing the notes from brueffer; this looks good now.

Jan 1 2018, 8:51 PM
bjk added a comment to D13713: make SW_WATCHDOG dynamic.

IIRC, there are ten of these ioctls, although I didn't add any. I thought I'd correct the obvious out-of-date statement, but wasn't sure I could correctly document all of those added over time. Suggestions?

Jan 1 2018, 5:03 AM
bjk added inline comments to D13713: make SW_WATCHDOG dynamic.
Jan 1 2018, 12:49 AM

Dec 31 2017

bjk added inline comments to D13682: Add memset_s(3) doc to memset(3) man page..
Dec 31 2017, 9:16 PM

Dec 27 2017

bjk added a comment to D13650: Fix a few more spelling errors.

The spelling fixes are good, but there is low-hanging fruit on a line being changed.

Dec 27 2017, 9:23 PM

Dec 26 2017

bjk added a comment to D13628: aw_rsb: Add man page for this driver.

Just one nit, inline; otherwise this looks good.

Dec 26 2017, 11:32 PM
bjk added inline comments to D13628: aw_rsb: Add man page for this driver.
Dec 26 2017, 3:10 AM

Dec 25 2017

bjk committed rD51337: Extend the submission deadline for 2017Q4 entries.
Extend the submission deadline for 2017Q4 entries
Dec 25 2017, 11:36 PM
bjk committed rD51336: Add introduction to the 2017Q3 report.
Add introduction to the 2017Q3 report
Dec 25 2017, 11:35 PM
bjk committed rD51335: Second editing pass through the 2017Q3 report.
Second editing pass through the 2017Q3 report
Dec 25 2017, 11:31 PM
bjk added inline comments to D13628: aw_rsb: Add man page for this driver.
Dec 25 2017, 10:44 PM

Dec 24 2017

bjk committed rD51334: Fix broken links in the 2017Q3 report.
Fix broken links in the 2017Q3 report
Dec 24 2017, 6:29 AM

Dec 18 2017

bjk committed rD51319: Remove empty category from 2017Q3 report.
Remove empty category from 2017Q3 report
Dec 18 2017, 2:48 AM

Dec 17 2017

bjk committed rD51318: Make an editing pass through the 2017Q3 report.
Make an editing pass through the 2017Q3 report
Dec 17 2017, 7:18 PM

Dec 12 2017

bjk committed rP456187: Follow-up to r455921 -- fix typo.
Follow-up to r455921 -- fix typo
Dec 12 2017, 11:17 PM
bjk committed rP456102: MFH: r455921.
MFH: r455921
Dec 12 2017, 4:22 AM

Dec 11 2017

bjk committed rP455921: Update to upstream security release 1.6.22.
Update to upstream security release 1.6.22
Dec 11 2017, 3:37 AM

Dec 10 2017

bjk committed rD51273: Add 2017Q3 man page entry from wblock.
Add 2017Q3 man page entry from wblock
Dec 10 2017, 4:02 AM
bjk committed rD51272: Add 2017Q3 nosh entry from Jonathan de Boyne Pollard.
Add 2017Q3 nosh entry from Jonathan de Boyne Pollard
Dec 10 2017, 3:55 AM

Dec 7 2017

bjk added a comment to D13334: clean man lint warnings in bin/.
In D13334#280007, @imp wrote:

Just a question: Was the non-bumping of .Dd intentional or an oversight?

Dec 7 2017, 2:03 AM
bjk committed rS326651: Fix mandoc -Tlint warnings in bin/.
Fix mandoc -Tlint warnings in bin/
Dec 7 2017, 1:57 AM
bjk closed D13334: clean man lint warnings in bin/.
Dec 7 2017, 1:57 AM
bjk committed rS326650: Note that old sys/event.h required manual sys/types.h inclusion.
Note that old sys/event.h required manual sys/types.h inclusion
Dec 7 2017, 1:50 AM

Dec 5 2017

bjk added a comment to D13349: add IEEE Std 1003.1, 2016 edition.

@jilles do you want to do the honors?

Dec 5 2017, 8:10 PM
bjk added inline comments to D13334: clean man lint warnings in bin/.
Dec 5 2017, 8:10 PM
bjk accepted D13349: add IEEE Std 1003.1, 2016 edition.
Dec 5 2017, 8:07 PM
bjk added a comment to D13334: clean man lint warnings in bin/.

Hmm, am I supposed to commit this, now?

Dec 5 2017, 2:04 AM

Dec 2 2017

bjk accepted D13334: clean man lint warnings in bin/.
Dec 2 2017, 7:17 PM
bjk added inline comments to D13334: clean man lint warnings in bin/.
Dec 2 2017, 6:23 PM

Nov 30 2017

bjk committed rD51239: Tweak status report sample to reflect current practices.
Tweak status report sample to reflect current practices
Nov 30 2017, 4:47 AM
bjk committed rD51238: Add 2017Q3 pNFS entry from rmacklem.
Add 2017Q3 pNFS entry from rmacklem
Nov 30 2017, 4:42 AM

Nov 27 2017

bjk committed rD51229: Add 2017Q3 Foundation entry from deb.
Add 2017Q3 Foundation entry from deb
Nov 27 2017, 5:45 AM
bjk committed rD51228: Add 2017Q3 core@ entry from matthew.
Add 2017Q3 core@ entry from matthew
Nov 27 2017, 3:14 AM
bjk committed rD51226: Update 2017Q3 gdb entry for newer version available.
Update 2017Q3 gdb entry for newer version available
Nov 27 2017, 1:42 AM
bjk committed rD51225: Add 2017Q3 CI entry from lwhsu.
Add 2017Q3 CI entry from lwhsu
Nov 27 2017, 1:42 AM
bjk committed rD51224: Add 2017Q3 portmgr entry from rene.
Add 2017Q3 portmgr entry from rene
Nov 27 2017, 1:26 AM
bjk committed rD51223: Add 2017Q3 OpenJFX entry from tobik.
Add 2017Q3 OpenJFX entry from tobik
Nov 27 2017, 1:20 AM

Nov 25 2017

bjk added inline comments to D13130: gifconfig_gif0 no longer works, document replacement.
Nov 25 2017, 6:14 PM

Nov 22 2017

bjk committed rD51211: Add 2017Q3 FreeBSDDesktop entry from jmd.
Add 2017Q3 FreeBSDDesktop entry from jmd
Nov 22 2017, 2:23 AM

Nov 21 2017

bjk committed rD51210: Add 2017Q3 Intel 10G iflib conversion entry from Jeb Cramer.
Add 2017Q3 Intel 10G iflib conversion entry from Jeb Cramer
Nov 21 2017, 3:58 AM
bjk committed rD51208: Add 2017Q3 iWARP entry from Jeb Cramer.
Add 2017Q3 iWARP entry from Jeb Cramer
Nov 21 2017, 2:26 AM

Nov 13 2017

bjk committed rD51198: Replace template variables for the 2017Q3 status report.
Replace template variables for the 2017Q3 status report
Nov 13 2017, 3:09 AM
bjk committed rD51197: Add 2017Q3 puppet entry from romain.
Add 2017Q3 puppet entry from romain
Nov 13 2017, 3:04 AM
bjk committed rD51196: Add 2017Q3 entry for Absolute FreeBSD 3rd Edition, from mwlucas.
Add 2017Q3 entry for Absolute FreeBSD 3rd Edition, from mwlucas
Nov 13 2017, 2:41 AM

Nov 7 2017

bjk added inline comments to D12836: ctl: Make max_luns and max_ports tunable variables instead of hardcoded defines..
Nov 7 2017, 11:05 PM

Nov 3 2017

bjk added inline comments to D10680: IPSec performance increase in single flow mode by making crypto(9) multi thread.
Nov 3 2017, 3:07 PM

Oct 26 2017

bjk committed rD51146: Add 2017Q3 gdb entry from jhb.
Add 2017Q3 gdb entry from jhb
Oct 26 2017, 12:36 AM

Oct 25 2017

bjk added inline comments to D12785: New gets_s(3) stdio function.
Oct 25 2017, 10:40 PM

Oct 19 2017

bjk committed rD51135: Add 2017Q3 AMD Zen architecture support entry from cem.
Add 2017Q3 AMD Zen architecture support entry from cem
Oct 19 2017, 2:48 AM
bjk committed rD51134: Add 2017Q3 re entry, from gjb.
Add 2017Q3 re entry, from gjb
Oct 19 2017, 2:08 AM
bjk committed rD51133: Copy report template for 2017Q3 status report.
Copy report template for 2017Q3 status report
Oct 19 2017, 1:46 AM
bjk committed rD51132: Fix typo from r51131.
Fix typo from r51131
Oct 19 2017, 1:38 AM
bjk committed rD51131: Add per-category descriptive paragraphs to the status report template.
Add per-category descriptive paragraphs to the status report template
Oct 19 2017, 1:10 AM
bjk closed D12642: Add per-category intro text to the quarterly status report template.
Oct 19 2017, 1:10 AM

Oct 18 2017

bjk committed rS324732: Adopt jail.8 to our brave new bsdinstall world.
Adopt jail.8 to our brave new bsdinstall world
Oct 18 2017, 10:57 PM

Oct 16 2017

bjk accepted D12679: Document missing libgeom functions.

Thanks for the update!

Oct 16 2017, 2:35 PM
bjk added inline comments to D12679: Document missing libgeom functions.
Oct 16 2017, 12:36 AM

Oct 11 2017

bjk created D12642: Add per-category intro text to the quarterly status report template.
Oct 11 2017, 10:48 PM

Oct 10 2017

bjk committed rS324458: Add Asus USB-N13, rev. B1 to the rtwn_usb hardware list.
Add Asus USB-N13, rev. B1 to the rtwn_usb hardware list
Oct 10 2017, 12:26 AM