- User Since
- Jul 17 2014, 9:55 PM (345 w, 6 d)
Fri, Feb 26
The patch to ssl_engine_io.c is correct from an openssl perspective.
I'm not a ports committer, so technically I shouldn't approve the (trivial) Makefile update.
Jan 25 2021
Perhaps this is another reminder that our heimdal is quite old and we might want to revitalize the effort to move it to a private library and update it.
Jan 1 2021
Dec 30 2020
I find it interesting that we have such a long history of a LOCKS section in VOP man pages, given that mdoc(7) includes a list of conventional manual sections, with note that "[t]hese sections should be used unless it's bsolutely necessary that custom sections be used."
Dec 21 2020
Nov 22 2020
Nov 12 2020
The mdoc is fine, so okay from manpages, but see inline comment.
Oct 26 2020
Oct 25 2020
You want to add -width jail to the .Bl that's giving a mandoc/lint error at present:
Oct 13 2020
(I read this and have no comment or objection. Will try to finish thinking about the openssl code soon.)
Sep 1 2020
Aug 27 2020
Aug 4 2020
I agree with Benedict -- the man page looks very good on first read!
Jul 30 2020
Jun 30 2020
I don't have particular insight into what various distros are doing for SSLv3_method/etc. specifically (my main exposure is into Debian), but I think we can learn quite a bit from the analogous handling of SSLv2_method() and its removal. Specifically, upstream OpenSSL had removed the methods outright around the 1.0.2g/1.0.2h timeframe but had to add them back as stubs that return NULL, to improve ABI compatibility. (This was, IIRC, before the timeframe when separate no-foo and no-foo-method configure options were available, so there wasn't much of a middlle ground available.) This predates the use of github and open pre-commit review, so we just have the commit messages for https://github.com/openssl/openssl/commit/13313856 and https://github.com/openssl/openssl/commit/fcedd2d69d to go from for understanding the motivations of the upstream changes.
Jun 6 2020
Okay, please go ahead.
I expect I should be the one committing this?
But I will hold off for a bit in case someone wants to respond to the 'kldstat' remark.
Jun 5 2020
Jun 4 2020
May 31 2020
Looks good, thanks for the final updates!
May 30 2020
Thanks for the updates; they look good.
Just one more thing (stray .Ed) that I missed last time, sorry.
mandoc -Tlint can help find this sort of thing in the future.
May 29 2020
Please remember to bump .Dd for the final version
May 21 2020
I agree with Conrad (but it should be a separate review); TLS 1.0 and 1.1's days are numbered, and I should really get around to progressing https://tools.ietf.org/html/draft-ietf-tls-oldversions-deprecate-06
May 13 2020
May 8 2020
Apr 20 2020
Apr 15 2020
There's some more discussion ongoing at https://mailarchive.ietf.org/arch/msg/ipsec/IyE2dP17oKPFXeBgSs6hjfjXiIE/ which may end up indicating that gone_in(13) is more reasonable for us.
Feb 29 2020
Feb 16 2020
Feb 11 2020
There are probably still some changes to make here, but not really anything that affects functionality, I think.
Sorry to have spotted some things this time that I apparently missed the first time around :(
Jan 30 2020
Sorry this is later than expected.
-1 just for indentation, "Xr syslog 3", and nodefgroup description; the rest is optional.
Jan 17 2020
Jul 31 2019
Jul 25 2019
Jun 17 2019
Apr 19 2019
Mar 20 2019
Jan 19 2019
Jan 10 2019
Oct 27 2018
Oct 25 2018
Oct 6 2018
Oct 3 2018
Oct 2 2018
Sep 22 2018
I think there are several places where the error path needs to zero the length field in an output structure as well as freeing the pointer within.
Usually there is a helper function to do this in a concise fashion, though the prevailing style of any given file is not always to use it.
Also some stylistic comments that do not necessarily require action.
Sep 10 2018
The man page should get a bunch more markup; off the top of my head,
.Xr for man page references,
.Pa for filesystem paths,
Li for literal variables and values...
Sep 2 2018
These look like fine content changes, but double-check the indentation in line 1182 (i.e., tabs vs. spaces).
Aug 16 2018
Aug 15 2018
Aug 13 2018
Just a couple of grammar nits on the manpage.
Aug 4 2018
Trying to limit myself to reviewing as manpages and not getting into the design itself...
Aug 1 2018
Feel free to use Approved-by: bjk (doc committer)
Jul 24 2018
Can you remind me why the .Dq Li is supposed to be better for inline commands?
Jul 20 2018
Sorry to have missed this when it first came in; the mdoc could use some changes.
Jul 9 2018
Jun 20 2018
Some drive-by nits inline.
Jun 11 2018
Jun 2 2018
Just one nit, otherwise this looks good.
May 11 2018
Looks good other than the potential build issue (which I did not test).
May 6 2018
May 3 2018
Apr 2 2018
Mar 31 2018
As discussed in https://github.com/heimdal/heimdal/issues/368, the k5login file can be used to restrict access, so
I do not think that ignoring EACCESS and EPERM is a change to be taken lightly.
Mar 9 2018
Feb 19 2018
Feb 18 2018
Feb 17 2018
Who's going to commit those?
Feb 13 2018
Feb 7 2018
Sorry for the terse comments; this is something of a drive-by :(
Feb 4 2018
Jan 31 2018
Jan 17 2018
Jan 13 2018
Jan 10 2018
Probably a lot of these need not be addressed before commit (especially "what are the valid values?").
Jan 9 2018
Jan 2 2018
Thanks, looks good for manpages. (I don't know if you're going to wait for further list discussion before committing.)
Thank you for putting in the list of ioctls; it is nice to see!
Jan 1 2018
Thanks for fixing the notes from brueffer; this looks good now.