Page MenuHomeFreeBSD

bjk (Benjamin Kaduk)
User

Projects

User Details

User Since
Jul 17 2014, 9:55 PM (316 w, 5 d)

Recent Activity

Tue, Aug 4

bjk accepted D25939: gpiokeys: add a basic manual page.
Tue, Aug 4, 7:01 AM
bjk added a comment to D25939: gpiokeys: add a basic manual page.

I agree with Benedict -- the man page looks very good on first read!

Tue, Aug 4, 6:44 AM

Thu, Jul 30

bjk added a comment to D25847: Do not mention portsnap(8) in ports.7.

As we are moving away from portsnap, ...

We are? What will be the preferred mechanism for updating /usr/ports?

Thu, Jul 30, 12:52 AM

Jun 30 2020

bjk added a comment to D25493: Replace OPENSSL_NO_SSL3_METHODs with dummies.

I don't have particular insight into what various distros are doing for SSLv3_method/etc. specifically (my main exposure is into Debian), but I think we can learn quite a bit from the analogous handling of SSLv2_method() and its removal. Specifically, upstream OpenSSL had removed the methods outright around the 1.0.2g/1.0.2h timeframe but had to add them back as stubs that return NULL, to improve ABI compatibility. (This was, IIRC, before the timeframe when separate no-foo and no-foo-method configure options were available, so there wasn't much of a middlle ground available.) This predates the use of github and open pre-commit review, so we just have the commit messages for https://github.com/openssl/openssl/commit/13313856 and https://github.com/openssl/openssl/commit/fcedd2d69d to go from for understanding the motivations of the upstream changes.

Jun 30 2020, 12:40 AM

Jun 6 2020

bjk added a comment to D25166: stats.7: fix nonexistent references, various lint issues.

Okay, please go ahead.

Jun 6 2020, 5:31 PM
bjk accepted D25166: stats.7: fix nonexistent references, various lint issues.

I expect I should be the one committing this?
But I will hold off for a bit in case someone wants to respond to the 'kldstat' remark.

Jun 6 2020, 5:29 PM

Jun 5 2020

bjk committed rS361839: Belatedly bump .Dd for r361783.
Belatedly bump .Dd for r361783
Jun 5 2020, 4:59 PM

Jun 4 2020

bjk committed rS361783: Add EXAMPLES to killall(1).
Add EXAMPLES to killall(1)
Jun 4 2020, 4:30 AM
bjk closed D25002: killall(1): add EXAMPLES to manpage.
Jun 4 2020, 4:30 AM

May 31 2020

bjk accepted D25002: killall(1): add EXAMPLES to manpage.

Looks good, thanks for the final updates!

May 31 2020, 10:41 PM

May 30 2020

bjk added a comment to D25002: killall(1): add EXAMPLES to manpage.

Thanks for the updates; they look good.
Just one more thing (stray .Ed) that I missed last time, sorry.
mandoc -Tlint can help find this sort of thing in the future.

May 30 2020, 4:46 PM

May 29 2020

bjk added a comment to D25002: killall(1): add EXAMPLES to manpage.

Please remember to bump .Dd for the final version

May 29 2020, 2:41 AM

May 21 2020

bjk accepted D24947: Remove support for SSLv3 from fetch(3).

I agree with Conrad (but it should be a separate review); TLS 1.0 and 1.1's days are numbered, and I should really get around to progressing https://tools.ietf.org/html/draft-ietf-tls-oldversions-deprecate-06

May 21 2020, 9:54 PM

May 13 2020

bjk committed rD54142: Additional updates to the Kerberos section.
Additional updates to the Kerberos section
May 13 2020, 8:15 PM

May 8 2020

bjk committed rD54110: Update the expiration on my PGP key.
Update the expiration on my PGP key
May 8 2020, 4:11 AM

Apr 20 2020

bjk added a comment to D24341: Deprecate 3des support in IPsec for FreeBSD 13..
In D24341#537980, @jhb wrote:
In D24341#537467, @bjk wrote:

There's some more discussion ongoing at https://mailarchive.ietf.org/arch/msg/ipsec/IyE2dP17oKPFXeBgSs6hjfjXiIE/ which may end up indicating that gone_in(13) is more reasonable for us.

My take on reading the responses in that thread is that removing in 13 probably is fine. If it really is 1990's boxes doing 3des, then those probably aren't relevant peers for FreeBSD 13.0. Also, unlike the assumption of the one response that is more mixed, FreeBSD users are fairly capable at using older releases if necessary. Thanks for prodding them to get more detail.

Apr 20 2020, 6:00 AM

Apr 15 2020

bjk added a comment to D24341: Deprecate 3des support in IPsec for FreeBSD 13..

There's some more discussion ongoing at https://mailarchive.ietf.org/arch/msg/ipsec/IyE2dP17oKPFXeBgSs6hjfjXiIE/ which may end up indicating that gone_in(13) is more reasonable for us.

Apr 15 2020, 1:55 PM
bjk added a comment to D24341: Deprecate 3des support in IPsec for FreeBSD 13..
In D24341#537336, @cem wrote:
In D24341#537325, @jhb wrote:

I did ping Ben off list about 3DES and he seemed to think 14 was more prudent than 13 for IPsec:

While I personally am happy to see the end of triple-DES in general (I
wrote RFC 8429, after all), it seems that in the IKE world it is not quite
as much of a no-brainer as one might think:
https://datatracker.ietf.org/meeting/104/materials/minutes-104-ipsecme-00
suggests that we cannot get rid of it quickly, due to use in telephony.
...

The link is devoid of any actual basis for that assertion. It's literally just "cannot get rid of 3des. used in telephony."

Apr 15 2020, 1:30 AM

Feb 29 2020

bjk added inline comments to D23851: handbook: clarify that cmd examples use sh syntax.
Feb 29 2020, 6:21 PM

Feb 16 2020

bjk accepted D23198: Bring our pam_login_access to support the same features as Linux's pam_access.
Feb 16 2020, 2:18 AM

Feb 11 2020

bjk accepted D23198: Bring our pam_login_access to support the same features as Linux's pam_access.

There are probably still some changes to make here, but not really anything that affects functionality, I think.
Sorry to have spotted some things this time that I apparently missed the first time around :(

Feb 11 2020, 3:29 AM

Jan 30 2020

bjk requested changes to D23198: Bring our pam_login_access to support the same features as Linux's pam_access.

Sorry this is later than expected.
-1 just for indentation, "Xr syslog 3", and nodefgroup description; the rest is optional.

Jan 30 2020, 3:52 AM

Jan 17 2020

bjk added inline comments to D23110: Introduce CTLFLAG_NEEDGIANT.
Jan 17 2020, 2:53 AM

Jul 31 2019

bjk added inline comments to D21087: Provide the list of knobs related to mitigations..
Jul 31 2019, 8:51 PM

Jul 25 2019

bjk committed rS350325: Fix grammar nit in copy_file_range docs.
Fix grammar nit in copy_file_range docs
Jul 25 2019, 3:43 PM

Jun 17 2019

bjk accepted D20671: Add missing words and word smith in pci(4).
Jun 17 2019, 4:38 PM

Apr 19 2019

bjk added inline comments to D19924: cron(8): schedule interval jobs that get loaded during execution.
Apr 19 2019, 6:13 PM

Mar 20 2019

bjk added inline comments to D19651: Add a fusefs(5) man page.
Mar 20 2019, 4:08 AM

Jan 19 2019

bjk committed rD52774: Attempt to cope with dd's non-portable bs= constructs.
Attempt to cope with dd's non-portable bs= constructs
Jan 19 2019, 7:23 PM

Jan 10 2019

bjk accepted D18804: MFC: r342597.
Jan 10 2019, 1:27 AM

Oct 27 2018

bjk added inline comments to D17365: Update Handbook printing smart filter example to use file(1).
Oct 27 2018, 9:27 PM

Oct 25 2018

bjk added inline comments to D17678: dumpon(8): Provide seatbelt against weak RSA keys.
Oct 25 2018, 6:00 PM

Oct 6 2018

bjk accepted D17428: vidcontrol.1: Fix typo in `-f` description.
Oct 6 2018, 1:34 PM

Oct 3 2018

bjk accepted D17276: Update heimdal to build against OpenSSL 1.1..
Oct 3 2018, 5:44 PM

Oct 2 2018

bjk accepted D17276: Update heimdal to build against OpenSSL 1.1..
Oct 2 2018, 9:25 PM
bjk added inline comments to D17276: Update heimdal to build against OpenSSL 1.1..
Oct 2 2018, 3:45 PM
bjk added inline comments to D17276: Update heimdal to build against OpenSSL 1.1..
Oct 2 2018, 2:43 AM

Sep 22 2018

bjk added inline comments to D17276: Update heimdal to build against OpenSSL 1.1..
Sep 22 2018, 5:38 PM
bjk requested changes to D17276: Update heimdal to build against OpenSSL 1.1..

I think there are several places where the error path needs to zero the length field in an output structure as well as freeing the pointer within.
Usually there is a helper function to do this in a concise fashion, though the prevailing style of any given file is not always to use it.
Also some stylistic comments that do not necessarily require action.

Sep 22 2018, 3:44 AM

Sep 10 2018

bjk added a comment to D17113: Add new rc keywords: enable, disable, delete.

The man page should get a bunch more markup; off the top of my head,
.Xr for man page references,
.Pa for filesystem paths,
Li for literal variables and values...

Sep 10 2018, 8:15 PM

Sep 2 2018

bjk added a comment to D16988: Link update proposal for en_US.ISO8859-1/articles/contributing.

These look like fine content changes, but double-check the indentation in line 1182 (i.e., tabs vs. spaces).

Sep 2 2018, 1:38 AM
bjk added a reviewer for D16988: Link update proposal for en_US.ISO8859-1/articles/contributing: linimon.
Sep 2 2018, 1:36 AM

Aug 16 2018

bjk added a comment to D15350: Tidy up ports.7 manual.
In D15350#350715, @0mp wrote:
In D15350#348437, @bjk wrote:

Can you remind me why the .Dq Li is supposed to be better for inline commands?

As fair as I know we tend to use Dq Li instead of Nm make Cm build-like for inline commands. This is the style we follow in make.conf.5, src.conf.5, mqueufs.5. The Nm-based formatting is used in rc.conf.5 and find.1 on the other hand.

AFAICT, Dq Li is a more popular way to format commands.

The argument which is in favor of Dq Li is that we tend to make commands in Examples sections literal. We very rarely add Nm-like formatting to examples. Hence for the sake of consistency I'm proposing this change from Nm ... to Dq Li. 😄

What do you think about it, @bjk?

Aug 16 2018, 2:55 PM · Ports Committers, Doc Committers, manpages

Aug 15 2018

bjk added inline comments to D16696: Add efidev(4)/efirt(9).
Aug 15 2018, 2:56 AM

Aug 13 2018

bjk added a comment to D16702: Add pthread_get_name_np(3)..

Just a couple of grammar nits on the manpage.

Aug 13 2018, 3:08 PM

Aug 4 2018

bjk added a comment to D16576: System trust configuration and local root keygen.

Trying to limit myself to reviewing as manpages and not getting into the design itself...

Aug 4 2018, 1:31 AM

Aug 1 2018

bjk accepted D16520: Add a missing "Ar" macro to the description of the -R flag in the daemon(8) manpage.

Feel free to use Approved-by: bjk (doc committer)

Aug 1 2018, 11:45 AM

Jul 24 2018

bjk added a comment to D15350: Tidy up ports.7 manual.

Can you remind me why the .Dq Li is supposed to be better for inline commands?

Jul 24 2018, 12:46 AM · Ports Committers, Doc Committers, manpages

Jul 20 2018

bjk added a comment to D16281: Make it possible to run ntpd as a non-root user, add ntpd uid and gid..

Sorry to have missed this when it first came in; the mdoc could use some changes.

Jul 20 2018, 12:21 AM

Jul 9 2018

bjk added inline comments to D16149: Tweak ports(7).
Jul 9 2018, 3:12 AM

Jun 20 2018

bjk added a comment to D15927: Update ixl(4) and ixlv(4) man pages.

Some drive-by nits inline.

Jun 20 2018, 4:31 PM

Jun 11 2018

bjk committed rD51820: Fix build..
Fix build.
Jun 11 2018, 1:15 PM

Jun 2 2018

bjk accepted D15652: pty.3: Add a HISTORY section.

Just one nit, otherwise this looks good.

Jun 2 2018, 10:31 PM

May 11 2018

bjk accepted D15392: Remove Perforce from the documentation tree..

Looks good other than the potential build issue (which I did not test).

May 11 2018, 5:20 PM

May 6 2018

bjk committed rS333306: Fix spelling of --output long option in fetch.1.
Fix spelling of --output long option in fetch.1
May 6 2018, 3:59 PM

May 3 2018

bjk added inline comments to D15204: recv.2: Fix a typo and remove an unneeded Tn macro.
May 3 2018, 3:47 PM · manpages

Apr 2 2018

bjk committed rS331892: Fix formatting in snd_hda.4.
Fix formatting in snd_hda.4
Apr 2 2018, 10:59 PM
bjk closed D14922: Fix formatting in snd_hda.4.
Apr 2 2018, 10:59 PM · Doc Committers
bjk accepted D14922: Fix formatting in snd_hda.4.
Apr 2 2018, 3:38 AM · Doc Committers

Mar 31 2018

bjk added a comment to D14911: Heimdal: Patch to permit gss-with-mic to function if ~/.k5login is unreadable.

As discussed in https://github.com/heimdal/heimdal/issues/368, the k5login file can be used to restrict access, so
I do not think that ignoring EACCESS and EPERM is a change to be taken lightly.

Mar 31 2018, 8:18 PM

Mar 9 2018

bjk committed rD51474: Update kgdb instructions.
Update kgdb instructions
Mar 9 2018, 2:07 AM

Feb 19 2018

bjk committed rD51432: Add 2017Q4 core@ entry from matthew.
Add 2017Q4 core@ entry from matthew
Feb 19 2018, 6:15 PM
bjk committed rD51431: Add 2017Q4 PowerNV entry from Wojciech Macek.
Add 2017Q4 PowerNV entry from Wojciech Macek
Feb 19 2018, 5:01 PM
bjk committed rD51430: Add 2017Q4 portmgr entry from rene.
Add 2017Q4 portmgr entry from rene
Feb 19 2018, 5:32 AM

Feb 18 2018

bjk committed rD51429: Add 2017Q4 RDAM stack entry from Meny Yossefi.
Add 2017Q4 RDAM stack entry from Meny Yossefi
Feb 18 2018, 12:58 AM
bjk committed rD51427: Add 2017Q4 LibreNMS ZFS reporting entry from Zane Bowers-Hadley.
Add 2017Q4 LibreNMS ZFS reporting entry from Zane Bowers-Hadley
Feb 18 2018, 12:31 AM

Feb 17 2018

bjk added a comment to D13335: clean man lint warnings in sbin/.

Who's going to commit those?

Feb 17 2018, 5:24 AM

Feb 13 2018

bjk committed rD51420: Fix markup for Synergy SKY press entry.
Fix markup for Synergy SKY press entry
Feb 13 2018, 4:11 AM

Feb 7 2018

bjk added inline comments to D14224: More details in ld.lld manpage.
Feb 7 2018, 10:47 PM
bjk added a comment to D14224: More details in ld.lld manpage.

Sorry for the terse comments; this is something of a drive-by :(

Feb 7 2018, 12:27 AM

Feb 4 2018

bjk added inline comments to D13867: dtc(1) manpage review.
Feb 4 2018, 2:29 PM

Jan 31 2018

bjk added inline comments to D14140: tail(1): Add some long options.
Jan 31 2018, 12:36 PM

Jan 17 2018

bjk requested changes to D13682: Add memset_s(3) doc to memset(3) man page..
Jan 17 2018, 5:05 AM

Jan 13 2018

bjk committed rD51383: Remove sample contents from the status report README.
Remove sample contents from the status report README
Jan 13 2018, 3:57 AM
bjk committed rD51382: Copy report-template.xml for the 2017Q4 report.
Copy report-template.xml for the 2017Q4 report
Jan 13 2018, 3:51 AM
bjk committed rD51381: Belatedly publish the 2017Q3 status report.
Belatedly publish the 2017Q3 status report
Jan 13 2018, 3:41 AM

Jan 10 2018

bjk added a comment to D13813: introduce basic lld man page.

Probably a lot of these need not be addressed before commit (especially "what are the valid values?").

Jan 10 2018, 4:03 AM

Jan 9 2018

bjk committed rD51377: Remove duplicate author entity for araujo@.
Remove duplicate author entity for araujo@
Jan 9 2018, 2:29 AM

Jan 2 2018

bjk accepted D13713: make SW_WATCHDOG dynamic.

Thanks, looks good for manpages. (I don't know if you're going to wait for further list discussion before committing.)

Jan 2 2018, 5:35 AM
bjk added a comment to D13713: make SW_WATCHDOG dynamic.

Thank you for putting in the list of ioctls; it is nice to see!

Jan 2 2018, 5:04 AM

Jan 1 2018

bjk accepted D13720: aw_sid: Add man page for this driver.

Thanks for fixing the notes from brueffer; this looks good now.

Jan 1 2018, 8:51 PM
bjk added a comment to D13713: make SW_WATCHDOG dynamic.

IIRC, there are ten of these ioctls, although I didn't add any. I thought I'd correct the obvious out-of-date statement, but wasn't sure I could correctly document all of those added over time. Suggestions?

Jan 1 2018, 5:03 AM
bjk added inline comments to D13713: make SW_WATCHDOG dynamic.
Jan 1 2018, 12:49 AM

Dec 31 2017

bjk added inline comments to D13682: Add memset_s(3) doc to memset(3) man page..
Dec 31 2017, 9:16 PM

Dec 27 2017

bjk added a comment to D13650: Fix a few more spelling errors.

The spelling fixes are good, but there is low-hanging fruit on a line being changed.

Dec 27 2017, 9:23 PM

Dec 26 2017

bjk added a comment to D13628: aw_rsb: Add man page for this driver.

Just one nit, inline; otherwise this looks good.

Dec 26 2017, 11:32 PM
bjk added inline comments to D13628: aw_rsb: Add man page for this driver.
Dec 26 2017, 3:10 AM

Dec 25 2017

bjk committed rD51337: Extend the submission deadline for 2017Q4 entries.
Extend the submission deadline for 2017Q4 entries
Dec 25 2017, 11:36 PM
bjk committed rD51336: Add introduction to the 2017Q3 report.
Add introduction to the 2017Q3 report
Dec 25 2017, 11:35 PM
bjk committed rD51335: Second editing pass through the 2017Q3 report.
Second editing pass through the 2017Q3 report
Dec 25 2017, 11:31 PM
bjk added inline comments to D13628: aw_rsb: Add man page for this driver.
Dec 25 2017, 10:44 PM

Dec 24 2017

bjk committed rD51334: Fix broken links in the 2017Q3 report.
Fix broken links in the 2017Q3 report
Dec 24 2017, 6:29 AM

Dec 18 2017

bjk committed rD51319: Remove empty category from 2017Q3 report.
Remove empty category from 2017Q3 report
Dec 18 2017, 2:48 AM

Dec 17 2017

bjk committed rD51318: Make an editing pass through the 2017Q3 report.
Make an editing pass through the 2017Q3 report
Dec 17 2017, 7:18 PM

Dec 12 2017

bjk committed rP456187: Follow-up to r455921 -- fix typo.
Follow-up to r455921 -- fix typo
Dec 12 2017, 11:17 PM
bjk committed rP456102: MFH: r455921.
MFH: r455921
Dec 12 2017, 4:22 AM

Dec 11 2017

bjk committed rP455921: Update to upstream security release 1.6.22.
Update to upstream security release 1.6.22
Dec 11 2017, 3:37 AM

Dec 10 2017

bjk committed rD51273: Add 2017Q3 man page entry from wblock.
Add 2017Q3 man page entry from wblock
Dec 10 2017, 4:02 AM
bjk committed rD51272: Add 2017Q3 nosh entry from Jonathan de Boyne Pollard.
Add 2017Q3 nosh entry from Jonathan de Boyne Pollard
Dec 10 2017, 3:55 AM

Dec 7 2017

bjk added a comment to D13334: clean man lint warnings in bin/.
In D13334#280007, @imp wrote:

Just a question: Was the non-bumping of .Dd intentional or an oversight?

Dec 7 2017, 2:03 AM