Page MenuHomeFreeBSD

More details in ld.lld manpage
Needs ReviewPublic

Authored by arshankhanifar_gmail.com on Feb 6 2018, 2:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 11 2024, 11:16 PM
Unknown Object (File)
Dec 7 2024, 2:22 AM
Unknown Object (File)
Nov 26 2024, 8:11 PM
Unknown Object (File)
Sep 29 2024, 10:26 PM
Unknown Object (File)
Sep 29 2024, 10:25 PM
Unknown Object (File)
Sep 29 2024, 10:25 PM
Unknown Object (File)
Sep 29 2024, 10:25 PM
Unknown Object (File)
Sep 24 2024, 3:10 AM
Subscribers

Details

Reviewers
emaste
bcr
Summary

Added a brief example as to how to use it. Added more clarity for some arguments.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Two comments.

usr.bin/clang/lld/ld.lld.1
79–86

Line break after a sentence stop.

370

Do we really need to show the contents of the C program? For the following bits in the example, it only talks about the linker, but no one needs to see the source program for that, AFAICT.

Sorry for the terse comments; this is something of a drive-by :(

usr.bin/clang/lld/ld.lld.1
382

s/-v/
.Fl v
/ (including newlines)

Also, we should probably .Xr clang 1

390

.Pq .Pa /usr/bin/ld

413

Should probably use the .Fl macro a bit more, and .Xr clang/lld

Also, check line lengths for 80 columns

arshankhanifar_gmail.com added inline comments.
usr.bin/clang/lld/ld.lld.1
382

I added .Fl and .Xr but I'm not sure if I correctly understood the s/-v/ and / (including newlines)

arshankhanifar_gmail.com marked an inline comment as done.

Performed the changes proposed, had a slight problem understanding this comment. I did what I thought was right, if not just let me know :)

arshankhanifar_gmail.com marked an inline comment as done.
usr.bin/clang/lld/ld.lld.1
382

It looks like you did correctly understand the comment, thanks

Though, the comma should go on the same line as the macro it appears after:

.Xr clang 1 ,

Yes, this is weird and nonsensical, and there's not a great way to learn about it, though https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/manpages-markup.html is useful.

BTW, have you run textproc/igor and mandoc -Tlint on your changes? Could provide some valuable help and suggestions for fixes.