A man page.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
The man page looks good. Can you check it with "mandoc -Tlint" and textproc/igor and see if they give you any warnings?
Thanks for writing that man page.
Comment Actions
I agree with Benedict -- the man page looks very good on first read!
| share/man/man4/gpiokeys.4 | ||
|---|---|---|
| 70 ↗ | (On Diff #75338) | I expect mandoc -Tlint to complain about an argument to .Nm here. |
Comment Actions
Thank you for the reviews!
igor was happy, but mandoc complained about the order of cross-references.
| share/man/man4/gpiokeys.4 | ||
|---|---|---|
| 70 ↗ | (On Diff #75338) | Actually, it didn't. |
Comment Actions
LGTM!
(I was wondering if it would be better to put properties description into a list, but the manual page looks fine as it is now.)
| share/man/man4/gpiokeys.4 | ||
|---|---|---|
| 60 ↗ | (On Diff #75342) | This sounds weird to me, I think that s/FDT/DTS/ would sound better. |
| 98 ↗ | (On Diff #75342) | Mhm, I didn't knew we still had this. |
| share/man/man4/gpiokeys.4 | ||
|---|---|---|
| 60 ↗ | (On Diff #75342) | Okay. |
| 98 ↗ | (On Diff #75342) | I took this from from gpioled(4). |
| share/man/man4/gpiokeys.4 | ||
|---|---|---|
| 98 ↗ | (On Diff #75342) | Yeah we can improve later, this is way better that what we currently have :) |
| share/man/man4/gpiokeys.4 | ||
|---|---|---|
| 98 ↗ | (On Diff #75342) | BTW, that document seems to have a fairly accurate, if a bit vague, description of the gpios property\ |
Comment Actions
I misunderstood the code: "name" property is used to get the node name
if "label" property is not set.