Page MenuHomeFreeBSD
Differential D10993

Start updating the Subversion primer.
Needs ReviewPublic
Actions

Authored by mat on May 30 2017, 4:42 PM.
Tags
None
Referenced Files
F151011912: D10993.id44064.diff
Sun, Apr 5, 11:08 AM
F150996586: D10993.id44072.diff
Sun, Apr 5, 9:09 AM
Unknown Object (File)
Sat, Apr 4, 11:26 PM
Unknown Object (File)
Sat, Apr 4, 5:09 PM
Unknown Object (File)
Sat, Apr 4, 6:09 AM
Unknown Object (File)
Sat, Apr 4, 3:47 AM
Unknown Object (File)
Fri, Apr 3, 7:24 PM
Unknown Object (File)
Fri, Apr 3, 5:17 AM
View All Files
Subscribers
bcr
eadler
wblock
ygy

Details

Reviewers
editor_callfortesting.org
eadler
Group Reviewers
Doc Committers
Summary

This kinda started by me trying to update the new committer's section...

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 17441
Build 17273: arc lint + arc unit

Event Timeline

mat created this revision.May 30 2017, 4:42 PM
Harbormaster completed remote builds in B9578: Diff 29025.May 30 2017, 4:42 PM
bcr added a reviewer: editor_callfortesting.org.May 30 2017, 4:47 PM
bcr added a subscriber: bcr.

Adding Michael Dexter for his work on D9981.

mat updated this revision to Diff 29074.May 31 2017, 1:28 PM
  • Update bits of the Subversion primer.
  • Move the properties things in a properties section.
Harbormaster completed remote builds in B9602: Diff 29074.May 31 2017, 1:29 PM
eadler accepted this revision.Jun 18 2018, 2:30 AM
eadler added a subscriber: eadler.

LGTM.

wblock added a subscriber: wblock.Jun 18 2018, 12:15 PM
wblock added inline comments.
en_US.ISO8859-1/articles/committers-guide/article.xml
868–870

About the "edit it": that is not needed and kind of confuses the issue. A file does not have to be modified to be added to version control.

mat updated this revision to Diff 44064.Jun 19 2018, 11:10 AM
  • Address wblocks's comment.
Harbormaster completed remote builds in B17438: Diff 44064.Jun 19 2018, 11:10 AM
mat updated this revision to Diff 44072.Jun 19 2018, 1:39 PM
  • Do not use svn abbreviated commands.
  • Always use svn delete
  • More fixes/changs.
Harbormaster completed remote builds in B17441: Diff 44072.Jun 19 2018, 1:39 PM
bcr added a comment.Jun 19 2018, 2:24 PM

Just a formatting thing that I found, the rest looks fine.

en_US.ISO8859-1/articles/committers-guide/article.xml
1444

The indentation of the <important> tags is correct, here, but the <para> tags must now be at a deeper indentation level.

mat added inline comments.Jun 20 2018, 8:47 AM
en_US.ISO8859-1/articles/committers-guide/article.xml
1444

Well, obviously, but if I reindent everything properly, I then get told that I should not mix content change and whitespace changes :-)
So all whitespace changes are left for a later commit.

ygy added a subscriber: ygy.Dec 10 2020, 7:09 AM
ygy added a comment.Jun 12 2021, 5:35 AM

Is this still relevant?

Revision Contents
Changeset List

PathSize
en_US.ISO8859-1/
articles/
committers-guide/
316 lines

Diff 44072

View Options

en_US.ISO8859-1/articles/committers-guide/article.xml

Loading...