Page MenuHomeFreeBSD

Add option to limit output image to a certain size
Needs ReviewPublic

Authored by sobomax on Apr 24 2017, 4:56 PM.

Details

Reviewers
None
Group Reviewers
manpages
Summary

This change adds ability to limit output compressed image to a certain size in blocks. We find it useful to make compressed snapshots and leave UFS snapshot metadata out. This could have some other applications as well. Posting it here mostly to get manpages checked.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 8878
Build 9261: CI src buildJenkins

Event Timeline

sobomax created this revision.Apr 24 2017, 4:56 PM
wblock added a subscriber: wblock.May 19 2017, 3:48 PM

Please also bump .Dd.

usr.bin/mkuzip/mkuzip.8
137

"blocks" is a little ambiguous. Is it a disk block or a filesystem block? Is it a fixed size, or based on the destination? Really, the question is how the user can tell how big a block is.

sobomax added inline comments.May 22 2017, 4:28 AM
usr.bin/mkuzip/mkuzip.8
137

This is the value he or she supplies into the -r cluster_size option (i.e. cluster_size). There is a check in the code below to make sure it's actually provided explicitly, as default size of the cluster might vary depending on the compression algorithm selected. Maybe I should replace "block" with "cluster"?

wblock added inline comments.Jul 14 2017, 3:32 PM
usr.bin/mkuzip/mkuzip.8
137

There might be a better way, something like "this value multiplied by the value of cluster_size". But just s/blocks/clusters/ is arguably as clear.