Page MenuHomeFreeBSD

firmware: document new native file loading.
ClosedPublic

Authored by imp on Jan 26 2024, 4:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 10:00 AM
Unknown Object (File)
Sat, Apr 27, 12:48 AM
Unknown Object (File)
Fri, Apr 26, 7:35 PM
Unknown Object (File)
Fri, Apr 26, 3:39 AM
Unknown Object (File)
Fri, Apr 26, 3:09 AM
Unknown Object (File)
Sun, Apr 14, 5:36 PM
Unknown Object (File)
Mon, Apr 8, 10:31 PM
Unknown Object (File)
Mon, Apr 8, 6:21 AM
Subscribers

Details

Summary

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jan 26 2024, 4:58 AM
imp created this revision.

A few suggestions for improvements.

share/man/man9/firmware.9
327

There seems to be a word missing here, something like "is loaded" or "exists" maybe?

335

s/foll/full/

339

Maybe a : is better here instead of a sentence stop?

342

s/the/with/ ?

347

s/matches subpath/matches the subpath/

(Sorry if some comments are confusing; I lost track of the state of the latest implementation)

share/man/man9/firmware.9
95

I keep wondering if s/native images/[plain ]firmware files/ ?

287

s/NATIVE/PLAIN/ ? or simply "FIRMWARE FILES"? Consistently everywhere (above/below)

309

to the full(?) pathname of the firmware file

324

I love that example. If you want it more general s/wifi/some/g ;-)

363

Is there a sysctl or tunable to change this?

364

I would highly love an example on how to manually unload such firmware. Does that need the full path or imagename or ...?

share/man/man9/firmware.9
95

Suggestion:

.Pp
Firmware binary files may also be loaded directly rather than embedded into kernel modules.
287

Presumably s/native/binary/ throughout?

327
328–329
339

Yes

342–343
345–347

I feel like there's a better word here than 'subpath' that has a well-defined meaning for the "trailing components" of a pathname but I can't think of it. I do think we at least want 'trailing' to indicate that the string match is anchored at the end of the path.

349–354
356–362
imp marked 20 inline comments as done.Feb 8 2024, 5:39 AM
imp added inline comments.
share/man/man9/firmware.9
95

I'll do jhb's

287

Yup. Done.

364

There's no way to do this directly.

imp marked 3 inline comments as done.

update per review

This revision was not accepted when it landed; it landed in state Needs Review.Feb 29 2024, 4:37 PM
This revision was automatically updated to reflect the committed changes.