Page MenuHomeFreeBSD
Differential D42203

Add ping6 as MLINK to ping
ClosedPublic
Actions

Authored by antranigv_freebsd.am on Oct 13 2023, 7:59 PM.
Tags
None
Referenced Files
F82613412: D42203.id129801.diff
Tue, Apr 30, 9:28 PM
Unknown Object (File)
Fri, Apr 26, 9:00 AM
Unknown Object (File)
Fri, Apr 26, 8:44 AM
Unknown Object (File)
Fri, Apr 26, 2:02 AM
Unknown Object (File)
Mon, Apr 8, 8:46 PM
Unknown Object (File)
Mon, Apr 8, 4:55 PM
Unknown Object (File)
Fri, Apr 5, 6:50 PM
Unknown Object (File)
Fri, Apr 5, 5:34 PM
View All 15 Files
Subscribers
asomers
bcr
chuck
imp
jlduran_gmail.com
lwhsu

Details

Reviewers
chuck
Group Reviewers
docs
Commits
rGcddce522f185: ping6(8): Add ping6(8) as MLINK to ping(8)
rGbd7dceb27c08: ping6(8): Add ping6(8) as MLINK to ping(8)
rGd6e457328d0e: ping6(8): Add ping6(8) as MLINK to ping(8)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

antranigv_freebsd.am created this revision.Oct 13 2023, 7:59 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 13 2023, 7:59 PM
antranigv_freebsd.am requested review of this revision.Oct 13 2023, 7:59 PM
Harbormaster completed remote builds in B53979: Diff 128757.Oct 13 2023, 7:59 PM
antranigv_freebsd.am added a reviewer: docs.Oct 14 2023, 3:00 PM
bcr added a subscriber: bcr.Oct 14 2023, 3:17 PM

Why do you need a docs review for this?

antranigv_freebsd.am added a comment.Oct 14 2023, 4:12 PM
In D42203#962979, @bcr wrote:

Why do you need a docs review for this?

Well it's a single line about MLINKS and Phabricator kept bugging me saying "add a reviewer", so I thought, since it's MLINKS, then I should ping docs ? sounds like reasonable logic? 😃

jlduran_gmail.com added subscribers: asomers, jlduran_gmail.com.Oct 14 2023, 4:31 PM

As long as we are keeping the old ping6 as an alias, I believe this is OK. Try pinging @asomers .

chuck accepted this revision.Oct 16 2023, 5:14 PM
chuck added a subscriber: chuck.

LGTM, but I'll give other folks a chance to peek

This revision is now accepted and ready to land.Oct 16 2023, 5:14 PM
lwhsu added a subscriber: lwhsu.Oct 27 2023, 8:29 AM

We also need to remove OLD_FILES+=usr/share/man/man8/ping6.8.gz from ObsoleteFiles.inc.

antranigv_freebsd.am added a comment.Nov 6 2023, 11:40 PM
In D42203#966915, @lwhsu wrote:

We also need to remove OLD_FILES+=usr/share/man/man8/ping6.8.gz from ObsoleteFiles.inc.

As far as I can tell, there is no /usr/share/man/man8/ping6.8.gz at all, i.e.

# man ping6
No manual entry for ping6
antranigv_freebsd.am added a comment.Nov 6 2023, 11:43 PM
In D42203#966915, @lwhsu wrote:

We also need to remove OLD_FILES+=usr/share/man/man8/ping6.8.gz from ObsoleteFiles.inc.

Ohh my bad! yes! I will remove it from there and diff again.

antranigv_freebsd.am updated this revision to Diff 129801.Nov 6 2023, 11:59 PM
  • remove ping6.8.gz from ObsoleteFiles.inc
This revision now requires review to proceed.Nov 6 2023, 11:59 PM
Harbormaster completed remote builds in B54308: Diff 129801.Nov 7 2023, 12:00 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 7 2023, 9:18 PM
Closed by commit rGd6e457328d0e: ping6(8): Add ping6(8) as MLINK to ping(8) (authored by antranigv_freebsd.am, committed by lwhsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rGd6e457328d0e: ping6(8): Add ping6(8) as MLINK to ping(8).
lwhsu added a commit: rGbd7dceb27c08: ping6(8): Add ping6(8) as MLINK to ping(8).Nov 10 2023, 7:42 AM
lwhsu added a commit: rGcddce522f185: ping6(8): Add ping6(8) as MLINK to ping(8).

Revision Contents
Changeset List

PathSize
1 line
sbin/
ping/
1 line

Diff 129841

View Options

ObsoleteFiles.inc

Loading...
View Options

sbin/ping/Makefile

Loading...