textproc/libgrapheme: Hook up the test suite
ClosedPublic
Actions

Authored by kfv on Sun, Oct 18, 10:06 AM.

Project Tags

None

Referenced Files

	F177462098: D60836.1794474168.diff
	Wed, Nov 11, 9:02 AM

Subscribers

None

Details

Reviewers

dteske
fuz
diizzy

Commits

R11:d1de7051feea: textproc/libgrapheme: Hook up the test suite

Summary

Upstream's test target exits 0 even when tests fail, so patch it
to report failures; 744 line break tests currently fail upstream.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kfv requested review of this revision.Sun, Oct 18, 10:06 AM

kfv created this revision.

Harbormaster completed remote builds in B78333: Diff 190186.Sun, Oct 18, 10:06 AM

kfv added a parent revision: D60773: textproc/libgrapheme: New port.Sun, Oct 18, 10:07 AM

BTW, I haven't bumped PORTREVISION as the package remains unchanged. Please let me know if I should, and I'll do it promptly.

You don't really need to patch the test suite to exit with failure if it does not pass, as the make test target is mainly for human operators to look at.
That said, it's your choice and it's ok to do it if you prefer that.
No PORTREVISION bump needed.

This revision is now accepted and ready to land.Sun, Oct 18, 12:45 PM

Approved for commit.

Well,

In D60836#1395155, @fuz wrote:

You don't really need to patch the test suite to exit with failure if it does not pass, as the make test target is mainly for human operators to look at.
That said, it's your choice and it's ok to do it if you prefer that.
No PORTREVISION bump needed.

Uhm,.. No, https://cgit.freebsd.org/ports/tree/Mk/Features/testing.mk

In D60836#1395161, @diizzy wrote:

Well,

In D60836#1395155, @fuz wrote:

You don't really need to patch the test suite to exit with failure if it does not pass, as the make test target is mainly for human operators to look at.
That said, it's your choice and it's ok to do it if you prefer that.
No PORTREVISION bump needed.

Uhm,.. No, https://cgit.freebsd.org/ports/tree/Mk/Features/testing.mk

Yeah nobody uses that as only about half the test suites actually pass. Good luck with that.

In D60836#1395163, @fuz wrote:

In D60836#1395161, @diizzy wrote:

Well,

In D60836#1395155, @fuz wrote:

You don't really need to patch the test suite to exit with failure if it does not pass, as the make test target is mainly for human operators to look at.
That said, it's your choice and it's ok to do it if you prefer that.
No PORTREVISION bump needed.

Uhm,.. No, https://cgit.freebsd.org/ports/tree/Mk/Features/testing.mk

Yeah nobody uses that as only about half the test suites actually pass. Good luck with that.