Page MenuHomeFreeBSD

vnode read(2)/write(2): acquire rangelock regardless of do_vn_io_fault()
ClosedPublic

Authored by kib on Jul 23 2023, 4:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 16, 3:29 AM
Unknown Object (File)
Fri, Feb 21, 1:52 AM
Unknown Object (File)
Wed, Feb 19, 1:21 AM
Unknown Object (File)
Feb 9 2025, 1:35 AM
Unknown Object (File)
Feb 9 2025, 1:34 AM
Unknown Object (File)
Feb 1 2025, 9:49 PM
Unknown Object (File)
Feb 1 2025, 8:21 AM
Unknown Object (File)
Jan 30 2025, 3:33 PM
Subscribers

Details

Summary
To ensure atomicity of reads against parallel writes and truncates,
vnode lock was not enough at least since introduction of vn_io_fault().
That code only take rangelock when it was possible that vn_read() and
vn_write() could drop the vnode lock.

At least since the introduction of VOP_READ_PGCACHE() which generally
does not lock the vnode at all, rangelocks become required even
for filesystems that do not need vn_io_fault() workaround.  For
instance, tmpfs.

PR:     272678
Analyzed by:    Andrew Gierth  <andrew@tao11.riddles.org.uk>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable