Page MenuHomeFreeBSD

vnode read(2)/write(2): acquire rangelock regardless of do_vn_io_fault()
ClosedPublic

Authored by kib on Jul 23 2023, 4:02 PM.
Tags
None
Referenced Files
F162871391: D41158.diff
Fri, Jul 17, 8:30 PM
Unknown Object (File)
Fri, Jul 3, 8:56 AM
Unknown Object (File)
Thu, Jul 2, 11:31 PM
Unknown Object (File)
Thu, Jul 2, 6:22 AM
Unknown Object (File)
Fri, Jun 26, 8:48 AM
Unknown Object (File)
Wed, Jun 24, 11:59 AM
Unknown Object (File)
Jun 13 2026, 6:58 AM
Unknown Object (File)
Jun 10 2026, 1:14 AM
Subscribers

Details

Summary
To ensure atomicity of reads against parallel writes and truncates,
vnode lock was not enough at least since introduction of vn_io_fault().
That code only take rangelock when it was possible that vn_read() and
vn_write() could drop the vnode lock.

At least since the introduction of VOP_READ_PGCACHE() which generally
does not lock the vnode at all, rangelocks become required even
for filesystems that do not need vn_io_fault() workaround.  For
instance, tmpfs.

PR:     272678
Analyzed by:    Andrew Gierth  <andrew@tao11.riddles.org.uk>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable