Page MenuHomeFreeBSD
Feed Advanced Search

Nov 8 2019

andrew_tao173.riddles.org.uk added a comment to D16494: Uses/lua.mk - add flavor support and other options.

Any breakage is probably my fault - I need to pick this one up again and work on it some more.

Nov 8 2019, 6:41 AM · Restricted Project

Nov 5 2019

andrew_tao173.riddles.org.uk updated the diff for D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.

Fix unneeded dependency on guile-cairo when CAIRO option is off.

Nov 5 2019, 11:34 AM
andrew_tao173.riddles.org.uk updated the test plan for D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.
Nov 5 2019, 11:02 AM

Nov 4 2019

andrew_tao173.riddles.org.uk updated the test plan for D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.
Nov 4 2019, 10:51 AM

Nov 1 2019

andrew_tao173.riddles.org.uk updated the diff for D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.

Add flavors (full/lite).

Nov 1 2019, 5:17 AM

Oct 31 2019

andrew_tao173.riddles.org.uk updated the diff for D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.

Add build dependency on gettext-tools, to get some stuff (gnulib's lib-link.m4) that actually has nothing to do with gettext :-(

Oct 31 2019, 6:27 AM
andrew_tao173.riddles.org.uk added a comment to D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.

Ugh, build does break for some option combinations due to hidden dependency on gettext-tools (for aclocal/lib-link.m4). Will post new patch after next round of tests.

Oct 31 2019, 3:17 AM

Oct 30 2019

andrew_tao173.riddles.org.uk created D22189: New ports devel/g-wrap, graphics/guile-cairo, x11-toolkits/guile-gnome-platform: enables the use of the Gnome GUI from Guile scripts.
Oct 30 2019, 5:04 AM
andrew_tao173.riddles.org.uk requested changes to D22179: lang/lua52: remove REINPLACE_CMD for unmodified file.

No, this change is wrong if LUA_PREFIX is something different from /usr/local, since in that case luaconf.h does indeed get modified.

Oct 30 2019, 2:51 AM

Oct 22 2019

andrew_tao173.riddles.org.uk added a comment to D14709: lang/lua54 - new port for Lua 5.4.0.

Looks like Roberto snuck some hardcoded -Os options into the makefile, we need to either patch those back out or think of something else to do with them.

You should ask about that on the mailing list. -O2 is specified twice, as well as -Os. Which option does the compiler take?

Oct 22 2019, 4:28 AM · Restricted Project

Oct 21 2019

andrew_tao173.riddles.org.uk added a comment to D14709: lang/lua54 - new port for Lua 5.4.0.

Looks like Roberto snuck some hardcoded -Os options into the makefile, we need to either patch those back out or think of something else to do with them.

Oct 21 2019, 11:28 PM · Restricted Project

Oct 17 2019

andrew_tao173.riddles.org.uk added inline comments to D14709: lang/lua54 - new port for Lua 5.4.0.
Oct 17 2019, 8:55 PM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D14709: lang/lua54 - new port for Lua 5.4.0.

You seem to have duplicated a patch? There should be no patch for lua.c other than the extra-patch-libedit-dl one.

Oct 17 2019, 8:50 PM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D14709: lang/lua54 - new port for Lua 5.4.0.
  • When the ASSERT option is selected, the extra-patch-assert file fails to apply cleanly. I tried to port it over but I there has been a change to lgc.c and I don't know enough about lgc to apply the patch (Help Andrew?).
Oct 17 2019, 8:43 PM · Restricted Project

Oct 6 2019

andrew_tao173.riddles.org.uk updated the diff for D21481: Make a start at supporting login.conf environment settings.

Style fixes. Rebase.

Oct 6 2019, 7:01 PM
andrew_tao173.riddles.org.uk added a comment to D14709: lang/lua54 - new port for Lua 5.4.0.

Now that a 5.4.0-beta release has been made, and there are signs that features are actually stabilizing (there have been many changes since work2), perhaps we could pick this up again. The distinfo needs an update of course.

Oct 6 2019, 6:32 PM · Restricted Project

Sep 18 2019

andrew_tao173.riddles.org.uk added a comment to D21481: Make a start at supporting login.conf environment settings.

Further proposal (the patch doesn't do this yet): cron should not override PATH when reading a user crontab; whether it should use the user's path, or daemon's path, rather than the hardcoded default when processing the system crontab is a more open question.

Sep 18 2019, 12:51 AM

Sep 3 2019

andrew_tao173.riddles.org.uk added a comment to D21481: Make a start at supporting login.conf environment settings.

I've been pondering whether limits(1) also needs an option to pick up the environment from the login class, or whether that's better addressed in rc.subr for the case of servicename_class="x" settings.

Sep 3 2019, 9:33 PM

Sep 1 2019

andrew_tao173.riddles.org.uk added a comment to D21402: converters/lua-iconv: fix build on armv7.

Why isn't this just CFLAGS+=-fPIC ?

Because e.g. powerpc64 doesn't need it.

Sep 1 2019, 6:17 PM
andrew_tao173.riddles.org.uk created D21481: Make a start at supporting login.conf environment settings.
Sep 1 2019, 1:08 AM

Aug 31 2019

andrew_tao173.riddles.org.uk added a comment to D21402: converters/lua-iconv: fix build on armv7.

Why isn't this just CFLAGS+=-fPIC ?

Aug 31 2019, 11:28 AM
andrew_tao173.riddles.org.uk added a comment to D21350: Allow more nesting of GEOM partitioning schemes.

I've been running this myself for a while and have done explicit tests as listed in the test plan, and as far as I'm concerned it's done unless anyone has feedback on comments or docs. Anyone up for committing it?

Aug 31 2019, 11:23 AM
andrew_tao173.riddles.org.uk updated the summary of D21350: Allow more nesting of GEOM partitioning schemes.
Aug 31 2019, 11:21 AM

Aug 29 2019

andrew_tao173.riddles.org.uk created D21470: Fix usage of angle-brackets and quotes in make(1) manpage.
Aug 29 2019, 8:37 PM

Aug 23 2019

Herald added a reviewer for D21350: Allow more nesting of GEOM partitioning schemes: manpages.

Add documentation. Update comments. Refine the wording a little.

Aug 23 2019, 9:13 AM

Aug 21 2019

andrew_tao173.riddles.org.uk added a comment to D21350: Allow more nesting of GEOM partitioning schemes.
In D21350#464589, @imp wrote:

OK. Other than the updating the comments, I'm convinced this is a good thing.

Aug 21 2019, 9:06 PM
andrew_tao173.riddles.org.uk added inline comments to D21088: Avoid conflicts with libc symbols in libthr jump table..
Aug 21 2019, 6:15 PM
andrew_tao173.riddles.org.uk added a comment to D21350: Allow more nesting of GEOM partitioning schemes.
In D21350#464485, @imp wrote:

Nesting is there as a sanity check when you try to create an inner container at offset 0, you don't recurse with the outer container somehow... Does this run afoul of that?

Aug 21 2019, 3:29 PM
andrew_tao173.riddles.org.uk created D21350: Allow more nesting of GEOM partitioning schemes.
Aug 21 2019, 1:37 PM

Aug 19 2019

andrew_tao173.riddles.org.uk added a comment to D20981: misc/zoneinfo: install zone1970.tab and other fixes.

ping?

Aug 19 2019, 1:03 AM

Jul 23 2019

D20981: misc/zoneinfo: install zone1970.tab and other fixes now requires review to proceed.

Apologies for needing another review round. Changes:

Jul 23 2019, 5:50 AM
andrew_tao173.riddles.org.uk added a comment to D20981: misc/zoneinfo: install zone1970.tab and other fixes.

Ugh. Hold off on committing, please; there's one more issue to fix.

Jul 23 2019, 3:11 AM
andrew_tao173.riddles.org.uk added a comment to D20981: misc/zoneinfo: install zone1970.tab and other fixes.

Philip: are you taking it, or should I find someone else? (I'm not a committer and as far as I know tmunro is only a src committer)

Jul 23 2019, 2:56 AM

Jul 18 2019

andrew_tao173.riddles.org.uk added a comment to D20981: misc/zoneinfo: install zone1970.tab and other fixes.

This is my final version unless someone spots a problem with it.

Jul 18 2019, 12:30 PM
andrew_tao173.riddles.org.uk added a comment to D20981: misc/zoneinfo: install zone1970.tab and other fixes.

Update PORTREVISION which I forgot before.

Jul 18 2019, 12:19 PM

Jul 17 2019

andrew_tao173.riddles.org.uk created D20981: misc/zoneinfo: install zone1970.tab and other fixes.
Jul 17 2019, 11:12 PM

Jul 15 2019

andrew_tao173.riddles.org.uk added a comment to D20646: Install and use /usr/share/zoneinfo/zone1970.tab.

However, I wonder if the encoding situation is OK; the modern version is in UTF8, and for example, if you pick Asia -> Kazhakstan, you'll see some non-ASCII characters. I'm not sure I understand ncursesw's model of character encoding, but I can see that we are already showing UTF8 text directly from /usr/shared/misc/iso3166 ("Côte d'Ivoire", "Curaçao", ...), so maybe that's OK.

Jul 15 2019, 10:05 AM

Apr 3 2019

andrew_tao173.riddles.org.uk updated the summary of D19799: rewrite of intro(4) manpage.
Apr 3 2019, 9:46 AM · docs
andrew_tao173.riddles.org.uk updated the diff for D19799: rewrite of intro(4) manpage.

Use Dq Li in place of most Ql uses, and use Dq alone in place of some uses of Ql that were not in fact literals.

Apr 3 2019, 9:26 AM · docs
andrew_tao173.riddles.org.uk added a comment to D19799: rewrite of intro(4) manpage.

Qq? there are none of those, only Ql for inline literals (though on second reading some of those are wrong and should have been Dq - will fix).

Apr 3 2019, 8:57 AM · docs

Apr 2 2019

andrew_tao173.riddles.org.uk added inline comments to D19799: rewrite of intro(4) manpage.
Apr 2 2019, 10:13 PM · docs
andrew_tao173.riddles.org.uk added inline comments to D19799: rewrite of intro(4) manpage.
Apr 2 2019, 9:35 PM · docs
andrew_tao173.riddles.org.uk created D19799: rewrite of intro(4) manpage.
Apr 2 2019, 6:01 PM · docs
andrew_tao173.riddles.org.uk added a member for docs: andrew_tao173.riddles.org.uk.
Apr 2 2019, 4:28 PM

Mar 31 2019

andrew_tao173.riddles.org.uk added a comment to D19769: lang/lua53: move assertion to correct place.

The test case I've been using was posted to lua-l in Feb by Sascha Zelzer, but the archives aren't public so I can't just link to it.

Mar 31 2019, 6:56 AM

Jan 30 2019

andrew_tao173.riddles.org.uk added a comment to D19027: libc/tests: Add test case for bug fixed in r343566.

Of course I have no objections (moving the license text from LICENSE into the source files is completely compatible with both the intent and the stated terms of the license).

Jan 30 2019, 12:04 PM

Jan 29 2019

andrew_tao173.riddles.org.uk added a comment to D17814: devel/lua-luarocks: update to 3.2.1.

I'm happy to pick up the flavors work again if there's any likelihood of it actually going anywhere.

Jan 29 2019, 7:43 AM · Restricted Project

Jan 27 2019

andrew_tao173.riddles.org.uk added inline comments to D18939: Add pthread to lang/lua53.
Jan 27 2019, 10:31 AM

Jan 26 2019

andrew_tao173.riddles.org.uk added inline comments to D18939: Add pthread to lang/lua53.
Jan 26 2019, 6:01 AM
andrew_tao173.riddles.org.uk added a comment to D18939: Add pthread to lang/lua53.

While we're in here changing stuff, is it also worth adding a patch for the upvaluejoin bug? The bug in itself is a non-issue, but some prat filed a CVE for it.

Jan 26 2019, 5:37 AM

Jan 25 2019

andrew_tao173.riddles.org.uk added a comment to D18939: Add pthread to lang/lua53.

I think in the short term there's no point in adding an option, and instead we should just append -lpthread to LIBS, since we ignore LIBS when building the .so anyway.

Jan 25 2019, 4:39 PM

Jan 24 2019

andrew_tao173.riddles.org.uk added a comment to D18939: Add pthread to lang/lua53.

Russ, did you check whether that test actually failed without the patch? Because it works fine for me without changing a thing.

Jan 24 2019, 7:43 AM

Aug 15 2018

andrew_tao173.riddles.org.uk updated the diff for D16274: devel/lua-luarocks: update to LuaRocks 3.0.0.

Update to 3.0.1.

Aug 15 2018, 3:44 AM · Restricted Project

Aug 11 2018

andrew_tao173.riddles.org.uk added a comment to D13690: lang/lua53 - Update to 5.3.5.

So, once again, are we done here? I have nothing more to add.

Aug 11 2018, 10:38 PM · Restricted Project

Aug 10 2018

andrew_tao173.riddles.org.uk added a comment to D16274: devel/lua-luarocks: update to LuaRocks 3.0.0.

I'm told there's a 3.0.1 release likely within a week or so that fixes both the bug and the build process issues discussed here.

Aug 10 2018, 3:03 AM · Restricted Project

Aug 8 2018

andrew_tao173.riddles.org.uk updated the diff for D16494: Uses/lua.mk - add flavor support and other options.

Remove an unnecessary conditional as pointed out by mat.

Aug 8 2018, 9:37 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D14709: lang/lua54 - new port for Lua 5.4.0.

Track changes requested by mat for the 5.3 port.

Aug 8 2018, 9:10 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D13690: lang/lua53 - Update to 5.3.5.

Include mat's latest requested changes.

Aug 8 2018, 8:58 PM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D16494: Uses/lua.mk - add flavor support and other options.
Aug 8 2018, 8:34 PM · Restricted Project

Jul 30 2018

andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 30 2018, 7:09 PM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 30 2018, 4:43 PM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 30 2018, 11:11 AM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 30 2018, 10:21 AM · Restricted Project

Jul 29 2018

andrew_tao173.riddles.org.uk added a comment to D14709: lang/lua54 - new port for Lua 5.4.0.

Flavors stuff is up at D16494

Jul 29 2018, 1:46 AM · Restricted Project
andrew_tao173.riddles.org.uk created D16494: Uses/lua.mk - add flavor support and other options.
Jul 29 2018, 1:41 AM · Restricted Project

Jul 28 2018

andrew_tao173.riddles.org.uk added a comment to D14709: lang/lua54 - new port for Lua 5.4.0.

Hi @dbn, Lua 5.4 is still in a beta phase so my preference is to hold this port until the Lua 5.4 official release, then update and push it to the repository. @andrew_tao173.riddles.org.uk has already indicated his preference to hold the port until the Lua release (unless something has changed?)

Jul 28 2018, 9:48 PM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D13690: lang/lua53 - Update to 5.3.5.

So are we done here? I have nothing more to add.

Jul 28 2018, 1:08 AM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D14709: lang/lua54 - new port for Lua 5.4.0.

So are we done here? I have nothing more to add.

Jul 28 2018, 1:07 AM · Restricted Project

Jul 26 2018

andrew_tao173.riddles.org.uk updated the diff for D16274: devel/lua-luarocks: update to LuaRocks 3.0.0.

Style/format fixes

Jul 26 2018, 7:54 AM · Restricted Project

Jul 25 2018

andrew_tao173.riddles.org.uk added inline comments to D16274: devel/lua-luarocks: update to LuaRocks 3.0.0.
Jul 25 2018, 8:30 PM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D16274: devel/lua-luarocks: update to LuaRocks 3.0.0.
Jul 25 2018, 7:19 PM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D16274: devel/lua-luarocks: update to LuaRocks 3.0.0.
Jul 25 2018, 3:17 PM · Restricted Project

Jul 24 2018

andrew_tao173.riddles.org.uk updated the diff for D16274: devel/lua-luarocks: update to LuaRocks 3.0.0.
  • Rebase against current existing port rather than previous version.
    • Add USES+=gmake
    • Add Makefile patches to respect $(DESTDIR) so that make stage works.
    • Fix an upstream bug.
    • Regenerate pkg-plist to match new version's files.
Jul 24 2018, 6:50 PM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D16274: devel/lua-luarocks: update to LuaRocks 3.0.0.

No, seems there's lots more wrong with this - at least the install is broken (looks like it's not respecting the staging dir)

Jul 24 2018, 4:59 AM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D16274: devel/lua-luarocks: update to LuaRocks 3.0.0.

Looks like a missing USES+=gmake

Jul 24 2018, 4:48 AM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D16274: devel/lua-luarocks: update to LuaRocks 3.0.0.

Doesn't build for me. Trying to figure out why.

Jul 24 2018, 4:40 AM · Restricted Project

Jul 23 2018

andrew_tao173.riddles.org.uk updated the diff for D14709: lang/lua54 - new port for Lua 5.4.0.

Changes in line with 5.3.5 patch:

Jul 23 2018, 10:11 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D13690: lang/lua53 - Update to 5.3.5.
  • change DOCSDIR to lua53/lua so that lua53/${PORTNAME} could be used for lua module ports
    • reorganize DOCS install so that check-plist doesn't complain
Jul 23 2018, 10:07 PM · Restricted Project

Jul 21 2018

andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 21 2018, 4:01 PM · Restricted Project

Jul 20 2018

andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 20 2018, 3:35 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D14709: lang/lua54 - new port for Lua 5.4.0.

Sync with 5.3.5 work.

Jul 20 2018, 3:06 AM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D13690: lang/lua53 - Update to 5.3.5.

New version to fix the libedit issue.

Jul 20 2018, 12:09 AM · Restricted Project

Jul 19 2018

andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 19 2018, 3:37 PM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 19 2018, 2:46 PM · Restricted Project

Jul 18 2018

andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 18 2018, 10:34 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D14709: lang/lua54 - new port for Lua 5.4.0.

Use DISTVERSION. This corrects the package version too (now 5.4.0.w2)

Jul 18 2018, 3:52 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D14709: lang/lua54 - new port for Lua 5.4.0.

Change OPTIONS_DEFAULT+= to just = in accordance with nitpicking on the 5.3.5 patch.

Jul 18 2018, 2:27 PM · Restricted Project
andrew_tao173.riddles.org.uk retitled D14709: lang/lua54 - new port for Lua 5.4.0 from Lua 5.4.0 to lang/lua54 - new port for Lua 5.4.0.
Jul 18 2018, 2:22 PM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 18 2018, 2:08 PM · Restricted Project

Jul 17 2018

andrew_tao173.riddles.org.uk updated the diff for D14709: lang/lua54 - new port for Lua 5.4.0.

Remove use of ${PORTNAME} in line with discussions over on the 5.3.5 patch.

Jul 17 2018, 9:55 PM · Restricted Project

Jul 16 2018

andrew_tao173.riddles.org.uk added a reviewer for D14709: lang/lua54 - new port for Lua 5.4.0: andrew_tao173.riddles.org.uk.
Jul 16 2018, 2:40 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D14709: lang/lua54 - new port for Lua 5.4.0.

mat: like this?

Jul 16 2018, 2:22 PM · Restricted Project
andrew_tao173.riddles.org.uk updated the diff for D14709: lang/lua54 - new port for Lua 5.4.0.

This is now a diff against the result of 'svn cp lua53 lua54' as requested by mat.

Jul 16 2018, 2:03 PM · Restricted Project

Jul 15 2018

andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 15 2018, 2:39 AM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 15 2018, 2:34 AM · Restricted Project

Jul 14 2018

andrew_tao173.riddles.org.uk updated the diff for D14709: lang/lua54 - new port for Lua 5.4.0.

Added ASSERT and APICHECK options.

Jul 14 2018, 11:44 PM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D14709: lang/lua54 - new port for Lua 5.4.0.

I may be mistaken, but the experimental (not expeditionary!) run only build packages so I'm hoping we can get the build output and see what needs upgrading. I see now that I can request an experimantal run on Bugzilla so I'll submit one today.

Jul 14 2018, 11:01 PM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D14709: lang/lua54 - new port for Lua 5.4.0.

Note that work2 is not ready for prime time yet (garbage collector bugs, at least)

I didn't see anything on the mailing list that would preclude adding it to the ports collection, or at the very least performing an expeditionary run (if that's possible). @mat, @dbn, I'm keen to get 5.3.5 or preferably 5.4 "build tested" against other packages because I've got a week off work right now with no kids.

Jul 14 2018, 10:23 PM · Restricted Project
andrew_tao173.riddles.org.uk added a comment to D14709: lang/lua54 - new port for Lua 5.4.0.

Note that work2 is not ready for prime time yet (garbage collector bugs, at least)

Jul 14 2018, 9:33 PM · Restricted Project
andrew_tao173.riddles.org.uk added inline comments to D13690: lang/lua53 - Update to 5.3.5.
Jul 14 2018, 9:31 PM · Restricted Project