Page MenuHomeFreeBSD

hvsock: make pcb declaration private
Needs ReviewPublic

Authored by freebsd_igalic.co on Mar 26 2024, 10:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 24 2024, 11:32 PM
Unknown Object (File)
Nov 14 2024, 11:50 AM
Unknown Object (File)
Nov 10 2024, 2:50 AM
Unknown Object (File)
Nov 7 2024, 2:11 PM
Unknown Object (File)
Oct 26 2024, 4:27 PM
Unknown Object (File)
Oct 25 2024, 6:42 PM
Unknown Object (File)
Oct 1 2024, 8:06 PM
Unknown Object (File)
Sep 28 2024, 6:34 AM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This shouldn't be public. Even tho this header file is not public API,
move the pcb declaration to the C file.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56799
Build 53687: arc lint + arc unit

Event Timeline

glebius added inline comments.
sys/dev/hyperv/hvsock/hv_sock.h
33

I'm pretty sure now these three includes can go away. At least socketvar.h and queue.h can. Ideally socket.h should go away, too, and users who get sockaddr definition via hv_sock.h need to be fixed.

he world build needs to be tested of course, don't trust my word :)