Differential D41522

libc: Document support for binary integers.
ClosedPublic
Actions

Authored by des on Aug 21 2023, 12:57 PM.

Tags

None

Referenced Files

	F132313975: D41522.id126297.diff
	Wed, Oct 15, 7:33 PM

	Unknown Object (File)
	Mon, Sep 29, 7:26 PM

	Unknown Object (File)
	Mon, Sep 29, 2:58 PM

	Unknown Object (File)
	Mon, Sep 22, 4:27 PM

	Unknown Object (File)
	Thu, Sep 18, 1:35 AM

	Unknown Object (File)
	Wed, Sep 17, 4:01 PM

	Unknown Object (File)
	Wed, Sep 17, 7:57 AM

	Unknown Object (File)
	Tue, Sep 16, 5:37 PM

Subscribers

Details

Reviewers

debdrup
emaste

Commits

rG76edfabbecde: libc: Document support for binary integers.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Aug 21 2023, 12:57 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 21 2023, 12:57 PM

des requested review of this revision.Aug 21 2023, 12:57 PM

Harbormaster completed remote builds in B53202: Diff 126296.Aug 21 2023, 12:58 PM

des added a parent revision: D41511: libc: Implement N2630..Aug 21 2023, 12:58 PM

dioux -> bdioux

Harbormaster completed remote builds in B53203: Diff 126297.Aug 21 2023, 1:01 PM

Only spotted two minor nits, but they can be fixed before pushing as they don't have to hold up things.

lib/libc/stdio/printf.3
421–427	Why the newline here?
lib/libc/stdio/scanf.3
288–294	Similar to the other, why a newline here?

This revision is now accepted and ready to land.Aug 21 2023, 1:03 PM

des marked 2 inline comments as done.Aug 21 2023, 1:07 PM

des added inline comments.

lib/libc/stdio/printf.3
421–427	it makes no difference for the output but makes the source more readable as each element in the enumeration has the same form.
lib/libc/stdio/scanf.3
288–294	same reason

des marked 2 inline comments as done.Aug 21 2023, 1:07 PM

emaste accepted this revision.Aug 21 2023, 5:32 PM

emaste added a subscriber: emaste.

emaste added inline comments.

lib/libc/stdio/printf.3
421–427	igor complains about blank lines though

des added inline comments.Aug 25 2023, 11:50 PM

lib/libc/stdio/printf.3
421–427	where?

Closed by commit rG76edfabbecde: libc: Document support for binary integers. (authored by des). · Explain WhyAug 28 2023, 3:38 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG76edfabbecde: libc: Document support for binary integers..

des mentioned this in rGbae932999e0f: libc: Implement N2630..Sep 7 2023, 8:29 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

stdio/

34 lines

29 lines

stdlib/

4 lines

4 lines

Diff 126594

lib/libc/stdio/printf.3

Loading...

lib/libc/stdio/scanf.3

Loading...

lib/libc/stdlib/strtol.3

Loading...

lib/libc/stdlib/strtoul.3

Loading...