In D28882#647597, @lwhsu wrote:I mean, we should do this: https://cgit.freebsd.org/src/commit/?id=655fa04406010e56822802e12bf52f42e333988b to fix in a better way.
Also, what stands for VTI? virtual interface? It's non-trivial to me and maybe we can have its full name?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Yesterday
Yesterday
In D28882#647493, @lwhsu wrote:I somehow feel the better fix is creating if_wg MLINK.
Wed, Feb 24
Wed, Feb 24
Rework review to address outstanding issues with examples
debdrup retitled D28882: inetd: Add examples from manual page and other sources from inetd.conf: Add entries for Samba sharing and rsyncd to inetd: Add examples from manual page and other sources.
It's possible Phabricator mangled things.
In D28882#647067, @lwhsu wrote:Just being curious, what's the benefit of running rsyncd through inetd instead of using its standalone daemon?
I forgot to accept this, didn't I.
Once these two minor things have been fixed (which can be done before commiting pushing), it looks good to me.
Tue, Feb 23
Tue, Feb 23
debdrup committed R10:408edcca0746: rc.conf(5): Add note about parallel startup variable (authored by debdrup).
rc.conf(5): Add note about parallel startup variable
Just one small thing, and as long as it builds (which it should, from the looks of it), it looks good to me.
release(7) Fix mistake noted in review
debdrup committed R10:f695e960672d: release(7): Remove stray references to DOC* variables (authored by debdrup).
release(7): Remove stray references to DOC* variables
This time actually correct the hash length, pointed out by @lwhsu
Use correct invocation of Nm macro
debdrup committed R10:75e6f664c469: find(1): Mark -not as an extensions to POSIX (authored by debdrup).
find(1): Mark -not as an extensions to POSIX
Address further feedback by @yuripv
Address feedback by @yuripw on IRC.
Address feedback by @lwhsu and @yuripw
Mon, Feb 22
Mon, Feb 22
debdrup committed R9:1bc7558ecb04: handbook/l10n: Correct reference to csh login file (authored by Ceri Davies <ceri@FreeBSD.org>).
handbook/l10n: Correct reference to csh login file
debdrup committed R9:a0f7ad455b65: Multiple files: Fix 'shared' references (authored by Ceri Davies <ceri@FreeBSD.org>).
Multiple files: Fix 'shared' references
Sat, Feb 20
Sat, Feb 20
I forgot to use the tooling, and missed that the Differential revision field wasn't tagged.
Looks good to me.
Fri, Feb 19
Fri, Feb 19
Address feedback by multiple people
debdrup committed R9:caf336e31413: handbook: Fix link to section about tracking a development branch (authored by Andreas Bjørnestad <panden@gmail.com>).
handbook: Fix link to section about tracking a development branch
debdrup committed R10:248a47a4c2fb: ports(7): Update instructions for package target (authored by debdrup).
ports(7): Update instructions for package target
In D28693#644553, @royger wrote:Other projects I work with that use the Fixes tag don't apply line length rules to it, or to tags in general. I don't think we want to split the title for length reasons.
I don't have a strong opinion regarding the parentheses.
The parentheses just seem to be making use of two of the 72 columns which we have until we need to add a newline.
Do we need them?
debdrup retitled D28781: ports(7): Update instructions for package target from ports(7): Update instructions to match implementation to ports(7): Update instructions for package target.
Address feedback by @0mp
Thu, Feb 18
Thu, Feb 18
Address feedback by @yuripv
Wed, Feb 17
Wed, Feb 17
debdrup committed R9:2d46e9e3f151: handbook/l10n: Fix malformed note (authored by Andreas Bjørnestad <panden@gmail.com>).
handbook/l10n: Fix malformed note
debdrup committed R9:9fdfd323edf1: serial/ppp-slip: Fix typos and improve wording (authored by Andreas Bjørnestad <panden@gmail.com>).
serial/ppp-slip: Fix typos and improve wording
Tue, Feb 16
Tue, Feb 16
debdrup committed R9:8750cad4505a: Makefiles and FDP: Change python binary (authored by yasu_utahime.org).
Makefiles and FDP: Change python binary
I would argue those are important notes, and not simple sentences as this one appears to be, but I'm not going to block you from commiting it, and will defer to anyone else who's tagged as a reviewer. :)
I'm not sure I like the idea of putting emphasis on an entire sentence either via italics or underlining, as I haven't seen that done in any other manual page.
It seems to me that X-MFC-WITH is also used for follow-up commits, not specifically for fixes.
Mon, Feb 15
Mon, Feb 15
debdrup committed R9:c724ce033b53: handbook: Fix typo (authored by Andreas Bjørnestad <panden@gmail.com>).
handbook: Fix typo
Sun, Feb 14
Sun, Feb 14
debdrup committed R9:989bbd57fa03: Makefiles: Add a conditional check on HOSTNAME variable (authored by debdrup).
Makefiles: Add a conditional check on HOSTNAME variable
debdrup committed R9:e6645e5aee8b: relnotes/13.0R: Use gitref macro instead of shortcodes (authored by debdrup).
relnotes/13.0R: Use gitref macro instead of shortcodes
debdrup committed R9:fee800a873f2: status: Correct link to template and wordsmith phrasing (authored by debdrup).
status: Correct link to template and wordsmith phrasing
Sat, Feb 13
Sat, Feb 13
relnotes/13.0R: Add more release notes
FDP: Fix typo
FDP: Remove extraneous article
Fri, Feb 12
Fri, Feb 12
debdrup committed R10:5ae8b018321f: git-arc(1): Fix nits pointed out in final review (authored by debdrup).
git-arc(1): Fix nits pointed out in final review
git-arc(1): Add manual page
debdrup committed R9:b474a500191b: FDP: Refer to the proper package name for hugo (authored by yasu_utahime.org).
FDP: Refer to the proper package name for hugo
FDP: Correct some grammar and mistakes
Thu, Feb 11
Thu, Feb 11
kldload(8): Improve phrasing
This landed as r9:5476df4, but I forgot a Differential revision field.
debdrup committed R9:cef63a2e4321: news.toml: Remove paragraph tags left-over from conversion. (authored by debdrup).
news.toml: Remove paragraph tags left-over from conversion.
debdrup committed R9:5476df45eb06: 13.0R/relnotes: Add entries for changes that happened in bhyve. (authored by debdrup).
13.0R/relnotes: Add entries for changes that happened in bhyve.
Sorry, I meant to tag this planning changes earlier.
Wed, Feb 10
Wed, Feb 10
Address feedback by @0mp
debdrup updated the summary of D28567: 13.0R/relnotes: Add entries for changes that happened in bhyve..
debdrup updated the diff for D28567: 13.0R/relnotes: Add entries for changes that happened in bhyve..
Add commit template which fixes the build and adds links to the commits.
debdrup updated the diff for D28567: 13.0R/relnotes: Add entries for changes that happened in bhyve..
Address feedback by @gjb
debdrup requested review of D28567: 13.0R/relnotes: Add entries for changes that happened in bhyve..
Tue, Feb 9
Tue, Feb 9
Address feedback from @0mp
debdrup committed R9:21e690f0ed3c: newbies: Correct link to X11 chapter (authored by Andreas Bjørnestad <panden@gmail.com>).
newbies: Correct link to X11 chapter
(Please move the conversation out of inline comments)
Since it's FreeBSD specific, I'm not sure either git or arcanist upstreams will accept it - which means anyone will need ports approval to get changes made to it.
I don't see the benefit in this, personally.
Mon, Feb 8
Mon, Feb 8
debdrup added reviewers for D28548: handbook/x11: Suggest kld_list with nvidia-modesetting: x11, docs.
debdrup retitled D28519: git-arc(1): Add manual page from git-arc(8): Add manual page to git-arc(1): Add manual page.
debdrup committed R10:d242f782c249: prepare-commit-msg: Remove blank character (authored by debdrup).
prepare-commit-msg: Remove blank character
Huh, you're right, that is somewhat misleading - however, it's also not completely unique:
find /usr/src/tools/ -type f -name "*.[0-9]" -exec grep "appeared" {} + /usr/src/tools/tools/mcgrab/mcgrab.1:program first appeared in /usr/src/tools/tools/vimage/vimage.8:Network stack virtualization framework first appeared as a patchset /usr/src/tools/tools/vimage/vimage.8:Stiching NLNet, integrated virtualized network stack first appeared in /usr/src/tools/tools/ether_reflect/ether_reflect.1:program first appeared in /usr/src/tools/tools/git/git-arc.1:utility appeared in /usr/src/tools/tools/ioat/ioatcontrol.8:driver first appeared in /usr/src/tools/tools/mctest/mctest.1:program first appeared in
src/tools/tools is included in the src.txz distribution set, but whether that includes being part of a RELEASE is probably outside the scope of this commit ;)
I'm more than happy to change it, but at present I'm not really sure what it should be - I'll leave it unsolved for now, until I find a good way to phrase it.
Address feedback by markj
debdrup added a comment to D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes).
Has all the feedback that's been given been addressed?
In D28519#638602, @0mp wrote:I'm planning to do a review of this in the coming days. I'd like to help you with the mdoc part :)
debdrup committed R10:866c8b8d5ddb: kldload(8): Add note about using kld_list in rc.conf(5) (authored by debdrup).
kldload(8): Add note about using kld_list in rc.conf(5)
debdrup retitled D28519: git-arc(1): Add manual page from arc-git(8): Add manual page to git-arc(8): Add manual page.
Sun, Feb 7
Sun, Feb 7
Capitalize Phabricator and switch from Ic to Cm macro
Address feedback by yuripw
Move flag to its own line with a macro
Hook the manual page up to the build.
Address appease igor