Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

debdrup added a comment to D28882: inetd: Add examples from manual page and other sources.

I mean, we should do this: https://cgit.freebsd.org/src/commit/?id=655fa04406010e56822802e12bf52f42e333988b to fix in a better way.

Also, what stands for VTI? virtual interface? It's non-trivial to me and maybe we can have its full name?

Thu, Feb 25, 6:26 PM
debdrup added a comment to D28882: inetd: Add examples from manual page and other sources.

I somehow feel the better fix is creating if_wg MLINK.

Thu, Feb 25, 11:20 AM
debdrup updated the diff for D28882: inetd: Add examples from manual page and other sources.

Address feeeback by @yuripv and @brueffer

Thu, Feb 25, 11:20 AM

Wed, Feb 24

debdrup updated the summary of D28882: inetd: Add examples from manual page and other sources.
Wed, Feb 24, 8:26 PM
debdrup updated the summary of D28882: inetd: Add examples from manual page and other sources.
Wed, Feb 24, 8:26 PM
debdrup updated the diff for D28882: inetd: Add examples from manual page and other sources.

Rework review to address outstanding issues with examples

Wed, Feb 24, 8:23 PM
debdrup retitled D28882: inetd: Add examples from manual page and other sources from inetd.conf: Add entries for Samba sharing and rsyncd to inetd: Add examples from manual page and other sources.
Wed, Feb 24, 8:22 PM
debdrup added a comment to D26123: [handbook] Remove reference to cusueeme.

It's possible Phabricator mangled things.

Wed, Feb 24, 6:40 PM
debdrup added a comment to D28882: inetd: Add examples from manual page and other sources.

Just being curious, what's the benefit of running rsyncd through inetd instead of using its standalone daemon?

Wed, Feb 24, 10:39 AM
debdrup accepted D28905: committers-guide: update commit trailer descriptions.

I forgot to accept this, didn't I.

Wed, Feb 24, 8:43 AM
debdrup accepted D26123: [handbook] Remove reference to cusueeme.

Once these two minor things have been fixed (which can be done before commiting pushing), it looks good to me.

Wed, Feb 24, 8:42 AM

Tue, Feb 23

debdrup closed D28898: rc.conf(5): Add note about parallel startup variable.
Tue, Feb 23, 9:27 PM
debdrup committed R10:408edcca0746: rc.conf(5): Add note about parallel startup variable (authored by debdrup).
rc.conf(5): Add note about parallel startup variable
Tue, Feb 23, 9:27 PM
debdrup added a comment to D28905: committers-guide: update commit trailer descriptions.

Just one small thing, and as long as it builds (which it should, from the looks of it), it looks good to me.

Tue, Feb 23, 7:44 PM
debdrup committed R10:ef1a1fc7e828: release(7) Fix mistake noted in review (authored by debdrup).
release(7) Fix mistake noted in review
Tue, Feb 23, 6:12 PM
debdrup closed D28881: release(7): Remove stray references to DOC* variables.
Tue, Feb 23, 6:08 PM
debdrup committed R10:f695e960672d: release(7): Remove stray references to DOC* variables (authored by debdrup).
release(7): Remove stray references to DOC* variables
Tue, Feb 23, 6:08 PM
debdrup updated the diff for D28881: release(7): Remove stray references to DOC* variables.

This time actually correct the hash length, pointed out by @lwhsu

Tue, Feb 23, 4:39 PM
debdrup updated the diff for D28898: rc.conf(5): Add note about parallel startup variable.

Use correct invocation of Nm macro

Tue, Feb 23, 4:23 PM
debdrup committed R10:75e6f664c469: find(1): Mark -not as an extensions to POSIX (authored by debdrup).
find(1): Mark -not as an extensions to POSIX
Tue, Feb 23, 4:17 PM
debdrup updated the diff for D28898: rc.conf(5): Add note about parallel startup variable.

Address further feedback by @yuripv

Tue, Feb 23, 3:36 PM
debdrup updated the test plan for D28898: rc.conf(5): Add note about parallel startup variable.
Tue, Feb 23, 3:11 PM
debdrup requested review of D28898: rc.conf(5): Add note about parallel startup variable.
Tue, Feb 23, 3:10 PM
debdrup updated the diff for D28881: release(7): Remove stray references to DOC* variables.

Address feedback by @yuripw on IRC.

Tue, Feb 23, 2:44 PM
debdrup updated the diff for D28881: release(7): Remove stray references to DOC* variables.

Address feedback by @lwhsu and @yuripw

Tue, Feb 23, 2:42 PM
debdrup requested review of D28882: inetd: Add examples from manual page and other sources.
Tue, Feb 23, 9:36 AM
debdrup updated the test plan for D28881: release(7): Remove stray references to DOC* variables.
Tue, Feb 23, 8:34 AM
debdrup requested review of D28881: release(7): Remove stray references to DOC* variables.
Tue, Feb 23, 8:34 AM

Mon, Feb 22

debdrup committed R9:1bc7558ecb04: handbook/l10n: Correct reference to csh login file (authored by Ceri Davies <ceri@FreeBSD.org>).
handbook/l10n: Correct reference to csh login file
Mon, Feb 22, 7:56 PM
debdrup committed R9:a0f7ad455b65: Multiple files: Fix 'shared' references (authored by Ceri Davies <ceri@FreeBSD.org>).
Multiple files: Fix 'shared' references
Mon, Feb 22, 6:30 PM

Sat, Feb 20

debdrup abandoned D28781: ports(7): Update instructions for package target.

I forgot to use the tooling, and missed that the Differential revision field wasn't tagged.

Sat, Feb 20, 5:15 AM
debdrup accepted D28815: Add commit message information to committer's guide.

Looks good to me.

Sat, Feb 20, 5:05 AM

Fri, Feb 19

debdrup added inline comments to D28622: handbook/config: Add section on configuring IPv6.
Fri, Feb 19, 2:38 PM
debdrup updated the diff for D28622: handbook/config: Add section on configuring IPv6.

Address feedback by multiple people

Fri, Feb 19, 2:38 PM
debdrup committed R9:caf336e31413: handbook: Fix link to section about tracking a development branch (authored by Andreas Bjørnestad <panden@gmail.com>).
handbook: Fix link to section about tracking a development branch
Fri, Feb 19, 1:26 PM
debdrup committed R10:248a47a4c2fb: ports(7): Update instructions for package target (authored by debdrup).
ports(7): Update instructions for package target
Fri, Feb 19, 12:47 PM
debdrup added a comment to D28693: prepare-commit-msg: add "Fixes:" .

Other projects I work with that use the Fixes tag don't apply line length rules to it, or to tags in general. I don't think we want to split the title for length reasons.

I don't have a strong opinion regarding the parentheses.

Fri, Feb 19, 9:03 AM
debdrup added a comment to D28693: prepare-commit-msg: add "Fixes:" .

The parentheses just seem to be making use of two of the 72 columns which we have until we need to add a newline.
Do we need them?

Fri, Feb 19, 5:19 AM
debdrup retitled D28781: ports(7): Update instructions for package target from ports(7): Update instructions to match implementation to ports(7): Update instructions for package target.
Fri, Feb 19, 5:09 AM
debdrup updated the diff for D28781: ports(7): Update instructions for package target.

Address feedback by @0mp

Fri, Feb 19, 5:07 AM

Thu, Feb 18

debdrup added inline comments to D28781: ports(7): Update instructions for package target.
Thu, Feb 18, 10:27 PM
debdrup updated the diff for D28781: ports(7): Update instructions for package target.

Address feedback by @yuripv

Thu, Feb 18, 10:27 PM
debdrup updated the test plan for D28781: ports(7): Update instructions for package target.
Thu, Feb 18, 10:01 PM
debdrup requested review of D28781: ports(7): Update instructions for package target.
Thu, Feb 18, 9:59 PM

Wed, Feb 17

debdrup committed R9:2d46e9e3f151: handbook/l10n: Fix malformed note (authored by Andreas Bjørnestad <panden@gmail.com>).
handbook/l10n: Fix malformed note
Wed, Feb 17, 4:06 PM
debdrup committed R9:9fdfd323edf1: serial/ppp-slip: Fix typos and improve wording (authored by Andreas Bjørnestad <panden@gmail.com>).
serial/ppp-slip: Fix typos and improve wording
Wed, Feb 17, 8:39 AM

Tue, Feb 16

debdrup committed R9:8750cad4505a: Makefiles and FDP: Change python binary (authored by yasu_utahime.org).
Makefiles and FDP: Change python binary
Tue, Feb 16, 6:52 PM
debdrup added a comment to D28701: jail.conf(5): emphasize where to find jail parameters.

I would argue those are important notes, and not simple sentences as this one appears to be, but I'm not going to block you from commiting it, and will defer to anyone else who's tagged as a reviewer. :)

Tue, Feb 16, 1:14 PM
debdrup added a comment to D28701: jail.conf(5): emphasize where to find jail parameters.

I'm not sure I like the idea of putting emphasis on an entire sentence either via italics or underlining, as I haven't seen that done in any other manual page.

Tue, Feb 16, 12:16 PM
debdrup added a comment to D28693: prepare-commit-msg: add "Fixes:" .

It seems to me that X-MFC-WITH is also used for follow-up commits, not specifically for fixes.

Tue, Feb 16, 7:57 AM

Mon, Feb 15

debdrup committed R9:c724ce033b53: handbook: Fix typo (authored by Andreas Bjørnestad <panden@gmail.com>).
handbook: Fix typo
Mon, Feb 15, 8:51 AM

Sun, Feb 14

debdrup committed R9:989bbd57fa03: Makefiles: Add a conditional check on HOSTNAME variable (authored by debdrup).
Makefiles: Add a conditional check on HOSTNAME variable
Sun, Feb 14, 9:52 PM
debdrup committed R9:e6645e5aee8b: relnotes/13.0R: Use gitref macro instead of shortcodes (authored by debdrup).
relnotes/13.0R: Use gitref macro instead of shortcodes
Sun, Feb 14, 10:21 AM
debdrup committed R9:fee800a873f2: status: Correct link to template and wordsmith phrasing (authored by debdrup).
status: Correct link to template and wordsmith phrasing
Sun, Feb 14, 7:54 AM

Sat, Feb 13

debdrup committed R9:ba631cb51b5f: relnotes/13.0R: Add more release notes (authored by debdrup).
relnotes/13.0R: Add more release notes
Sat, Feb 13, 7:41 PM
debdrup committed R9:4023bd3f771f: FDP: Fix typo (authored by debdrup).
FDP: Fix typo
Sat, Feb 13, 6:44 PM
debdrup committed R9:b046222873a5: FDP: Remove extraneous article (authored by debdrup).
FDP: Remove extraneous article
Sat, Feb 13, 6:16 AM

Fri, Feb 12

debdrup committed R10:5ae8b018321f: git-arc(1): Fix nits pointed out in final review (authored by debdrup).
git-arc(1): Fix nits pointed out in final review
Fri, Feb 12, 10:41 PM
debdrup closed D28519: git-arc(1): Add manual page.
Fri, Feb 12, 10:37 PM
debdrup committed R10:30f78a063e0d: git-arc(1): Add manual page (authored by debdrup).
git-arc(1): Add manual page
Fri, Feb 12, 10:37 PM
debdrup committed R9:b474a500191b: FDP: Refer to the proper package name for hugo (authored by yasu_utahime.org).
FDP: Refer to the proper package name for hugo
Fri, Feb 12, 10:16 PM
debdrup committed R9:04b118c62649: FDP: Correct some grammar and mistakes (authored by debdrup).
FDP: Correct some grammar and mistakes
Fri, Feb 12, 7:53 PM
debdrup requested review of D28622: handbook/config: Add section on configuring IPv6.
Fri, Feb 12, 5:17 PM

Thu, Feb 11

debdrup committed R10:2a7d4d954504: kldload(8): Improve phrasing (authored by debdrup).
kldload(8): Improve phrasing
Thu, Feb 11, 5:05 AM
debdrup closed D28542: kldload(8): Improve phrasing.
Thu, Feb 11, 5:05 AM
debdrup closed D28567: 13.0R/relnotes: Add entries for changes that happened in bhyve..

This landed as r9:5476df4, but I forgot a Differential revision field.

Thu, Feb 11, 4:29 AM
debdrup closed D28353: news.toml: Remove paragraph tags left-over from conversion..
Thu, Feb 11, 4:26 AM
debdrup committed R9:cef63a2e4321: news.toml: Remove paragraph tags left-over from conversion. (authored by debdrup).
news.toml: Remove paragraph tags left-over from conversion.
Thu, Feb 11, 4:26 AM
debdrup committed R9:5476df45eb06: 13.0R/relnotes: Add entries for changes that happened in bhyve. (authored by debdrup).
13.0R/relnotes: Add entries for changes that happened in bhyve.
Thu, Feb 11, 4:22 AM
debdrup planned changes to D28548: handbook/x11: Suggest kld_list with nvidia-modesetting.

Sorry, I meant to tag this planning changes earlier.

Thu, Feb 11, 4:08 AM

Wed, Feb 10

debdrup updated the diff for D28519: git-arc(1): Add manual page.

Address feedback by @0mp

Wed, Feb 10, 5:43 PM
debdrup updated the summary of D28567: 13.0R/relnotes: Add entries for changes that happened in bhyve..
Wed, Feb 10, 5:45 AM
debdrup updated the diff for D28567: 13.0R/relnotes: Add entries for changes that happened in bhyve..

Add commit template which fixes the build and adds links to the commits.

Wed, Feb 10, 5:43 AM
debdrup updated the diff for D28567: 13.0R/relnotes: Add entries for changes that happened in bhyve..

Address feedback by @gjb

Wed, Feb 10, 5:20 AM
debdrup requested review of D28567: 13.0R/relnotes: Add entries for changes that happened in bhyve..
Wed, Feb 10, 4:36 AM

Tue, Feb 9

debdrup added inline comments to D28519: git-arc(1): Add manual page.
Tue, Feb 9, 8:42 PM
debdrup updated the diff for D28519: git-arc(1): Add manual page.

Address feedback from @0mp

Tue, Feb 9, 8:42 PM
debdrup committed R9:21e690f0ed3c: newbies: Correct link to X11 chapter (authored by Andreas Bjørnestad <panden@gmail.com>).
newbies: Correct link to X11 chapter
Tue, Feb 9, 1:41 PM
debdrup added a comment to D28519: git-arc(1): Add manual page.

(Please move the conversation out of inline comments)
Since it's FreeBSD specific, I'm not sure either git or arcanist upstreams will accept it - which means anyone will need ports approval to get changes made to it.
I don't see the benefit in this, personally.

Tue, Feb 9, 1:10 AM

Mon, Feb 8

debdrup added reviewers for D28548: handbook/x11: Suggest kld_list with nvidia-modesetting: x11, docs.
Mon, Feb 8, 11:12 PM
debdrup requested review of D28548: handbook/x11: Suggest kld_list with nvidia-modesetting.
Mon, Feb 8, 11:00 PM
debdrup retitled D28519: git-arc(1): Add manual page from git-arc(8): Add manual page to git-arc(1): Add manual page.
Mon, Feb 8, 9:47 PM
debdrup updated the diff for D28519: git-arc(1): Add manual page.

Address last bit of open feedback by @markj and @emaste

Mon, Feb 8, 7:27 PM
debdrup committed R10:d242f782c249: prepare-commit-msg: Remove blank character (authored by debdrup).
prepare-commit-msg: Remove blank character
Mon, Feb 8, 7:19 PM
debdrup updated the test plan for D28542: kldload(8): Improve phrasing.
Mon, Feb 8, 7:14 PM
debdrup requested review of D28542: kldload(8): Improve phrasing.
Mon, Feb 8, 7:12 PM
debdrup added a comment to D28519: git-arc(1): Add manual page.

Huh, you're right, that is somewhat misleading - however, it's also not completely unique:

find /usr/src/tools/ -type f -name "*.[0-9]" -exec grep "appeared" {} +
/usr/src/tools/tools/mcgrab/mcgrab.1:program first appeared in
/usr/src/tools/tools/vimage/vimage.8:Network stack virtualization framework first appeared as a patchset
/usr/src/tools/tools/vimage/vimage.8:Stiching NLNet, integrated virtualized network stack first appeared in
/usr/src/tools/tools/ether_reflect/ether_reflect.1:program first appeared in
/usr/src/tools/tools/git/git-arc.1:utility appeared in
/usr/src/tools/tools/ioat/ioatcontrol.8:driver first appeared in
/usr/src/tools/tools/mctest/mctest.1:program first appeared in

src/tools/tools is included in the src.txz distribution set, but whether that includes being part of a RELEASE is probably outside the scope of this commit ;)
I'm more than happy to change it, but at present I'm not really sure what it should be - I'll leave it unsolved for now, until I find a good way to phrase it.

Mon, Feb 8, 6:34 PM
debdrup updated the diff for D28519: git-arc(1): Add manual page.

Address feedback by markj

Mon, Feb 8, 6:16 PM
debdrup added a comment to D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes).

Has all the feedback that's been given been addressed?

Mon, Feb 8, 1:51 PM
debdrup added a comment to D28519: git-arc(1): Add manual page.
In D28519#638602, @0mp wrote:

I'm planning to do a review of this in the coming days. I'd like to help you with the mdoc part :)

Mon, Feb 8, 11:05 AM
debdrup committed R10:866c8b8d5ddb: kldload(8): Add note about using kld_list in rc.conf(5) (authored by debdrup).
kldload(8): Add note about using kld_list in rc.conf(5)
Mon, Feb 8, 7:06 AM
debdrup retitled D28519: git-arc(1): Add manual page from arc-git(8): Add manual page to git-arc(8): Add manual page.
Mon, Feb 8, 6:22 AM

Sun, Feb 7

debdrup added inline comments to D28519: git-arc(1): Add manual page.
Sun, Feb 7, 8:22 PM
debdrup updated the diff for D28519: git-arc(1): Add manual page.

Capitalize Phabricator and switch from Ic to Cm macro

Sun, Feb 7, 8:19 PM
debdrup updated the diff for D28519: git-arc(1): Add manual page.

Address feedback by yuripw

Sun, Feb 7, 8:10 PM
debdrup updated the diff for D28519: git-arc(1): Add manual page.

Move flag to its own line with a macro

Sun, Feb 7, 4:18 AM
debdrup updated the diff for D28519: git-arc(1): Add manual page.

Hook the manual page up to the build.

Sun, Feb 7, 3:11 AM
debdrup updated the test plan for D28519: git-arc(1): Add manual page.
Sun, Feb 7, 3:06 AM
debdrup updated the diff for D28519: git-arc(1): Add manual page.

Address appease igor

Sun, Feb 7, 3:06 AM
debdrup updated the summary of D28519: git-arc(1): Add manual page.
Sun, Feb 7, 2:53 AM