In D28882#647597, @lwhsu wrote:

I mean, we should do this: https://cgit.freebsd.org/src/commit/?id=655fa04406010e56822802e12bf52f42e333988b to fix in a better way.

Also, what stands for VTI? virtual interface? It's non-trivial to me and maybe we can have its full name?

In D28882#647493, @lwhsu wrote:

I somehow feel the better fix is creating if_wg MLINK.

Address feeeback by @yuripv and @brueffer

Rework review to address outstanding issues with examples

It's possible Phabricator mangled things.

In D28882#647067, @lwhsu wrote:

Just being curious, what's the benefit of running rsyncd through inetd instead of using its standalone daemon?

I forgot to accept this, didn't I.

Once these two minor things have been fixed (which can be done before commiting pushing), it looks good to me.

Just one small thing, and as long as it builds (which it should, from the looks of it), it looks good to me.

This time actually correct the hash length, pointed out by @lwhsu

Use correct invocation of Nm macro

Address further feedback by @yuripv

Address feedback by @yuripw on IRC.

Address feedback by @lwhsu and @yuripw

I forgot to use the tooling, and missed that the Differential revision field wasn't tagged.

Looks good to me.

Address feedback by multiple people

In D28693#644553, @royger wrote:

Other projects I work with that use the Fixes tag don't apply line length rules to it, or to tags in general. I don't think we want to split the title for length reasons.

I don't have a strong opinion regarding the parentheses.

The parentheses just seem to be making use of two of the 72 columns which we have until we need to add a newline.
Do we need them?

Address feedback by @0mp

Address feedback by @yuripv

I would argue those are important notes, and not simple sentences as this one appears to be, but I'm not going to block you from commiting it, and will defer to anyone else who's tagged as a reviewer. :)

I'm not sure I like the idea of putting emphasis on an entire sentence either via italics or underlining, as I haven't seen that done in any other manual page.

It seems to me that X-MFC-WITH is also used for follow-up commits, not specifically for fixes.

This landed as r9:5476df4, but I forgot a Differential revision field.

Sorry, I meant to tag this planning changes earlier.

Address feedback by @0mp

Add commit template which fixes the build and adds links to the commits.

Address feedback by @gjb

Address feedback from @0mp

(Please move the conversation out of inline comments)
Since it's FreeBSD specific, I'm not sure either git or arcanist upstreams will accept it - which means anyone will need ports approval to get changes made to it.
I don't see the benefit in this, personally.

Address last bit of open feedback by @markj and @emaste

Huh, you're right, that is somewhat misleading - however, it's also not completely unique:

find /usr/src/tools/ -type f -name "*.[0-9]" -exec grep "appeared" {} +
/usr/src/tools/tools/mcgrab/mcgrab.1:program first appeared in
/usr/src/tools/tools/vimage/vimage.8:Network stack virtualization framework first appeared as a patchset
/usr/src/tools/tools/vimage/vimage.8:Stiching NLNet, integrated virtualized network stack first appeared in
/usr/src/tools/tools/ether_reflect/ether_reflect.1:program first appeared in
/usr/src/tools/tools/git/git-arc.1:utility appeared in
/usr/src/tools/tools/ioat/ioatcontrol.8:driver first appeared in
/usr/src/tools/tools/mctest/mctest.1:program first appeared in

src/tools/tools is included in the src.txz distribution set, but whether that includes being part of a RELEASE is probably outside the scope of this commit ;)
I'm more than happy to change it, but at present I'm not really sure what it should be - I'll leave it unsolved for now, until I find a good way to phrase it.

Address feedback by markj

Has all the feedback that's been given been addressed?

In D28519#638602, @0mp wrote:

I'm planning to do a review of this in the coming days. I'd like to help you with the mdoc part :)

Capitalize Phabricator and switch from Ic to Cm macro

Address feedback by yuripw

Move flag to its own line with a macro

Hook the manual page up to the build.

Address appease igor