Paths

Table of Contentst

Differential D34690

RDMA driver for Intel(R) Ethernet Controller E810
ClosedPublic
Actions

Authored by bartosz.sobczak_intel.com on Mar 28 2022, 10:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 15, 5:21 AM

	Unknown Object (File)
	Fri, May 15, 4:30 AM

	Unknown Object (File)
	Fri, May 15, 4:30 AM

	Unknown Object (File)
	Thu, May 14, 11:25 PM

	Unknown Object (File)
	Mon, May 11, 6:48 PM

	Unknown Object (File)
	Mon, May 11, 5:48 PM

	Unknown Object (File)
	Sun, May 10, 6:37 PM

	Unknown Object (File)
	Sun, May 10, 12:40 PM

Subscribers

pauamma_gundo.com

Details

Reviewers

erj
kgalazka
pauamma_gundo.com

Group Reviewers

Intel Networking
manpages

Commits

rG42bad04a2156: irdma: Add RDMA driver for Intel(R) Ethernet Controller E810
rGcdcd52d41e24: irdma: Add RDMA driver for Intel(R) Ethernet Controller E810
rGacdfbc6cbe0a: irdma: fix LINT-NOIP/NOINET/NOINET6 builds
rGa6e275af4664: irdma(4): Fix previous commit that broke build on amd64
rGe602a30bb9fc: irdma(4): Fix compile error on powerpc64

Summary

This is an initial commit for RDMA FreeBSD driver for Intel(R) Ethernet Controller E810, called irdma.
Supporting both RoCEv2 and iWARP protocols in per-PF manner, RoCEv2 being the default.

Change https://reviews.freebsd.org/D30889 is required for the driver to attach to the device.

Test Plan

Testing has been done using krping tool, perftest, ucmatose, rping, ud_pingpong, rc_pingpong and others.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

bartosz.sobczak_intel.com created this revision.Mar 28 2022, 10:22 AM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptMar 28 2022, 10:22 AM

bartosz.sobczak_intel.com requested review of this revision.Mar 28 2022, 10:22 AM

pkubaj added a subscriber: pkubaj.Mar 28 2022, 5:20 PM

Why not add irdma also to sys/powerpc/conf/NOTES and sys/arm64/conf/NOTES? ice is enabled on both of those.

pauamma_gundo.com requested changes to this revision.Mar 28 2022, 10:16 PM

pauamma_gundo.com added a subscriber: pauamma_gundo.com.

pauamma_gundo.com added inline comments.

share/man/man4/irdma.4
79
83
87
91
95
99
103
105	Is that the TCP congestion window?
107
111
113
122
128
135
140
142
147	How many lines do you expect, typically? Unless they're many, "some" or "one or more" would work better.
155
158
167
169
191
208
214
225	Spurious line?
227
233	I'd add the manual page author.
sys/amd64/conf/NOTES
293	I'd mention the ice requirement.

This revision now requires changes to proceed.Mar 28 2022, 10:16 PM

erj added a parent revision: D30889: ice(4): Add RDMA Client Interface.Mar 30 2022, 11:57 PM

Applied changes suggested to the man page and NOTES

Have you run the manual page through mandoc -Tlint and igor from textproc/igor?

With that minor change, manual page is go provided it matches the source.

share/man/man4/irdma.4
139	"in" feels more natural here.

This revision is now accepted and ready to land.Apr 7 2022, 8:40 PM

Committed, with some additional compile fixes (added in Commits section)

erj added a commit: rG42bad04a2156: irdma: Add RDMA driver for Intel(R) Ethernet Controller E810.Mar 17 2023, 4:33 AM

Revision Contents
Changeset List

Path

Size

contrib/

ofed/

libirdma/

180 lines

69 lines

64 lines

92 lines

143 lines

93 lines

554 lines

1884 lines

218 lines

255 lines

479 lines

2262 lines

10 lines

213 lines

lib/

ofed/

2 lines

libirdma/

23 lines

share/

man/

man4/

233 lines

mk/

bsd.libnames.mk

1 line

src.libnames.mk

3 lines

sys/

amd64/

conf/

3 lines

conf/

31 lines

dev/

irdma/

251 lines

736 lines

92 lines

704 lines

137 lines

418 lines

143 lines

238 lines

453 lines

4253 lines

5644 lines

2337 lines

202 lines

734 lines

2829 lines

irdma_kcompat.c

1568 lines

589 lines

166 lines

557 lines

141 lines

221 lines

1856 lines

1533 lines

120 lines

318 lines

415 lines

1808 lines

477 lines

2325 lines

313 lines

3366 lines

74 lines

447 lines

247 lines

modules/

4 lines

irdma/

23 lines

usr.bin/

ofed/

libibverbs/

2 lines

librdmacm/

2 lines

Diff 104712

contrib/ofed/libirdma/abi.h

Loading...

contrib/ofed/libirdma/i40e_devids.h

Loading...

contrib/ofed/libirdma/i40iw_hw.h

Loading...

contrib/ofed/libirdma/ice_devids.h

Loading...

contrib/ofed/libirdma/irdma-abi.h

Loading...

contrib/ofed/libirdma/irdma.h

Loading...

contrib/ofed/libirdma/irdma_defs.h

Loading...

contrib/ofed/libirdma/irdma_uk.c

Loading...

contrib/ofed/libirdma/irdma_umain.h

Loading...

contrib/ofed/libirdma/irdma_umain.c

Loading...

contrib/ofed/libirdma/irdma_user.h

Loading...

contrib/ofed/libirdma/irdma_uverbs.c

Loading...

contrib/ofed/libirdma/libirdma.map

Loading...

contrib/ofed/libirdma/osdep.h

Loading...

lib/ofed/Makefile

Loading...

lib/ofed/libirdma/Makefile

Loading...

share/man/man4/irdma.4

Loading...

share/mk/bsd.libnames.mk

Loading...

share/mk/src.libnames.mk

Loading...

sys/amd64/conf/NOTES

Loading...

sys/conf/files

Loading...

sys/dev/irdma/fbsd_kcompat.h

Loading...

sys/dev/irdma/fbsd_kcompat.c

Loading...

sys/dev/irdma/ice_devids.h

Loading...

sys/dev/irdma/icrdma.c

Loading...

sys/dev/irdma/icrdma_hw.h

Loading...

sys/dev/irdma/icrdma_hw.c

Loading...

sys/dev/irdma/irdma-abi.h

Loading...

sys/dev/irdma/irdma.h

Loading...

sys/dev/irdma/irdma_cm.h

Loading...

sys/dev/irdma/irdma_cm.c

Loading...

sys/dev/irdma/irdma_ctrl.c

Loading...

sys/dev/irdma/irdma_defs.h

Loading...

sys/dev/irdma/irdma_hmc.h

Loading...

sys/dev/irdma/irdma_hmc.c

Loading...

sys/dev/irdma/irdma_hw.c

Loading...

sys/dev/irdma/irdma_kcompat.c

Loading...

sys/dev/irdma/irdma_main.h

Loading...

sys/dev/irdma/irdma_pble.h

Loading...

sys/dev/irdma/irdma_pble.c

Loading...

sys/dev/irdma/irdma_protos.h

Loading...

sys/dev/irdma/irdma_puda.h

Loading...

sys/dev/irdma/irdma_puda.c

Loading...

sys/dev/irdma/irdma_type.h

Loading...

sys/dev/irdma/irdma_uda.h

Loading...

sys/dev/irdma/irdma_uda.c

Loading...

sys/dev/irdma/irdma_uda_d.h

Loading...

sys/dev/irdma/irdma_uk.c

Loading...

sys/dev/irdma/irdma_user.h

Loading...

sys/dev/irdma/irdma_utils.c

Loading...

sys/dev/irdma/irdma_verbs.h

Loading...

sys/dev/irdma/irdma_verbs.c

Loading...

sys/dev/irdma/irdma_ws.h

Loading...

sys/dev/irdma/irdma_ws.c

Loading...

sys/dev/irdma/osdep.h

Loading...

sys/modules/Makefile

Loading...

sys/modules/irdma/Makefile

Loading...

usr.bin/ofed/libibverbs/Makefile.inc

Loading...

usr.bin/ofed/librdmacm/Makefile.inc

Loading...