Page MenuHomeFreeBSD

ice(4): Update to 1.34.2-k
ClosedPublic

Authored by erj on Jan 25 2022, 3:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 16 2024, 6:06 PM
Unknown Object (File)
Dec 31 2023, 2:17 AM
Unknown Object (File)
Dec 28 2023, 10:50 PM
Unknown Object (File)
Dec 22 2023, 11:00 PM
Unknown Object (File)
Dec 20 2023, 7:30 AM
Unknown Object (File)
Dec 10 2023, 2:28 PM
Unknown Object (File)
Dec 6 2023, 10:18 PM
Unknown Object (File)
Nov 7 2023, 11:42 PM

Details

Summary
  • Adds FW logging support
    • Once enabled, this lets the firmware print event and error messages to the log, increasing the visibility into what the hardware is doing; it's useful for debugging.
  • General bug fixes
  • Adds initial DCB support to the driver
    • Notably, this adds support for DCBX to the driver -- now with fw_lldp set to 1, the driver and adapter will adopt a DCBX configuration sent from a link partner.
    • Add statistics sysctls for priority flow control frames
    • Add new configuration sysctls for DCB-related features: user priority to TC mapping, ETS bandwidth allocation, priority flow control
  • Remove unused SR-IOV files (until support gets added)

Signed-off-by: Eric Joyner <erj@FreeBSD.org>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

erj requested review of this revision.Jan 25 2022, 3:09 AM

Fix spelling mistake caught by lint

sys/dev/ice/ice_iflib_txrx.c
411

This function is now called by iflib in its TX path to determine which queue to output on

sys/dev/ice/ice_lib.c
3760

We've added new DCB configuration sysctls, but these should be documented in an upcoming man page

sys/dev/ice/ice_lib.h
204

FW logging can generate a lot of messages in a short span of time, so this value was increased to the maximum possible one.

574

This state is used to track when multiple traffic classes are in use by the hardware/driver

sys/dev/ice/ice_dcb.c
1471–1604

There is initial support infrastructure in the driver to support DSCP DCB mode, but actual support in the driver is coming later.

sys/dev/ice/ice_iflib_txrx.c
340

Things got shuffled around here in ice_ift_rxd_pkt_get(); some of the code in the for-loop has been moved out of the for-loop because it only applies to the last descriptor in a packet.

356

iflib doesn't handle this case well and it causes issues, but in practice this only seems to happen when adapters are configured to store bad packets which I don't think we currently allow in this driver.

sys/dev/ice/ice_lib.c
7524

This chunk of added code is new for configuring DCB-related things.

This revision is now accepted and ready to land.Mar 4 2022, 1:12 PM
This revision was automatically updated to reflect the committed changes.