Page MenuHomeFreeBSD

marius (Marius Strobl)
User

Projects

User Details

User Since
Jun 3 2014, 3:27 PM (236 w, 5 d)

Recent Activity

Thu, Nov 29

marius committed rS341267: MFV: r341039, MFC: r341041, MF12: r341264.
MFV: r341039, MFC: r341041, MF12: r341264
Thu, Nov 29, 10:02 PM
marius committed rS341266: MFC: r341016, MF12: r341261.
MFC: r341016, MF12: r341261
Thu, Nov 29, 10:01 PM
marius committed rS341264: MFV: r341039, MFC: r341041.
MFV: r341039, MFC: r341041
Thu, Nov 29, 9:12 PM
marius committed rS341261: MFC: r341016.
MFC: r341016
Thu, Nov 29, 8:51 PM

Tue, Nov 27

marius committed rS341041: Import CK as of 21d3e319407d19dece16ee317c757ffc54a452bc, which makes its.
Import CK as of 21d3e319407d19dece16ee317c757ffc54a452bc, which makes its
Tue, Nov 27, 12:37 PM
marius committed rS341040: Tag the import of CK as of 21d3e319407d19dece16ee317c757ffc54a452bc..
Tag the import of CK as of 21d3e319407d19dece16ee317c757ffc54a452bc.
Tue, Nov 27, 12:34 PM
marius committed rS341039: Import CK as of 21d3e319407d19dece16ee317c757ffc54a452bc, which makes its.
Import CK as of 21d3e319407d19dece16ee317c757ffc54a452bc, which makes its
Tue, Nov 27, 12:34 PM
marius committed rS341016: - Add a belated UPDATING entry for the ixlv(4) -> iavf(4) rename in r339338..
- Add a belated UPDATING entry for the ixlv(4) -> iavf(4) rename in r339338.
Tue, Nov 27, 12:11 PM

Thu, Nov 22

marius committed rS340768: MFC: r340656, MF12: r340759.
MFC: r340656, MF12: r340759
Thu, Nov 22, 4:27 PM
marius committed rS340764: MFC: r339007, r340543, r340654.
MFC: r339007, r340543, r340654
Thu, Nov 22, 1:19 PM
marius committed rS340763: MFC: r339007, r340543, r340654.
MFC: r339007, r340543, r340654
Thu, Nov 22, 1:14 PM
marius committed rS340760: MFC: r340543, r340654.
MFC: r340543, r340654
Thu, Nov 22, 1:09 PM
marius committed rS340759: MFC: r340656.
MFC: r340656
Thu, Nov 22, 1:03 PM

Wed, Nov 21

marius committed rS340743: MFC: r340495, MF12: r340739.
MFC: r340495, MF12: r340739
Wed, Nov 21, 7:49 PM
marius committed rS340741: MFC: r340495.
MFC: r340495
Wed, Nov 21, 6:54 PM
marius committed rS340740: MFC: r340495.
MFC: r340495
Wed, Nov 21, 6:53 PM
marius committed rS340739: MFC: r340495.
MFC: r340495
Wed, Nov 21, 6:53 PM

Tue, Nov 20

marius committed rS340656: Given that the idea of D15374 was to "make memmove a first class citizen",.
Given that the idea of D15374 was to "make memmove a first class citizen",
Tue, Nov 20, 12:08 AM

Mon, Nov 19

marius committed rS340654: For consistency within the front-end, prefer SDHCI_{READ,WRITE}_{2,4}().
For consistency within the front-end, prefer SDHCI_{READ,WRITE}_{2,4}()
Mon, Nov 19, 11:56 PM

Sun, Nov 18

marius abandoned D17644: Add support for AMD eMMC controller HS400 mode.

Close; obsoleted by r340543; thanks for the original patch!

Sun, Nov 18, 1:00 AM
marius commandeered D17644: Add support for AMD eMMC controller HS400 mode.
Sun, Nov 18, 12:58 AM
marius committed rS340543: Add a quirk handling for AMDI0040 controllers allowing them to do HS400..
Add a quirk handling for AMDI0040 controllers allowing them to do HS400.
Sun, Nov 18, 12:52 AM

Sat, Nov 17

marius committed rS340495: - Restore setting the clock for devices which support the default/legacy.
- Restore setting the clock for devices which support the default/legacy
Sat, Nov 17, 5:21 PM

Nov 7 2018

marius requested changes to D17865: Increase SDMA default boundary for SDHCI.

It probably makes sense and is safe to bump DMA_BLOCK_SIZE and DMA_BOUNDARY. However, in order to not waste considerable amounts of the static buffer, they should be based on MAXPHYS (which defaults to 128 KiB) as FreeBSD simply won't do transfers larger than that. The 512 KiB maximum SDMA buffer boundary also needs to be taken into account with these, though, as MAXPHYS is configurable.
That said, I'm not sure bumping DMA_BLOCK_SIZE and DMA_BOUNDARY is worth the trouble; the SDHCI controllers of the SDMA-only era are known to be very quirky, which is why sdhci(4) e. g. implements its own variant of bounce buffering in order to deal with their problematic DMA engines. So I'd rather focus on implementing support for ADMA up to 64-bit ADMA3 and be done with the limitations of SDMA on newer gear and the fallout such a bump may cause with older.

Nov 7 2018, 1:34 AM

Oct 23 2018

marius requested changes to D17644: Add support for AMD eMMC controller HS400 mode.
Oct 23 2018, 10:09 PM

Sep 13 2018

marius committed rS338638: MFC: r333614, r333647, r338275, r338280, r338513.
MFC: r333614, r333647, r338275, r338280, r338513
Sep 13 2018, 10:19 AM
marius committed rS338637: MFC: r333647, r338275, r338280, r338513.
MFC: r333647, r338275, r338280, r338513
Sep 13 2018, 10:18 AM
marius committed rS338636: MFC: r333613.
MFC: r333613
Sep 13 2018, 9:26 AM
marius committed rS338635: MFC: r338512.
MFC: r338512
Sep 13 2018, 9:20 AM
marius committed rS338634: MFC: r338261, r338512.
MFC: r338261, r338512
Sep 13 2018, 9:20 AM

Sep 6 2018

marius committed rS338513: Avoid uninitialized read of ext_csd..
Avoid uninitialized read of ext_csd.
Sep 6 2018, 9:24 PM
marius committed rS338512: - Explicitly compare a pointer to NULL. The __builtin_expect() of clang.
- Explicitly compare a pointer to NULL. The __builtin_expect() of clang
Sep 6 2018, 9:10 PM
marius committed rS338479: MFC: r338261.
MFC: r338261
Sep 6 2018, 12:25 PM
marius committed rS338477: MFC: r338304.
MFC: r338304
Sep 6 2018, 12:25 PM
marius committed rS338476: MFC: r338304.
MFC: r338304
Sep 6 2018, 12:25 PM

Aug 24 2018

marius committed rS338304: The read accessors generated by __BUS_ACCESSOR() have the problem that.
The read accessors generated by __BUS_ACCESSOR() have the problem that
Aug 24 2018, 9:08 PM

Aug 23 2018

marius committed rS338283: Following r335259, don't copy boot1 from the running system for sparc64.
Following r335259, don't copy boot1 from the running system for sparc64
Aug 23 2018, 10:57 PM
marius committed rS338280: - Use le32dec(9) for decoding EXT_CSD values where it makes sense. [1].
- Use le32dec(9) for decoding EXT_CSD values where it makes sense. [1]
Aug 23 2018, 9:27 PM
marius committed rS338275: Obtain the bus mode (MMC or SD) from the directly superordinated.
Obtain the bus mode (MMC or SD) from the directly superordinated
Aug 23 2018, 8:25 PM
marius committed rS338264: Remove a duplicated interface capability bit missed in r336313..
Remove a duplicated interface capability bit missed in r336313.
Aug 23 2018, 6:12 PM
marius committed rS338261: - According to section 2.2.5 of the SDHCI specification version 4.20,.
- According to section 2.2.5 of the SDHCI specification version 4.20,
Aug 23 2018, 5:50 PM

Aug 13 2018

marius committed rS337726: Remove the duplicated CSUM_IP6_TCP introduced in r311849 from the TX.
Remove the duplicated CSUM_IP6_TCP introduced in r311849 from the TX
Aug 13 2018, 8:30 PM

Aug 7 2018

marius committed rS337434: Update the list of architectures having atomic_fcmpset_{8,16,64}(9) and.
Update the list of architectures having atomic_fcmpset_{8,16,64}(9) and
Aug 7 2018, 6:59 PM
marius committed rS337433: Implement atomic_swap_{int,long,ptr}(9)..
Implement atomic_swap_{int,long,ptr}(9).
Aug 7 2018, 6:56 PM
marius committed rS337432: Implement atomic_swap_64(9)..
Implement atomic_swap_64(9).
Aug 7 2018, 6:56 PM

Jul 28 2018

marius committed rS336832: Implement atomic_swap_{32,64,int,long,ptr}(9)..
Implement atomic_swap_{32,64,int,long,ptr}(9).
Jul 28 2018, 3:43 PM

Jul 24 2018

marius committed rS336690: Since r336611, n is only used for INET in iflib_parse_header()..
Since r336611, n is only used for INET in iflib_parse_header().
Jul 24 2018, 11:40 PM

Jul 22 2018

marius committed rD52047: Improve the documentation of __FreeBSD_version 12000[0-3].
Improve the documentation of __FreeBSD_version 12000[0-3]
Jul 22 2018, 9:42 PM
marius committed rD52046: - Document __FreeBSD_version 120007{0,1,3}.
- Document __FreeBSD_version 120007{0,1,3}
Jul 22 2018, 9:24 PM
marius committed rS336612: Use the maximum of isc_tx_{nsegments,tso_segments_max} for MAX_TX_DESC..
Use the maximum of isc_tx_{nsegments,tso_segments_max} for MAX_TX_DESC.
Jul 22 2018, 5:51 PM
marius committed rS336611: - Given that the controlling expression of the receive loop in iflib_rxeof().
- Given that the controlling expression of the receive loop in iflib_rxeof()
Jul 22 2018, 5:46 PM
marius committed rS336610: o In em_if_update_admin_status():.
o In em_if_update_admin_status():
Jul 22 2018, 5:40 PM

Jul 18 2018

marius accepted D16300: Improve netmap TX handling when TX IRQs are not used/supported.

Looks good to me. FYI, I get:

Jul 18 2018, 5:32 PM

Jul 16 2018

marius accepted D16290: Combine VM_FREELIST_ISADMA and VM_FREELIST_LOWMEM. They are the same thing..

FYI, the few integrated ISA devices found in some sun4u and sun4v machines in fact can do 32-bit DMA so VM_FREELIST_ISADMA can go for sparc64 without a replacement, too.

Jul 16 2018, 8:18 PM
marius committed rS336356: Update igb_sctx_init for r336313, missed when incorporating shurd@'s.
Update igb_sctx_init for r336313, missed when incorporating shurd@'s
Jul 16 2018, 7:48 PM

Jul 15 2018

marius committed rS336313: Assorted TSO fixes for em(4)/iflib(9) and dead code removal:.
Assorted TSO fixes for em(4)/iflib(9) and dead code removal:
Jul 15 2018, 7:04 PM
marius closed D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).
Jul 15 2018, 7:04 PM
marius committed rS336311: Remove code to disable IFCAP_VLAN_HWFILTER by default for ixgbe(4) as VLAN.
Remove code to disable IFCAP_VLAN_HWFILTER by default for ixgbe(4) as VLAN
Jul 15 2018, 6:04 PM
marius committed rS336309: As suggested by a comment in ixl_initialize_vsi(), use if_getcapenable(9).
As suggested by a comment in ixl_initialize_vsi(), use if_getcapenable(9)
Jul 15 2018, 6:03 PM

Jul 11 2018

marius added a comment to D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).

Well, I'd prefer to also have feedback from at least shurd@ regarding bnxt(4) as I have no idea what the DMA/TSO constraints of the MACs it drives actually are (the links to the corresponding datasheets on broadcom.com are broken, unfortunately). It's rather unlikely that those DMA engines are really limited to 64 KB, i. e. BNXT_TSO_SIZE most likely only applies to TSO itself only, but you never know (I did check with the Intel datasheets for the other drivers, FWIW).

Jul 11 2018, 8:53 PM

Jun 19 2018

marius updated the diff for D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).

Extend to ixl(4)/ixlv(4) after their conversion to iflib(9) in r335338. Akin e1000,
after that conversion these drivers did redundant setup of interface capabilities in
ixl{v,}_setup_interface() and had defunct (but due to r203548 also obsolete) code
to disable IFCAP_VLAN_HWFILTER by default.

Jun 19 2018, 8:33 PM

Jun 17 2018

marius updated the diff for D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).

Okay, then let's try to handle this the right way. Changes since the
previous version of the patch:

  • Add an isc_capabilities to struct if_softc_ctx so iflib(9) can also handle interface capabilities that shouldn't be enabled by default; use that to handle default-off capabilities of e1000 and move their handling from em_setup_interface() to em_if_attach_pre() accordingly.
  • Add isc_tso_max{seg,}size DMA engine constraints for the TSO DMA tag to struct if_shared_ctx and let iflib_txsd_alloc() automatically adjust the maxsize of that tag in case IFCAP_VLAN_MTU is supported.
  • Move the if_setifheaderlen(9) call for adjusting the maximum Ethernet header length from {ixgbe,ixv,em}_setup_interface() to iflib(9) so adjustment is automatically done in case IFCAP_VLAN_MTU is supported. As a consequence, this adjustment now is also done in case of bnxt(4) which missed it previously.
  • Remove code to disable IFCAP_VLAN_HWFILTER by default for ixgbe(4) (already not done for ixgbev(4)) as VLAN events are now passed through by lagg(4) since r203548.
  • Don't bother to fiddle with IFCAP_HWSTATS in ixgbe(4)/ixgbev(4) as iflib(9) adds that capability unconditionally.
  • Bump __FreeBSD_version for the above changes as modules using iflib(9) need to be recompiled.
Jun 17 2018, 9:32 PM
marius committed rS335303: Assorted fixes to MSI-X/MSI/INTx setup in iflib(9):.
Assorted fixes to MSI-X/MSI/INTx setup in iflib(9):
Jun 17 2018, 8:33 PM
marius closed D15729: Assorted fixes to MSI-X/MSI/INTx setup iflib(9).
Jun 17 2018, 8:33 PM

Jun 13 2018

marius committed rP472345: Update to 1.2.4, which is mostly a maintainance release and allows to get.
Update to 1.2.4, which is mostly a maintainance release and allows to get
Jun 13 2018, 9:40 PM
marius updated the diff for D15729: Assorted fixes to MSI-X/MSI/INTx setup iflib(9).

Same diff, more context

Jun 13 2018, 9:54 AM

Jun 11 2018

marius added a comment to D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).

The problem with letting iflib(9) automatically register a TSO DMA tag with a maxsize of isc_tx_tso_size_max + sizeof(struct ether_vlan_header) if the front-end driver declares IFCAP_VLAN_MTU as being supported is that besides a MAC having a restriction on the maximum TSO size, its DMA engine might have a restriction on the maximum transfer size as well (in fact, that's what the maxsize DMA tag parameter is all about). Suppose a MAC supports a maximum TSO size of 64 KB and its DMA engine has a 64 KB limit on transfers as well, one wouldn't be able to support a maximum TSO size of IP_MAXPACKET when doing software VLAN tagging. Actually, that's why I've added you as a reviewer because I don't have a datasheet for the bnxt(4)-driven MACs.

Jun 11 2018, 7:00 PM

Jun 10 2018

marius added a reviewer for D15729: Assorted fixes to MSI-X/MSI/INTx setup iflib(9): mmacy.
Jun 10 2018, 12:47 PM
marius created D15729: Assorted fixes to MSI-X/MSI/INTx setup iflib(9).
Jun 10 2018, 3:14 AM

Jun 9 2018

marius created D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).
Jun 9 2018, 7:52 PM

Jun 7 2018

marius committed rS334805: - Once we have shifted arguments up to thrice, base-bits-dir is $1 rather.
- Once we have shifted arguments up to thrice, base-bits-dir is $1 rather
Jun 7 2018, 6:24 PM
marius committed rS334789: MFC: r334443 (by cem@) MF stable/11: r334787.
MFC: r334443 (by cem@) MF stable/11: r334787
Jun 7 2018, 3:51 PM
marius committed rS334787: MFC: r334443 (by cem@).
MFC: r334443 (by cem@)
Jun 7 2018, 3:04 PM

May 31 2018

marius committed rS334457: Akin r302691 in head, synchronize the build stripping for the disc1.
Akin r302691 in head, synchronize the build stripping for the disc1
May 31 2018, 11:48 PM
marius committed rS334453: MFC: r327364, r334293.
MFC: r327364, r334293
May 31 2018, 10:20 PM

May 28 2018

marius committed rS334293: Describe Fresco Logic FL1100 USB 3.0 controllers..
Describe Fresco Logic FL1100 USB 3.0 controllers.
May 28 2018, 7:56 PM

May 24 2018

marius committed rS334191: MFC: r333955.
MFC: r333955
May 24 2018, 11:11 PM

May 21 2018

marius committed rS333955: - Unbreak booting sparc64 kernels after the metadata unification in.
- Unbreak booting sparc64 kernels after the metadata unification in
May 21 2018, 1:20 AM

May 20 2018

marius committed rP470438: - Update to 3.02a09.
- Update to 3.02a09
May 20 2018, 12:34 AM

May 17 2018

marius committed rS333770: MFC: r333600 (phil).
MFC: r333600 (phil)
May 17 2018, 9:49 PM
marius committed rS333768: MFC: r333614.
MFC: r333614
May 17 2018, 9:23 PM
marius committed rS333767: MFC: r333613.
MFC: r333613
May 17 2018, 9:22 PM

May 15 2018

marius committed rS333647: - If present, take advantage of the R/W cache of eMMC revision 1.5 and.
- If present, take advantage of the R/W cache of eMMC revision 1.5 and
May 15 2018, 9:15 PM
marius committed rS333646: Restore style(9) conformance after r320844 (actually requested pre-.
Restore style(9) conformance after r320844 (actually requested pre-
May 15 2018, 9:07 PM

May 14 2018

marius committed rS333614: Let mmcsd_ioctl() ensure appropriate privileges via priv_check(9)..
Let mmcsd_ioctl() ensure appropriate privileges via priv_check(9).
May 14 2018, 9:57 PM
marius committed rS333613: The broken DDR52 support of Intel Bay Trail eMMC controllers rumored.
The broken DDR52 support of Intel Bay Trail eMMC controllers rumored
May 14 2018, 9:46 PM

May 13 2018

marius committed rP469803: Update to mmc-utils as of 20180327, fixing an ENH_START_ADDR conversion.
Update to mmc-utils as of 20180327, fixing an ENH_START_ADDR conversion
May 13 2018, 3:35 PM

May 12 2018

marius requested changes to D15374: Various rearrangements to make memmove a first class citizen.

Generally looks good for the sparc64 part, for consistency with the existing style it would be preferable to use the next free input register after those used for the arguments for the newly needed temporary register, i. e. o3 instead of o6, though.
However, given that the idea is to make "memmove a first class citizen", it seems backwards to inflict memmove with extra MOVs, and bcopy likely never can actually go away. So I'd rather convert the existing bcopy implementation into a _MEMMOVE macro similar to the existing _MEM{CPY,SET} ones (but without the ASI support of these latter) and use _MEMMOVE to implement both bcopy and memmove, which could be done in a separate change, though.

May 12 2018, 11:28 PM

May 3 2018

marius accepted D15190: Report TRAP_BRKPT for breakpoint traps on sparc64..
May 3 2018, 9:40 PM
marius committed rS333215: MFC: r330803.
MFC: r330803
May 3 2018, 3:47 PM
marius committed rS333216: MFC: r330803.
MFC: r330803
May 3 2018, 3:47 PM
marius committed rS333214: MFC: r327312, r327842, r327865.
MFC: r327312, r327842, r327865
May 3 2018, 3:41 PM
marius committed rS333213: MFC: r327312, r327842, r327865.
MFC: r327312, r327842, r327865
May 3 2018, 3:41 PM

Mar 19 2018

marius committed rS331206: MFC: r328834.
MFC: r328834
Mar 19 2018, 2:29 PM
marius committed rS331205: MFC: r328834.
MFC: r328834
Mar 19 2018, 2:28 PM

Mar 17 2018

marius added inline comments to D14712: Remove Giant from init creation and vfs_mountroot..
Mar 17 2018, 6:13 PM
marius accepted D14712: Remove Giant from init creation and vfs_mountroot..
Mar 17 2018, 5:51 PM
marius added inline comments to D14712: Remove Giant from init creation and vfs_mountroot..
Mar 17 2018, 5:39 PM
marius requested changes to D14712: Remove Giant from init creation and vfs_mountroot..
Mar 17 2018, 4:11 PM
marius added inline comments to D14712: Remove Giant from init creation and vfs_mountroot..
Mar 17 2018, 3:38 PM