Page MenuHomeFreeBSD

marius (Marius Strobl)
User

Projects

User Details

User Since
Jun 3 2014, 3:27 PM (245 w, 5 d)

Recent Activity

Thu, Feb 14

marius accepted D19201: iflib: Return the correct filter result in the interrupt handler..
Thu, Feb 14, 11:15 PM
marius requested changes to D19201: iflib: Return the correct filter result in the interrupt handler..
Thu, Feb 14, 10:04 PM
marius requested changes to D19201: iflib: Return the correct filter result in the interrupt handler..

Returning FILTER_SCHEDULE_THREAD from iflib_fast_intr_{ctx,rxtx}()
is still wrong as iflib_irq_alloc_generic() doesn't register a handler that could
be scheduled.

Thu, Feb 14, 9:43 PM
marius requested changes to D19201: iflib: Return the correct filter result in the interrupt handler..

I second Andrew; using FILTER_STRAY in case of !iflib_started is a good move,
but returning FILTER_SCHEDULE_THREAD from the filter registered via
bus_setup_intr(9) is wrong at least when done unconditionally. The latter
signals intr_event_handle() to schedule an ithread for running the handler
registered via bus_setup_intr(9), but currently neither iflib(4) nor its
consumers appear to actually register a handler. The better change in that
regard probably is to remove support for handlers from _iflib_irq_alloc() and
iflib_irq_alloc() as the approach taken by iflib(4) apparently is to schedule a
gtask by itself (rather than letting intr_event_handle() schedule an ithread) if
there's no ifi filter or the ifi filter doesn't fully handle a particular interrupt,
i. e. the ifi filter returns the somewhat abused FILTER_SCHEDULE_THREAD.
Maybe iflib_irq_alloc() should be even removed completely as its currently
unused and if a driver wants to do something fancy with an interrupt outside
of the design of iflib(4), that driver is better off setting up that interrupt entirely
by itself.

Thu, Feb 14, 9:09 PM

Wed, Feb 13

marius committed rS344105: MFC: r343372.
MFC: r343372
Wed, Feb 13, 4:03 PM
marius committed rS344104: MFC: r343372.
MFC: r343372
Wed, Feb 13, 4:03 PM
marius committed rS344102: MFC: r339459.
MFC: r339459
Wed, Feb 13, 3:30 PM
marius committed rS344101: MFC: r343622.
MFC: r343622
Wed, Feb 13, 3:27 PM
marius committed rS344100: MFC: r343621.
MFC: r343621
Wed, Feb 13, 3:19 PM
marius committed rS344098: MFC: r343934.
MFC: r343934
Wed, Feb 13, 2:39 PM
marius committed rS344097: MFC: r343369.
MFC: r343369
Wed, Feb 13, 2:36 PM
marius committed rS344095: MFC: r343203.
MFC: r343203
Wed, Feb 13, 2:28 PM
marius committed rS344094: MFC: r343203.
MFC: r343203
Wed, Feb 13, 2:28 PM
marius committed rS344093: MFC: r333879, r342749.
MFC: r333879, r342749
Wed, Feb 13, 2:25 PM
marius committed rS344092: MFC: r342749.
MFC: r342749
Wed, Feb 13, 1:09 PM
marius committed rD52816: Document __FreeBSD_version 1300011 and 1300012..
Document __FreeBSD_version 1300011 and 1300012.
Wed, Feb 13, 11:27 AM

Tue, Feb 12

marius committed rS344069: With r344062 in place, hwpmc_mod.c generally needs bus_if.h and.
With r344062 in place, hwpmc_mod.c generally needs bus_if.h and
Tue, Feb 12, 11:39 PM
marius committed rS344064: Fix the build with ALTQ after r344060..
Fix the build with ALTQ after r344060.
Tue, Feb 12, 10:33 PM
marius committed rS344062: Make taskqgroup_attach{,_cpu}(9) work across architectures.
Make taskqgroup_attach{,_cpu}(9) work across architectures
Tue, Feb 12, 9:24 PM
marius closed D19139: Make taskqgroup_attach{,_cpu}(9) work across architectures.
Tue, Feb 12, 9:24 PM
marius committed rS344060: Further correct and optimize the bus_dma(9) usage of iflib(4):.
Further correct and optimize the bus_dma(9) usage of iflib(4):
Tue, Feb 12, 9:09 PM
marius closed D19081: Further correct and optimize the bus_dma(9) usage of iflib(4).
Tue, Feb 12, 9:09 PM

Sun, Feb 10

marius updated the summary of D19139: Make taskqgroup_attach{,_cpu}(9) work across architectures.
Sun, Feb 10, 9:58 PM
marius committed rS343979: As struct cryptop is wrapped in #ifdef _KERNEL, userland doesn't.
As struct cryptop is wrapped in #ifdef _KERNEL, userland doesn't
Sun, Feb 10, 9:27 PM
marius created D19139: Make taskqgroup_attach{,_cpu}(9) work across architectures.
Sun, Feb 10, 9:23 PM

Sat, Feb 9

marius committed rS343934: - Remove the redundant device disabled hint handling; ever since.
- Remove the redundant device disabled hint handling; ever since
Sat, Feb 9, 11:59 AM
marius closed D19108: Assorted fixes and cleanup for em(4).
Sat, Feb 9, 11:59 AM
marius committed rS343933: MFC: r343753.
MFC: r343753
Sat, Feb 9, 11:52 AM
marius committed rS343932: MFC: r343288.
MFC: r343288
Sat, Feb 9, 11:49 AM

Fri, Feb 8

marius updated the summary of D19108: Assorted fixes and cleanup for em(4).
Fri, Feb 8, 9:50 AM
marius updated the diff for D19108: Assorted fixes and cleanup for em(4).

Bring back additional function descriptions lost, adjust some others and INIT_DEBUGOUT() invocations to match reality after the iflib(4) conversion.

Fri, Feb 8, 9:46 AM

Thu, Feb 7

marius added inline comments to D19108: Assorted fixes and cleanup for em(4).
Thu, Feb 7, 10:14 PM
marius updated the diff for D19108: Assorted fixes and cleanup for em(4).

Improved em_if_timer() and em_if_watchdog_reset() descriptions, brought back the right one for lem_smartspeed() from prior to the iflib(4) conversion.

Thu, Feb 7, 10:13 PM
marius updated the summary of D19108: Assorted fixes and cleanup for em(4).
Thu, Feb 7, 3:35 PM
marius updated the summary of D19108: Assorted fixes and cleanup for em(4).
Thu, Feb 7, 3:33 PM
marius created D19108: Assorted fixes and cleanup for em(4).
Thu, Feb 7, 3:30 PM
marius committed rS343864: MFC: r343578 (partial).
MFC: r343578 (partial)
Thu, Feb 7, 10:30 AM

Tue, Feb 5

marius updated the summary of D19081: Further correct and optimize the bus_dma(9) usage of iflib(4).
Tue, Feb 5, 8:36 AM
marius updated the summary of D19081: Further correct and optimize the bus_dma(9) usage of iflib(4).
Tue, Feb 5, 8:29 AM
marius created D19081: Further correct and optimize the bus_dma(9) usage of iflib(4).
Tue, Feb 5, 12:07 AM

Mon, Feb 4

marius committed rS343753: o As illustrated by e. g. figure 7-14 of the Intel 82599 10 GbE.
o As illustrated by e. g. figure 7-14 of the Intel 82599 10 GbE
Mon, Feb 4, 8:47 PM
marius closed D19067: Change iflib(4) to employ the usual convention of "descriptor".
Mon, Feb 4, 8:47 PM
marius updated the diff for D19067: Change iflib(4) to employ the usual convention of "descriptor".

Fixed a typo (RX vs. TX) in one of the messages altered by the previous patch

Mon, Feb 4, 2:00 PM

Sun, Feb 3

marius accepted D19070: Fix em(4) tx interrupt routing.
Sun, Feb 3, 7:48 AM

Sat, Feb 2

marius updated the summary of D19067: Change iflib(4) to employ the usual convention of "descriptor".
Sat, Feb 2, 7:47 PM
marius created D19067: Change iflib(4) to employ the usual convention of "descriptor".
Sat, Feb 2, 7:44 PM

Thu, Jan 31

marius added a comment to D19041: Make iflib a loadable module..

Well, as-is iflib(4) in fact is PCI-specific.

Thu, Jan 31, 7:15 PM
marius accepted D19041: Make iflib a loadable module..

Well, I would just have went with "PCI" but if you prefer to state all variants :)

Thu, Jan 31, 6:03 PM
marius requested changes to D19041: Make iflib a loadable module..

sys/dev/ixgbe/if_ixv.c appears to be missing a "MODULE_DEPEND(ixv, iflib, 1, 1, 1);" but while you are at it, you could remove its netmap dependency (now already provided by iflib.c) instead

Thu, Jan 31, 10:19 AM

Wed, Jan 30

marius committed rS343578: - Stop iflib(4) from leaking MSI messages on detachment by calling.
- Stop iflib(4) from leaking MSI messages on detachment by calling
Wed, Jan 30, 1:21 PM
marius closed D18980: Stop iflib(4) from leaking MSI messages and along with drivers let it use the correct RIDs when releasing resources.
Wed, Jan 30, 1:21 PM
marius committed rS343575: MFC: r343481.
MFC: r343481
Wed, Jan 30, 11:56 AM

Tue, Jan 29

marius added a comment to D18980: Stop iflib(4) from leaking MSI messages and along with drivers let it use the correct RIDs when releasing resources.

Yes, as the manpage for the bus_release_resource(9) family of functions says: "The bus methods are free to change the RIDs that they are given as a parameter. You must not depend on the value you gave it earlier." On way do deal with that is to cache the returned RID in e. g. the softc. As is, em(4) does that for adapter->ioport via adapter->io_rid, but not for the adapter->flash and adapter->memory resources. The summary doesn't state this correctly, sorry, I'll address that when committing.

Tue, Jan 29, 8:03 PM

Mon, Jan 28

marius added inline comments to D18980: Stop iflib(4) from leaking MSI messages and along with drivers let it use the correct RIDs when releasing resources.
Mon, Jan 28, 10:20 PM
marius updated the diff for D18980: Stop iflib(4) from leaking MSI messages and along with drivers let it use the correct RIDs when releasing resources.
Mon, Jan 28, 10:19 PM

Sun, Jan 27

marius committed rS343505: MFC: r342634 (partial).
MFC: r342634 (partial)
Sun, Jan 27, 7:05 PM
marius committed rS343504: MFC: r342634 (partial).
MFC: r342634 (partial)
Sun, Jan 27, 7:04 PM
marius committed rS343503: MFC: r342634.
MFC: r342634
Sun, Jan 27, 7:04 PM
marius committed rS343494: MFC: r333745, r333764, r337533, r339375, r341041.
MFC: r333745, r333764, r337533, r339375, r341041
Sun, Jan 27, 2:36 PM

Sat, Jan 26

marius committed rS343481: - In _iflib_fl_refill(), don't mark an RX buffer as available in the.
- In _iflib_fl_refill(), don't mark an RX buffer as available in the
Sat, Jan 26, 9:35 PM
marius created D18980: Stop iflib(4) from leaking MSI messages and along with drivers let it use the correct RIDs when releasing resources.
Sat, Jan 26, 1:51 PM

Jan 5 2019

marius committed rS342790: MFC: r336610 (partial), r339207, r339267.
MFC: r336610 (partial), r339207, r339267
Jan 5 2019, 7:35 PM
marius committed rS342789: MFC: r336610 (partial), r339207, r339267.
MFC: r336610 (partial), r339207, r339267
Jan 5 2019, 7:33 PM
marius abandoned D17865: Increase SDMA default boundary for SDHCI.

Close; obsoleted by r342634.

Jan 5 2019, 2:29 PM
marius commandeered D17865: Increase SDMA default boundary for SDHCI.
Jan 5 2019, 2:28 PM

Dec 30 2018

marius committed rS342634: o Don't allocate resources for SDMA in sdhci(4) if the controller or the.
o Don't allocate resources for SDMA in sdhci(4) if the controller or the
Dec 30 2018, 11:08 PM

Nov 29 2018

marius committed rS341267: MFV: r341039, MFC: r341041, MF12: r341264.
MFV: r341039, MFC: r341041, MF12: r341264
Nov 29 2018, 10:02 PM
marius committed rS341266: MFC: r341016, MF12: r341261.
MFC: r341016, MF12: r341261
Nov 29 2018, 10:01 PM
marius committed rS341264: MFV: r341039, MFC: r341041.
MFV: r341039, MFC: r341041
Nov 29 2018, 9:12 PM
marius committed rS341261: MFC: r341016.
MFC: r341016
Nov 29 2018, 8:51 PM

Nov 27 2018

marius committed rS341041: Import CK as of 21d3e319407d19dece16ee317c757ffc54a452bc, which makes its.
Import CK as of 21d3e319407d19dece16ee317c757ffc54a452bc, which makes its
Nov 27 2018, 12:37 PM
marius committed rS341040: Tag the import of CK as of 21d3e319407d19dece16ee317c757ffc54a452bc..
Tag the import of CK as of 21d3e319407d19dece16ee317c757ffc54a452bc.
Nov 27 2018, 12:34 PM
marius committed rS341039: Import CK as of 21d3e319407d19dece16ee317c757ffc54a452bc, which makes its.
Import CK as of 21d3e319407d19dece16ee317c757ffc54a452bc, which makes its
Nov 27 2018, 12:34 PM
marius committed rS341016: - Add a belated UPDATING entry for the ixlv(4) -> iavf(4) rename in r339338..
- Add a belated UPDATING entry for the ixlv(4) -> iavf(4) rename in r339338.
Nov 27 2018, 12:11 PM

Nov 22 2018

marius committed rS340768: MFC: r340656, MF12: r340759.
MFC: r340656, MF12: r340759
Nov 22 2018, 4:27 PM
marius committed rS340764: MFC: r339007, r340543, r340654.
MFC: r339007, r340543, r340654
Nov 22 2018, 1:19 PM
marius committed rS340763: MFC: r339007, r340543, r340654.
MFC: r339007, r340543, r340654
Nov 22 2018, 1:14 PM
marius committed rS340760: MFC: r340543, r340654.
MFC: r340543, r340654
Nov 22 2018, 1:09 PM
marius committed rS340759: MFC: r340656.
MFC: r340656
Nov 22 2018, 1:03 PM

Nov 21 2018

marius committed rS340743: MFC: r340495, MF12: r340739.
MFC: r340495, MF12: r340739
Nov 21 2018, 7:49 PM
marius committed rS340741: MFC: r340495.
MFC: r340495
Nov 21 2018, 6:54 PM
marius committed rS340740: MFC: r340495.
MFC: r340495
Nov 21 2018, 6:53 PM
marius committed rS340739: MFC: r340495.
MFC: r340495
Nov 21 2018, 6:53 PM

Nov 20 2018

marius committed rS340656: Given that the idea of D15374 was to "make memmove a first class citizen",.
Given that the idea of D15374 was to "make memmove a first class citizen",
Nov 20 2018, 12:08 AM

Nov 19 2018

marius committed rS340654: For consistency within the front-end, prefer SDHCI_{READ,WRITE}_{2,4}().
For consistency within the front-end, prefer SDHCI_{READ,WRITE}_{2,4}()
Nov 19 2018, 11:56 PM

Nov 18 2018

marius abandoned D17644: Add support for AMD eMMC controller HS400 mode.

Close; obsoleted by r340543; thanks for the original patch!

Nov 18 2018, 1:00 AM
marius commandeered D17644: Add support for AMD eMMC controller HS400 mode.
Nov 18 2018, 12:58 AM
marius committed rS340543: Add a quirk handling for AMDI0040 controllers allowing them to do HS400..
Add a quirk handling for AMDI0040 controllers allowing them to do HS400.
Nov 18 2018, 12:52 AM

Nov 17 2018

marius committed rS340495: - Restore setting the clock for devices which support the default/legacy.
- Restore setting the clock for devices which support the default/legacy
Nov 17 2018, 5:21 PM

Nov 7 2018

marius requested changes to D17865: Increase SDMA default boundary for SDHCI.

It probably makes sense and is safe to bump DMA_BLOCK_SIZE and DMA_BOUNDARY. However, in order to not waste considerable amounts of the static buffer, they should be based on MAXPHYS (which defaults to 128 KiB) as FreeBSD simply won't do transfers larger than that. The 512 KiB maximum SDMA buffer boundary also needs to be taken into account with these, though, as MAXPHYS is configurable.
That said, I'm not sure bumping DMA_BLOCK_SIZE and DMA_BOUNDARY is worth the trouble; the SDHCI controllers of the SDMA-only era are known to be very quirky, which is why sdhci(4) e. g. implements its own variant of bounce buffering in order to deal with their problematic DMA engines. So I'd rather focus on implementing support for ADMA up to 64-bit ADMA3 and be done with the limitations of SDMA on newer gear and the fallout such a bump may cause with older.

Nov 7 2018, 1:34 AM

Oct 23 2018

marius requested changes to D17644: Add support for AMD eMMC controller HS400 mode.
Oct 23 2018, 10:09 PM

Sep 13 2018

marius committed rS338638: MFC: r333614, r333647, r338275, r338280, r338513.
MFC: r333614, r333647, r338275, r338280, r338513
Sep 13 2018, 10:19 AM
marius committed rS338637: MFC: r333647, r338275, r338280, r338513.
MFC: r333647, r338275, r338280, r338513
Sep 13 2018, 10:18 AM
marius committed rS338636: MFC: r333613.
MFC: r333613
Sep 13 2018, 9:26 AM
marius committed rS338635: MFC: r338512.
MFC: r338512
Sep 13 2018, 9:20 AM
marius committed rS338634: MFC: r338261, r338512.
MFC: r338261, r338512
Sep 13 2018, 9:20 AM

Sep 6 2018

marius committed rS338513: Avoid uninitialized read of ext_csd..
Avoid uninitialized read of ext_csd.
Sep 6 2018, 9:24 PM
marius committed rS338512: - Explicitly compare a pointer to NULL. The __builtin_expect() of clang.
- Explicitly compare a pointer to NULL. The __builtin_expect() of clang
Sep 6 2018, 9:10 PM
marius committed rS338479: MFC: r338261.
MFC: r338261
Sep 6 2018, 12:25 PM
marius committed rS338477: MFC: r338304.
MFC: r338304
Sep 6 2018, 12:25 PM