Page MenuHomeFreeBSD

marius (Marius Strobl)
User

Projects

User Details

User Since
Jun 3 2014, 3:27 PM (351 w, 4 d)

Recent Activity

Jan 27 2021

marius committed R10:c262e8e87e7b: e1000: fix build after c1655b0f (authored by marius).
e1000: fix build after c1655b0f
Jan 27 2021, 2:31 PM

Jan 26 2021

marius committed R10:7a731da592fa: rc.conf(5): regenerate after WITHOUT_NDIS removal (authored by marius).
rc.conf(5): regenerate after WITHOUT_NDIS removal
Jan 26 2021, 10:11 PM
marius committed R10:173f6ce152ce: KDB: remove obsolete KDB_WHY_NDIS (authored by marius).
KDB: remove obsolete KDB_WHY_NDIS
Jan 26 2021, 10:11 PM
marius committed R10:84876bf70222: build: remove NDIS option (authored by marius).
build: remove NDIS option
Jan 26 2021, 10:11 PM
marius committed R10:c1655b0f8998: e1000: consistently use the hw variables (authored by marius).
e1000: consistently use the hw variables
Jan 26 2021, 10:10 PM
marius committed R10:f39b49969ac4: man: remove stale references to ndis(4) (authored by marius).
man: remove stale references to ndis(4)
Jan 26 2021, 10:10 PM

Jan 21 2021

marius committed R10:679e4cdabdc5: kvprintf(9): add missing FALLTHROUGH (authored by marius).
kvprintf(9): add missing FALLTHROUGH
Jan 21 2021, 11:21 PM
marius committed R10:3b433ed76500: mmcsd(4): properly set BIO error when partition switching fails (authored by marius).
mmcsd(4): properly set BIO error when partition switching fails
Jan 21 2021, 11:21 PM
marius committed R10:2dcbf0462e17: sym(4): handle mixed tagged/untagged commands gracefully (authored by marius).
sym(4): handle mixed tagged/untagged commands gracefully
Jan 21 2021, 11:21 PM
marius committed R10:e60a0db3b8c9: sym(4): fix nits reported by Coverity (authored by marius).
sym(4): fix nits reported by Coverity
Jan 21 2021, 11:21 PM
marius committed R10:c62ee7332e4d: fb_if: remove unused method (authored by marius).
fb_if: remove unused method
Jan 21 2021, 11:21 PM
marius committed R10:b2a29e5f8319: boot_font(4): remove obsolete font (authored by marius).
boot_font(4): remove obsolete font
Jan 21 2021, 11:21 PM

Jan 16 2021

marius committed R10:944041f936a6: wl(4): remove obsolete header (authored by marius).
wl(4): remove obsolete header
Jan 16 2021, 11:05 PM
marius added a reverting change for R10:702547720ca0: Remove sparc64 specific bits of the man pages.: R10:0cdfc338053b: man4: bring back ofw_console.4 and openfirm.4.
Jan 16 2021, 10:55 PM
marius committed R10:0cdfc338053b: man4: bring back ofw_console.4 and openfirm.4 (authored by marius).
man4: bring back ofw_console.4 and openfirm.4
Jan 16 2021, 10:55 PM
marius committed R10:daad26e5fc25: openpromio(4): remove obsolete pseudo device driver (authored by marius).
openpromio(4): remove obsolete pseudo device driver
Jan 16 2021, 10:55 PM
marius committed R10:145f01a3dfcb: kerneldoc: remove Doxyfile for cmx(4) (authored by marius).
kerneldoc: remove Doxyfile for cmx(4)
Jan 16 2021, 10:55 PM
marius committed R10:ee7231c92936: targets: no longer depend on bt3cfw(8) (authored by marius).
targets: no longer depend on bt3cfw(8)
Jan 16 2021, 10:55 PM
marius committed R10:33b486472ebd: bluetooth: remove support for bt3c(4) (authored by marius).
bluetooth: remove support for bt3c(4)
Jan 16 2021, 10:55 PM
marius committed R10:bb34c6390538: bluetooth.device.conf.5/netgraph.4: remove reference to ng_bt3c(4) (authored by marius).
bluetooth.device.conf.5/netgraph.4: remove reference to ng_bt3c(4)
Jan 16 2021, 10:55 PM
marius committed R10:f83a5c238240: hier.7/wlan.4: remove reference to wi(4) (authored by marius).
hier.7/wlan.4: remove reference to wi(4)
Jan 16 2021, 10:54 PM
marius committed R10:d65427ad582c: sym(4): Remove remainder of SYM_SETUP_LP_PROBE_MAP support (authored by marius).
sym(4): Remove remainder of SYM_SETUP_LP_PROBE_MAP support
Jan 16 2021, 10:54 PM

Dec 27 2020

marius committed rP559370: - Update to mmc-utils as of 20191004, for the most part bringing only.
- Update to mmc-utils as of 20191004, for the most part bringing only
Dec 27 2020, 4:34 PM

Dec 26 2020

marius committed R10:180439a1731a: sym.4: Remove remainder of SYM_SETUP_LP_PROBE_MAP documentation (authored by marius).
sym.4: Remove remainder of SYM_SETUP_LP_PROBE_MAP documentation
Dec 26 2020, 10:22 PM
marius committed R10:2f00fe725b7a: nsphy(4): Remove obsolete support for pcn(4) (authored by marius).
nsphy(4): Remove obsolete support for pcn(4)
Dec 26 2020, 6:42 PM
marius committed R10:e51ed06ae157: mlphy(4)/tlphy(4): Remove obsolete drivers (authored by marius).
mlphy(4)/tlphy(4): Remove obsolete drivers
Dec 26 2020, 6:42 PM
marius committed R10:bc4fc770af61: man4: remove references to gone eeprom(8) and obsolete devices (authored by marius).
man4: remove references to gone eeprom(8) and obsolete devices
Dec 26 2020, 3:41 PM
marius committed R10:942c6b98db27: esp.4: Remove references to Sun devices (authored by marius).
esp.4: Remove references to Sun devices
Dec 26 2020, 3:41 PM
marius committed R10:8a154a4f025b: pcm.4: remove reference to snd_audiocs(4) (authored by marius).
pcm.4: remove reference to snd_audiocs(4)
Dec 26 2020, 3:40 PM
marius committed R10:23af96ad2220: man4: remove references to drivers deorbited as part of FCP-101 (authored by marius).
man4: remove references to drivers deorbited as part of FCP-101
Dec 26 2020, 3:40 PM
marius committed R10:b63eeef41f93: scc(4)/uart(4): Remove obsolete support for Siemens SAB 82532 (authored by marius).
scc(4)/uart(4): Remove obsolete support for Siemens SAB 82532
Dec 26 2020, 12:53 PM
marius committed R10:863de60ebc3c: scc.4: Add Freescale/NXP QUICC to the list of supported controllers (authored by marius).
scc.4: Add Freescale/NXP QUICC to the list of supported controllers
Dec 26 2020, 12:53 PM

Dec 25 2020

marius committed R10:261295ba4c8f: fwohci.4: Bump .Dd (authored by marius).
fwohci.4: Bump .Dd
Dec 25 2020, 9:29 PM
marius committed R10:f18782e49aa4: ohci.4: Bump .Dd (authored by marius).
ohci.4: Bump .Dd
Dec 25 2020, 9:29 PM
marius committed R10:eae35125e948: ada(4): remove remainder of MD geometry translation support (authored by marius).
ada(4): remove remainder of MD geometry translation support
Dec 25 2020, 7:31 PM
marius committed R10:6535f188f1df: bge(4): remove obsolete support for on-board Fujitsu and Sun MACs (authored by marius).
bge(4): remove obsolete support for on-board Fujitsu and Sun MACs
Dec 25 2020, 7:31 PM
marius committed R10:b58c853edffc: rtld-elf(1): remove obsolete pre_init() hook (authored by marius).
rtld-elf(1): remove obsolete pre_init() hook
Dec 25 2020, 7:31 PM
marius committed R10:50d823d5b8b6: fwohci(4): remove support for Sun PCIO-2 FireWire controllers (authored by marius).
fwohci(4): remove support for Sun PCIO-2 FireWire controllers
Dec 25 2020, 7:30 PM
marius committed R10:5db1ed2f332f: ohci(4): remove support for Sun PCIO-2 USB controllers (authored by marius).
ohci(4): remove support for Sun PCIO-2 USB controllers
Dec 25 2020, 7:30 PM
marius committed R10:28ca6c20cf72: gallant12x22(4): remove obsolete font (authored by marius).
gallant12x22(4): remove obsolete font
Dec 25 2020, 7:30 PM
marius committed R10:9cca83b6dba1: mk48txx(4): remove obsolete driver (authored by marius).
mk48txx(4): remove obsolete driver
Dec 25 2020, 7:30 PM
marius committed R10:d141239c56ae: mc146818(4): remove obsolete driver (authored by marius).
mc146818(4): remove obsolete driver
Dec 25 2020, 7:30 PM
marius committed R10:5731987b71d0: mips: fix build w/ TICK_USE_MALTA_RTC defined (authored by marius).
mips: fix build w/ TICK_USE_MALTA_RTC defined
Dec 25 2020, 7:29 PM

Dec 13 2020

marius committed R9:4c1feff6db15: Add my entity. (authored by marius).
Add my entity.
Dec 13 2020, 6:48 PM
marius committed R9:cee9022869cd: Move me from contributors to developers. (authored by marius).
Move me from contributors to developers.
Dec 13 2020, 6:48 PM
marius committed R9:95e90df74e11: Announce myself as a new committer. (authored by marius).
Announce myself as a new committer.
Dec 13 2020, 6:48 PM
marius committed R9:aa6f2cff760b: Document __FreeBSD_version 600013. (authored by marius).
Document __FreeBSD_version 600013.
Dec 13 2020, 6:33 PM
marius committed R9:943097dcf490: Document __FreeBSD_version 503103. (authored by marius).
Document __FreeBSD_version 503103.
Dec 13 2020, 6:33 PM
marius committed R9:ae36772251ab: Add an entry for le(4). (authored by marius).
Add an entry for le(4).
Dec 13 2020, 6:12 PM
marius committed R9:2aed1598a4c4: Sync the hardware list with reality, mainly regarding support of (authored by marius).
Sync the hardware list with reality, mainly regarding support of
Dec 13 2020, 6:04 PM
marius committed R9:07874f22e844: - Update the list of known-working machines based on feedback for 7.2. (authored by marius).
- Update the list of known-working machines based on feedback for 7.2.
Dec 13 2020, 5:59 PM
marius committed R9:7850e192f0cd: Document __FreeBSD_version 700053. (authored by marius).
Document __FreeBSD_version 700053.
Dec 13 2020, 5:59 PM
marius committed R9:7bcd1a3b2358: Document __FreeBSD_version 800003. (authored by marius).
Document __FreeBSD_version 800003.
Dec 13 2020, 5:58 PM
marius committed R9:15a3ac7cd881: - Document __FreeBSD_version 700055. (authored by marius).
- Document __FreeBSD_version 700055.
Dec 13 2020, 5:58 PM
marius committed R9:26df12670fa2: Add my key. (authored by marius).
Add my key.
Dec 13 2020, 5:57 PM
marius committed R9:a3ea4409423c: - Move Sun Fire V240 to the list of known working machines. (authored by marius).
- Move Sun Fire V240 to the list of known working machines.
Dec 13 2020, 5:48 PM
marius committed R9:399b06549322: Add HappaBSD Regensburg. (authored by marius).
Add HappaBSD Regensburg.
Dec 13 2020, 5:39 PM
marius committed R9:442b9fd695a1: Actually use the fixed version from blackend for the HappaBSD entry. (authored by marius).
Actually use the fixed version from blackend for the HappaBSD entry.
Dec 13 2020, 5:39 PM
marius committed R9:0f0a8dd50593: Update the sparc64 hardware list regarding machines that will be supported (authored by marius).
Update the sparc64 hardware list regarding machines that will be supported
Dec 13 2020, 5:35 PM
marius committed R9:a38896ba61b6: Update the sparc64 hardware list regarding machines that will be supported (authored by marius).
Update the sparc64 hardware list regarding machines that will be supported
Dec 13 2020, 5:32 PM
marius committed R9:042100ef38ab: Add trademark entities for Fujitsu Limited and update those of SPARC (authored by marius).
Add trademark entities for Fujitsu Limited and update those of SPARC
Dec 13 2020, 5:32 PM
marius committed R9:23026adfd4cf: According to simon@ when referring to a company along a product just to (authored by marius).
According to simon@ when referring to a company along a product just to
Dec 13 2020, 5:32 PM
marius committed R9:57ce0da7fe68: Fix a copy&paste error in rev 1.39. (authored by marius).
Fix a copy&paste error in rev 1.39.
Dec 13 2020, 5:26 PM
marius committed R9:3d00124eb2fa: Add missing 'r' in a SVN revision identifier in one of my reports. (authored by marius).
Add missing 'r' in a SVN revision identifier in one of my reports.
Dec 13 2020, 5:24 PM

Jan 24 2020

marius added a comment to D23315: Make sure end of receive doesn't cause interrupt starvation in iflib.

I don't think any of the past corporate sponsors of this work are stepping up so the community is going to have to here. @marius you have the most recent experience looking deeply at the e1000 code, can you share an opinion on the issue and proposal?

Jan 24 2020, 12:51 AM

Dec 28 2019

marius committed rP521244: Reword INFO_DESC to better reflect that it's about documentation in GNU.
Reword INFO_DESC to better reflect that it's about documentation in GNU
Dec 28 2019, 9:24 PM
marius committed rP521229: Bring back the somewhat more appropriate INFO_DESC from pre-r521020..
Bring back the somewhat more appropriate INFO_DESC from pre-r521020.
Dec 28 2019, 6:09 PM
marius committed rP521228: Fix r521031 to correctly handle the case when texinfo is already installed.
Fix r521031 to correctly handle the case when texinfo is already installed
Dec 28 2019, 5:55 PM

Dec 27 2019

marius committed rP521031: - Turn building and installation of cvs info documentation into an option.
- Turn building and installation of cvs info documentation into an option
Dec 27 2019, 10:52 PM
marius committed rP521020: Add and use a shared INFO description. I have patches to add that knob to.
Add and use a shared INFO description. I have patches to add that knob to
Dec 27 2019, 7:25 PM

Nov 30 2019

marius accepted D22600: Pass 0 to __builtin_frame_address() to appease modern GCC..

looks good to me

Nov 30 2019, 12:14 AM

Nov 21 2019

marius added a comment to D22430: (RFC) sdhci_generic_intr: only handle bits that are enabled in slot->intmask.

I'm inclined to say that this change is okay, I'm having problems to understand its motivation, though. First off, bcm_sdhci_intr() already wraps around sdhci_generic_intr() so I don't see why sdhci_bcm(4) shouldn't actually be able to nab SDHCI interrupts before sdhci(4) does. Granted, there's the case of sdhci(4) calling sdhci_generic_intr() directly when dumping. However, when dumping in case of a panic, the scheduler is stopped so the interrupt thread for bcm_sdhci_dma_intr() shouldn't get to run either. Thus, it's not obvious to me how panic dumping currently can work at all in the first place if sdhci_bcm(4) uses DMA for these requests.
Second, "platform-driven transfer [...] keeping the bits enabled in SDHCI_INT_ENABLE for internal handling" sounds like using SDHCI_INT_ENABLE as a mere scratchpad register in the platform-specific code. If that's what you mean, it generally would be better implemented using e. g. a variable or a member in the front-end-specific softc.

Nov 21 2019, 4:07 PM

Oct 30 2019

marius committed rS354209: MFC: r353778 (partial).
MFC: r353778 (partial)
Oct 30 2019, 9:49 PM
marius committed rS354208: MFC: r353778 (partial).
MFC: r353778 (partial)
Oct 30 2019, 9:48 PM

Oct 24 2019

marius committed rS354021: MFC: r353778.
MFC: r353778
Oct 24 2019, 2:18 PM

Oct 20 2019

marius committed rS353778: - In em_intr(), just call em_handle_link() instead of duplicating it..
- In em_intr(), just call em_handle_link() instead of duplicating it.
Oct 20 2019, 5:41 PM
marius closed D21924: e1000: improve and correct link interrupt handling.
Oct 20 2019, 5:41 PM

Oct 7 2019

marius added a comment to D21769: em/igb: Properly re-arm link interrupt.

I think this patch isn't entirely correct and complete; em_msix_link() should set EM_MSIX_LINK only for 82574 and em_if_update_admin_status() should only re-arm LSC interrupts if the driver takes advantage of autoclearing and, thus, uses MSI-X for such a device.
I've created D21924 with my version of the fix, which takes the above into account.

Oct 7 2019, 7:59 PM
marius created D21924: e1000: improve and correct link interrupt handling.
Oct 7 2019, 7:58 PM
marius accepted D21797: Add IFCAP_NOMAP to iflib.

Looks good to me

Oct 7 2019, 7:36 PM

Aug 28 2019

marius added a comment to D21421: Split out a more generic debugnet(4) from netdump(4).

I generally agree with the style(9) argument, however, if_t explicitly was introduced in r266974 as part of the - back then - new API:
"This commit introduces the 'if_t' type to replace 'struct ifnet *'as the type of a network interface."
So I'd say that new code no longer should use struct ifnet * (netdump(4) was added in r333283, so should have used if_t, too).

Aug 28 2019, 6:13 PM
D21421: Split out a more generic debugnet(4) from netdump(4) now requires changes to proceed.

Could you please consistently use if_t instead of struct ifnet * in debugnet(4) components and its support code in e. g. drivers?
IIRC, there's already quite some mixing and matching in that regard in netdump(4) counterparts, for example:
typedef void netdump_init_t(struct ifnet *, int *nrxr, int *ncl, int *clsize);
but:
bge_netdump_init(if_t ifp, int *nrxr, int *ncl, int *clsize)

Aug 28 2019, 3:59 PM

Jun 26 2019

marius committed rS349414: o In iflib_txq_drain():.
o In iflib_txq_drain():
Jun 26 2019, 3:28 PM
D20747: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration is now accepted and ready to land.

Looks good to me now, thanks.
For committing, please extend the commit message to additionally state
that the iflib(4) interrupt allocation needs re-doing not only to also support
single-message MSI-X and MSI-X-only devices, but for none-PCI devices
and multiple interrupt vectors that are not MSI-X as well, though.

Jun 26 2019, 12:57 PM

Jun 24 2019

D20747: iflib: Prevent kernel panic caused by loading driver with a specific interrupt configuration now requires changes to proceed.

Apart from the style problem, this change looks good to me.
Have you looked at how hard it would be to actually support configurations
with just 1 MSI-X, though? I think to remember the assumption that a single
interrupt means what iflib(4) calls "legacy", i. e. INTx or MSI, in 1 or 2 places
and generally iflib(4) would need to be made less smart and not so aggressive
in setting up interrupts, but nothing which seemed that much work.

Jun 24 2019, 8:42 PM

Jun 16 2019

marius committed rS349114: MFC: r347390.
MFC: r347390
Jun 16 2019, 3:34 PM
marius committed rS349113: MFC: r347222.
MFC: r347222
Jun 16 2019, 3:30 PM
marius committed rS349112: MFC: r347221, r347245.
MFC: r347221, r347245
Jun 16 2019, 3:26 PM
marius committed rS349110: MFC: r347211.
MFC: r347211
Jun 16 2019, 3:12 PM
marius committed rS349109: MFC: r344062 (partial).
MFC: r344062 (partial)
Jun 16 2019, 2:54 PM
marius committed rS349103: MFC: r344060, r344064.
MFC: r344060, r344064
Jun 16 2019, 11:35 AM
Herald added a reviewer for D19081: Further correct and optimize the bus_dma(9) usage of iflib(4): iflib.
Jun 16 2019, 11:35 AM
marius committed rS349102: MFC: r343979.
MFC: r343979
Jun 16 2019, 10:46 AM

Jun 15 2019

marius committed rS349055: - Replace unused and only ever written to members of public iflib(9).
- Replace unused and only ever written to members of public iflib(9)
Jun 15 2019, 11:08 AM
marius committed rS349054: Add <sys/dnv.h> required for libnv to SYSINCS, too, apparently missed.
Add <sys/dnv.h> required for libnv to SYSINCS, too, apparently missed
Jun 15 2019, 9:45 AM

Jun 7 2019

marius accepted D19747: Improve sdhci slot_printf() debug printing..

Thanks, looks good to me now

Jun 7 2019, 9:55 PM

May 22 2019

marius accepted D20290: Update Intel XL710 PF and VF drivers to version ixl-1.11.9 and ixlv-1.5.8.

Looks good to me; still needs re@ approval via the usual change request procedure for committing to stable/11 during the freeze, though.

May 22 2019, 5:56 PM
marius accepted D20221: iflib: provide probe wrapper for vendor drivers.

Looks good to me

May 22 2019, 5:55 PM

May 9 2019

marius committed rS347390: - Merge r338254 from cxgbe(4):.
- Merge r338254 from cxgbe(4):
May 9 2019, 11:35 AM

May 8 2019

marius added inline comments to D20204: First cut at cleaning up MP_RING_NO_64BIT_ATOMICS code.
May 8 2019, 11:54 PM