kern: add devctl_notifyf()
AcceptedPublic
Actions

Authored by kevans on Mar 9 2022, 5:24 AM.

Details

Reviewers

imp
bapt

Group Reviewers

manpages

Summary

This version is identical to devctl_notify(), except it fits slightly
less trivial needs by taking a data format string and varargs to go
with it. This lets us avoid extra allocations on top in various
callers, making them a bit less complicated.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63973
Build 60857: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Mar 9 2022, 5:24 AM

kevans created this revision.

kevans added a child revision: D34505: kern: switch various devfs_notify() callers to devfs_notifyf().

Harbormaster completed remote builds in B44718: Diff 103670.Mar 9 2022, 5:25 AM

Update manpage

Herald added a reviewer: manpages. · View Herald TranscriptMar 9 2022, 6:13 AM

Harbormaster completed remote builds in B44720: Diff 103672.Mar 9 2022, 6:13 AM

Manual page changes look good to me.

imp accepted this revision.Mar 9 2022, 3:56 PM

This revision is now accepted and ready to land.Mar 9 2022, 3:56 PM

Other than that, LGTM.

share/man/man9/devctl_notify.9
38	"userland", I think? I don't remember seeing it split.

kevans mentioned this in D49945: libsbuf: add an sbuf_prepend() API.Mon, Apr 21, 7:01 PM

Rebase past nlsysevent's devctl tap

Alright, hear me out, this isn't the ugliest thing I've ever written. This does
result in a functional difference for nlsysevent, in that we may not tap out an
nlsysevent if we couldn't allocate the sbuf/dei bits for whatever reason. I
don't think it's necessarily a bad difference, but it's a notable one.

This revision now requires review to proceed.Wed, May 7, 1:05 AM

Herald added subscribers: ziaee, olce. · View Herald TranscriptWed, May 7, 1:05 AM

Harbormaster completed remote builds in B63973: Diff 155018.Wed, May 7, 1:05 AM

Tap in bapt, too, since this could slightly change some nlsysevent semantics in more edgey cases.

bapt accepted this revision.Wed, May 7, 6:56 AM

This revision is now accepted and ready to land.Wed, May 7, 6:56 AM