Page MenuHomeFreeBSD

kern: add devctl_notifyf()
AcceptedPublic

Authored by kevans on Mar 9 2022, 5:24 AM.
Tags
None
Referenced Files
F131969341: D34504.id155018.diff
Sun, Oct 12, 2:32 PM
F131965203: D34504.id103672.diff
Sun, Oct 12, 1:46 PM
Unknown Object (File)
Fri, Oct 10, 3:46 AM
Unknown Object (File)
Wed, Oct 8, 8:36 AM
Unknown Object (File)
Mon, Oct 6, 3:41 AM
Unknown Object (File)
Thu, Oct 2, 9:32 PM
Unknown Object (File)
Wed, Oct 1, 2:58 PM
Unknown Object (File)
Tue, Sep 16, 11:18 AM

Details

Reviewers
imp
bapt
Group Reviewers
manpages
Summary

This version is identical to devctl_notify(), except it fits slightly
less trivial needs by taking a data format string and varargs to go
with it. This lets us avoid extra allocations on top in various
callers, making them a bit less complicated.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63973
Build 60857: arc lint + arc unit

Event Timeline

debdrup added a subscriber: debdrup.

Manual page changes look good to me.

This revision is now accepted and ready to land.Mar 9 2022, 3:56 PM

Other than that, LGTM.

share/man/man9/devctl_notify.9
38

"userland", I think? I don't remember seeing it split.

Rebase past nlsysevent's devctl tap

Alright, hear me out, this isn't the ugliest thing I've ever written. This does
result in a functional difference for nlsysevent, in that we may not tap out an
nlsysevent if we couldn't allocate the sbuf/dei bits for whatever reason. I
don't think it's necessarily a bad difference, but it's a notable one.

This revision now requires review to proceed.May 7 2025, 1:05 AM

Tap in bapt, too, since this could slightly change some nlsysevent semantics in more edgey cases.

This revision is now accepted and ready to land.May 7 2025, 6:56 AM