Page MenuHomeFreeBSD
Differential D34504

kern: add devctl_notifyf()
AcceptedPublic
Actions

Authored by kevans on Mar 9 2022, 5:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 6:42 AM
Unknown Object (File)
Jan 21 2024, 10:55 AM
Unknown Object (File)
Dec 24 2023, 3:41 PM
Unknown Object (File)
Dec 24 2023, 12:51 AM
Unknown Object (File)
Dec 20 2023, 3:33 AM
Unknown Object (File)
Nov 8 2023, 5:04 AM
Unknown Object (File)
Nov 6 2023, 12:26 PM
Unknown Object (File)
Nov 1 2023, 3:43 AM
View All 27 Files
Subscribers
debdrup
pauamma_gundo.com

Details

Reviewers
imp
Group Reviewers
manpages
Summary

This version is identical to devctl_notify(), except it fits slightly
less trivial needs by taking a data format string and varargs to go
with it. This lets us avoid extra allocations on top in various
callers, making them a bit less complicated.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44720
Build 41608: arc lint + arc unit

Event Timeline

kevans requested review of this revision.Mar 9 2022, 5:24 AM
kevans created this revision.
kevans added a child revision: D34505: kern: switch various devfs_notify() callers to devfs_notifyf().
Harbormaster completed remote builds in B44718: Diff 103670.Mar 9 2022, 5:25 AM
kevans updated this revision to Diff 103672.Mar 9 2022, 6:13 AM

Update manpage

Herald added a reviewer: manpages. · View Herald TranscriptMar 9 2022, 6:13 AM
Harbormaster completed remote builds in B44720: Diff 103672.Mar 9 2022, 6:13 AM
debdrup accepted this revision as: manpages.Mar 9 2022, 11:07 AM
debdrup added a subscriber: debdrup.

Manual page changes look good to me.

imp accepted this revision.Mar 9 2022, 3:56 PM
This revision is now accepted and ready to land.Mar 9 2022, 3:56 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Mar 10 2022, 1:06 AM

Other than that, LGTM.

share/man/man9/devctl_notify.9
40

"userland", I think? I don't remember seeing it split.

Revision Contents
Changeset List

PathSize
share/
man/
man9/
1 line
20 lines
sys/
kern/
32 lines
sys/
2 lines

Diff 103672

View Options

share/man/man9/Makefile

Loading...
View Options

share/man/man9/devctl_notify.9

Loading...
View Options

sys/kern/subr_bus.c

Loading...
View Options

sys/sys/devctl.h

Loading...